Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review213282 --- Ship it! Ship It! - Gilbert Song On Feb. 25, 2019, 7:07 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69547/ > --- > > (Updated Feb. 25, 2019, 7:07 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya > Pronin, and Jie Yu. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > --- > > Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. > > > Diffs > - > > src/tests/default_executor_tests.cpp > 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c > > > Diff: https://reviews.apache.org/r/69547/diff/4/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- (Updated Feb. 26, 2019, 11:07 a.m.) Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Changes --- Minor change. Bugs: MESOS-8813 https://issues.apache.org/jira/browse/MESOS-8813 Repository: mesos Description --- Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Diffs (updated) - src/tests/default_executor_tests.cpp 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c Diff: https://reviews.apache.org/r/69547/diff/4/ Changes: https://reviews.apache.org/r/69547/diff/3-4/ Testing --- sudo make check Thanks, Qian Zhang
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review213138 --- Ship it! Ship It! - Gilbert Song On Dec. 20, 2018, 4:57 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69547/ > --- > > (Updated Dec. 20, 2018, 4:57 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya > Pronin, and Jie Yu. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > --- > > Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. > > > Diffs > - > > src/tests/default_executor_tests.cpp > 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c > > > Diff: https://reviews.apache.org/r/69547/diff/3/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- (Updated Dec. 21, 2018, 8:57 a.m.) Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bugs: MESOS-8813 https://issues.apache.org/jira/browse/MESOS-8813 Repository: mesos Description --- Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Diffs (updated) - src/tests/default_executor_tests.cpp 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c Diff: https://reviews.apache.org/r/69547/diff/3/ Changes: https://reviews.apache.org/r/69547/diff/2-3/ Testing --- sudo make check Thanks, Qian Zhang
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211287 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Armand Grillet On Dec. 11, 2018, 1:17 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69547/ > --- > > (Updated Dec. 11, 2018, 1:17 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > --- > > Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. > > > Diffs > - > > src/tests/default_executor_tests.cpp > 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c > > > Diff: https://reviews.apache.org/r/69547/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211242 --- Ship it! Ship It! - Andrei Budnik On Dec. 11, 2018, 12:17 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69547/ > --- > > (Updated Dec. 11, 2018, 12:17 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > --- > > Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. > > > Diffs > - > > src/tests/default_executor_tests.cpp > 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c > > > Diff: https://reviews.apache.org/r/69547/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211190 --- PASS: Mesos patch 69547 was successfully built and tested. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', '69544', '67997', '68162', '68163', '69547']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2695/mesos-review-69547 - Mesos Reviewbot Windows On Dec. 11, 2018, 12:17 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69547/ > --- > > (Updated Dec. 11, 2018, 12:17 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > --- > > Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. > > > Diffs > - > > src/tests/default_executor_tests.cpp > 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c > > > Diff: https://reviews.apache.org/r/69547/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- (Updated Dec. 11, 2018, 8:17 p.m.) Review request for mesos. Changes --- Do not compile this test on Windows. Bugs: MESOS-8813 https://issues.apache.org/jira/browse/MESOS-8813 Repository: mesos Description --- Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Diffs (updated) - src/tests/default_executor_tests.cpp 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c Diff: https://reviews.apache.org/r/69547/diff/2/ Changes: https://reviews.apache.org/r/69547/diff/1-2/ Testing --- sudo make check Thanks, Qian Zhang
Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211184 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', '69544', '67997', '68162', '68163', '69547']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2694/mesos-review-69547 Relevant logs: - [mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2694/mesos-review-69547/logs/mesos-tests-cmake.log): ``` d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- Review request for mesos. Bugs: MESOS-8813 https://issues.apache.org/jira/browse/MESOS-8813 Repository: mesos Description --- Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. Diffs - src/tests/default_executor_tests.cpp 86c3a98ec9e3c5d9d8f2a88218dec1e56d0ebc4c Diff: https://reviews.apache.org/r/69547/diff/1/ Testing --- sudo make check Thanks, Qian Zhang
