Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-05-09 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/#review215171
---


Fix it, then Ship it!




Looks like the description didn't run through the git commit hooks?

```
$ ./support/apply-reviews.py -r 70531
2019-05-09 17:58:38 URL:https://reviews.apache.org/r/70531/diff/raw/ 
[2632/2632] -> "70531.patch" [1]
Checking 2 C++ files
Done processing src/master/master.cpp
Done processing src/master/master.hpp
Error: No line in the commit message summary may exceed 72 characters.
```


src/master/master.hpp
Lines 1148 (patched)


paren on the previous line


- Benjamin Mahler


On May 7, 2019, 11:15 a.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70531/
> ---
> 
> (Updated May 7, 2019, 11:15 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch replaces the `Call:Subscribe` message in the arguments of  
>   
> `Master::validateFrameworkSubscription()` with its constituents:  
>   
> the `FrameworkInfo` and the list of suppressed roles. 
> 
>   
>   
> The motivation behind this change is to help keep the new UPDATE_FRAMEWORK 
> call 
> (being introduced in MESOS-7258) consistent with re-subscribing the framework 
>   
> by using the same `Master::validateFrameworkSubscription()` method to 
> validate  
> both SUBSCRIBE and UPDATE_FRAMEWORK calls.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
>   src/master/master.cpp a8ee6297e1587c160a47b806914d3c3aa4f35cd7 
> 
> 
> Diff: https://reviews.apache.org/r/70531/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-05-07 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/
---

(Updated May 7, 2019, 11:15 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Fixed description.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description (updated)
---

This patch replaces the `Call:Subscribe` message in the arguments of
`Master::validateFrameworkSubscription()` with its constituents:
the `FrameworkInfo` and the list of suppressed roles.   
  

The motivation behind this change is to help keep the new UPDATE_FRAMEWORK call 
(being introduced in MESOS-7258) consistent with re-subscribing the framework   
by using the same `Master::validateFrameworkSubscription()` method to validate  
both SUBSCRIBE and UPDATE_FRAMEWORK calls.


Diffs
-

  src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
  src/master/master.cpp a8ee6297e1587c160a47b806914d3c3aa4f35cd7 


Diff: https://reviews.apache.org/r/70531/diff/3/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-05-02 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/
---

(Updated May 2, 2019, 3:58 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description (updated)
---

To keep the UPDATE_FRAMEWORK call consistent with re-subscription we need to be 
able to use the code in Master::validateFrameworkSubscription() to validate not 
only the Call:Subscribe but also the Call::UpdateFramework submessage. 

Thus I'm changing this method to take the FrameworkInfo and the list of 
suppressed roles as arguments (instead of Call::subscribe).


Diffs (updated)
-

  src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
  src/master/master.cpp a8ee6297e1587c160a47b806914d3c3aa4f35cd7 


Diff: https://reviews.apache.org/r/70531/diff/3/

Changes: https://reviews.apache.org/r/70531/diff/2-3/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-04-25 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/
---

(Updated April 25, 2019, 7:53 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description (updated)
---

To keep the UPDATE_FRAMEWORK call consistent with re-subscription we need to be 
able to use the code in `Master::validateFrameworkSubscription()` to validate 
not only the `Call:Subscribe` but also the `Call::UpdateFramework` submessage. 

Thus I'm making this method to take the `FrameworkInfo` and the list of 
suppressed roles as arguments (instead of `Call::subscribe`).


Diffs (updated)
-

  src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
  src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 


Diff: https://reviews.apache.org/r/70531/diff/2/

Changes: https://reviews.apache.org/r/70531/diff/1-2/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-04-24 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/#review214863
---



I'm puzzled about this change, can you add an explanatory description to the 
commit / review?

- Benjamin Mahler


On April 23, 2019, 7:04 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70531/
> ---
> 
> (Updated April 23, 2019, 7:04 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 94891af9deeaddbfc9d6eabb243aed97f7b7 
>   src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 
> 
> 
> Diff: https://reviews.apache.org/r/70531/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-04-23 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/
---

(Updated April 23, 2019, 7:04 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.


Diffs
-

  src/master/master.hpp 94891af9deeaddbfc9d6eabb243aed97f7b7 
  src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 


Diff: https://reviews.apache.org/r/70531/diff/1/


Testing
---


Thanks,

Andrei Sekretenko

Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-04-23 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.


Diffs (updated)
-

  src/master/master.hpp 94891af9deeaddbfc9d6eabb243aed97f7b7 
  src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 


Diff: https://reviews.apache.org/r/70531/diff/1/


Testing
---


Thanks,

Andrei Sekretenko