Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 17, 2019, 3 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Now the new call type is added to the switch statements in this patch. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description --- This patch definies the call to be used by a framework for updating its FrameworkInfo fields without re-subscribing. It is based on the previous implementation attempt: https://reviews.apache.org/r/66228/ Diffs (updated) - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 35a04a3d0183697f93dadb3cbfead3ee0c2fea08 src/master/http.cpp c2c7b9b65bd66679420f62d37b01d90e3692c71d src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d src/master/validation.cpp 9fb0850987ce385d345302cac9721adead7181b8 Diff: https://reviews.apache.org/r/70532/diff/6/ Changes: https://reviews.apache.org/r/70532/diff/5-6/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/#review215204 --- Ship it! Ship It! - Benjamin Mahler On May 10, 2019, 3 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70532/ > --- > > (Updated May 10, 2019, 3 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > --- > > This patch definies the call to be used by a framework for updating its > FrameworkInfo fields without re-subscribing. > > It is based on the previous implementation attempt: > https://reviews.apache.org/r/66228/ > > > Diffs > - > > include/mesos/scheduler/scheduler.proto > b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 > include/mesos/v1/scheduler/scheduler.proto > bddd5c449fd4b294d15430746b708731aff18f2a > > > Diff: https://reviews.apache.org/r/70532/diff/5/ > > > Testing > --- > > > Thanks, > > Andrei Sekretenko > >
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 10, 2019, 3 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- This patch definies the call to be used by a framework for updating its FrameworkInfo fields without re-subscribing. It is based on the previous implementation attempt: https://reviews.apache.org/r/66228/ Diffs (updated) - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/5/ Changes: https://reviews.apache.org/r/70532/diff/4-5/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 7, 2019, 1:06 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Added a brief description. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- This patch definies the call to be used by a framework for updating its FrameworkInfo fields without re-subscribing. It is based on the previous implementation attempt: https://reviews.apache.org/r/66228/ Diffs - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/4/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 2, 2019, 3:58 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Fixed the comment describing UpdateFramework. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- Added an UPDATE_FRAMEWORK scheduler::Call. Diffs (updated) - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/4/ Changes: https://reviews.apache.org/r/70532/diff/3-4/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated April 25, 2019, 8:37 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing. It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as Call::Subscribe. The previous attempt on which this review is based: https://reviews.apache.org/r/66228/ Diffs - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/3/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated April 25, 2019, 8:37 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing. It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as Call::Subscribe. The previous attempt on wich this review is based: https://reviews.apache.org/r/66228/ Diffs - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/3/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated April 25, 2019, 8:36 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing. It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as Call::Subscribe. The previous attempt on wich this review is based ://reviews.apache.org/r/66228/)? Diffs - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/3/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated April 25, 2019, 8:12 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- Added an UPDATE_FRAMEWORK scheduler::Call. Diffs (updated) - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/3/ Changes: https://reviews.apache.org/r/70532/diff/2-3/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated April 25, 2019, 8:01 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Fixed the comment describing the UpdateFramework call. Summary (updated) - Added an UPDATE_FRAMEWORK scheduler::Call. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description (updated) --- This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing. It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as `Call::Subscribe`. Diffs (updated) - include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a Diff: https://reviews.apache.org/r/70532/diff/2/ Changes: https://reviews.apache.org/r/70532/diff/1-2/ Testing --- Thanks, Andrei Sekretenko
