Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-05-22 Thread Meng Zhu 


> On May 6, 2019, 1:51 p.m., Benjamin Mahler wrote:
> > include/mesos/authorizer/acls.proto
> > Lines 135-143 (original), 135-152 (patched)
> > 
> >
> > Why do we need the two idential messages?
> > 
> > Seems like this needs to be spelled out in the comments and in the 
> > commit description, as it's not obvious

I realized that we do not need two messages. We can use the old UpdateQuota ACL 
to authorize both UPDATE_QUOTA and UPDATE_QUOTA_WITH_CONFIG actions. Removed.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review215072
---


On April 25, 2019, 4:14 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 25, 2019, 4:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-05-06 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review215079
---



Patch looks great!

Reviews applied: [70549, 70550]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 25, 2019, 11:14 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 25, 2019, 11:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-05-06 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review215072
---




include/mesos/authorizer/acls.proto
Lines 135-143 (original), 135-152 (patched)


Why do we need the two idential messages?

Seems like this needs to be spelled out in the comments and in the commit 
description, as it's not obvious


- Benjamin Mahler


On April 25, 2019, 11:14 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 25, 2019, 11:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-04-28 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review214932
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70549', '70550']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3273/mesos-review-70550

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3273/mesos-review-70550/logs/mesos-tests.log):

```
I0428 23:03:49.488590 83732 master.cpp:3312] Disconnecting agent 
b4b235e7-cd0f-4652-87b7-c4a065538232-S0 at slave(504)@192.10.1.4:62079 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0428 23:03:49.489593 83732 master.cpp:3331] Deactivating agent 
b4b235e7-cd0f-4652-87b7-c4a065538232-S0 at slave(504)@192.10.1.4:62079 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0428 23:03:49.489593 84924 hierarchical.cpp:392] Removed framework 
b4b235e7-cd0f-4652-87b7-c4a065538232-
I0428 23:03:49.489593 84924 hierarchical.cpp:829] Agent 
b4b235e7-cd0f-4652-87b7-c4a065538232-S0 deactivated
I0428 23:03:49.491643 84924 containerizer.cpp:2576] Destroying container 
54fdd540-4354-4883-aaea-72cc0d5b3b17 in RUNNING state
I0428 23:03:49.491643 84924 containerizer.cpp:3278] Transitioning the state of 
container 54fdd540-4354-4883-aaea-72cc0d5b3b17 from RUNNING to DESTROYING
I0428 23:03:49.491643 84924 launcher.cpp:161] Asked to destroy container 
54fdd540-4354-4883-aaea-72cc0d5b3b17
W0428 23:03:49.493603 62828 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5456 to peer '192.10.1.4:64516': IO failed with error 
code: The specified network name is n[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (884 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (905 ms total)

[--] Global test environment tear-down
[==] 1167 tests from 109 test cases ran. (607683 ms total)
[  PASSED  ] 1164 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

o longer available.

W0428 23:03:49.493603 62828 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5540 to peer '192.10.1.4:64517': IO failed with error 
code: The specified network name is no longer available.

I0428 23:03:49.578972 44168 containerizer.cpp:3117] Container 
54fdd540-4354-4883-aaea-72cc0d5b3b17 has exited
I0428 23:03:49.618001 82904 master.cpp:1135] Master terminating
I0428 23:03:49.619993 83732 hierarchical.cpp:680] Removed agent 
b4b235e7-cd0f-4652-87b7-c4a065538232-S0
I0428 23:03:52.021059 62828 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 25, 2019, 11:14 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 25, 2019, 11:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-04-28 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review214930
---



Patch looks great!

Reviews applied: [70549, 70550]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 25, 2019, 11:14 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 25, 2019, 11:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-04-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review214911
---



Bad patch!

Reviews applied: [70550, 70549]

Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 70549

Error:
https://reviews.apache.org/r/70549/diff/raw/:
2019-04-26 05:59:31 ERROR 404: NOT FOUND.

Full log: https://builds.apache.org/job/Mesos-Reviewbot-Linux/1038/console

- Mesos Reviewbot


On April 26, 2019, 4:44 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 26, 2019, 4:44 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-04-25 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/#review214904
---



FAIL: Failed to apply the dependent review: 70549.

Failed command: `python.exe .\support\apply-reviews.py -n -r 70549`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3264/mesos-review-70550

Relevant logs:

- 
[apply-review-70549.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3264/mesos-review-70550/logs/apply-review-70549.log):

```
Traceback (most recent call last):
  File ".\support\apply-reviews.py", line 452, in 
main()
  File ".\support\apply-reviews.py", line 447, in main
reviewboard(options)
  File ".\support\apply-reviews.py", line 437, in reviewboard
apply_review(options)
  File ".\support\apply-reviews.py", line 163, in apply_review
fetch_patch(options)
  File ".\support\apply-reviews.py", line 200, in fetch_patch
context=ssl_create_default_context())
  File "C:\Program Files\Python36\lib\urllib\request.py", line 223, in urlopen
return opener.open(url, data, timeout)
  File "C:\Program Files\Python36\lib\urllib\request.py", line 532, in open
response = meth(req, response)
  File "C:\Program Files\Python36\lib\urllib\request.py", line 642, in 
http_response
'http', request, response, code, msg, hdrs)
  File "C:\Program Files\Python36\lib\urllib\request.py", line 570, in error
return self._call_chain(*args)
  File "C:\Program Files\Python36\lib\urllib\request.py", line 504, in 
_call_chain
result = func(*args)
  File "C:\Program Files\Python36\lib\urllib\request.py", line 650, in 
http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: NOT FOUND
```

- Mesos Reviewbot Windows


On April 25, 2019, 11:14 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70550/
> ---
> 
> (Updated April 25, 2019, 11:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-9640
> https://issues.apache.org/jira/browse/MESOS-9640
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a test.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
>   include/mesos/authorizer/authorizer.hpp 
> a86a6eeb592adfc267dcf3faef40e8da3471feaf 
>   src/authorizer/local/authorizer.cpp 
> ec86f053357e4bc85532ea4073b57b272ffc74fe 
>   src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 
> 
> 
> Diff: https://reviews.apache.org/r/70550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-04-25 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70550/
---

Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till 
Toenshoff.


Bugs: MESOS-9640
https://issues.apache.org/jira/browse/MESOS-9640


Repository: mesos


Description
---

Also added a test.


Diffs
-

  include/mesos/authorizer/acls.proto 85a3979bc02ab0145a0934f29eeef7bb65f3c42c 
  include/mesos/authorizer/authorizer.hpp 
a86a6eeb592adfc267dcf3faef40e8da3471feaf 
  src/authorizer/local/authorizer.cpp ec86f053357e4bc85532ea4073b57b272ffc74fe 
  src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee 


Diff: https://reviews.apache.org/r/70550/diff/1/


Testing
---

make check


Thanks,

Meng Zhu