Re: Review Request 70564: Fixed a performance issue in the random sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70564/#review214960 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70564']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3295/mesos-review-70564 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3295/mesos-review-70564/logs/mesos-tests.log): ``` I0430 10:25:36.689410 83564 master.cpp:3312] Disconnecting agent 4af6c3a4-e700-47a3-9216-aa0496307f57-S0 at slave(504)@192.10.1.4:59624 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0430 10:25:36.689410 83564 master.cpp:3331] Deactivating agent 4af6c3a4-e700-47a3-9216-aa0496307f57-S0 at slave(504)@192.10.1.4:59624 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0430 10:25:36.689410 82088 hierarchical.cpp:392] Removed framework 4af6c3a4-e700-47a3-9216-aa0496307f57- I0430 10:25:36.689410 82088 hierarchical.cpp:829] Agent 4af6c3a4-e700-47a3-9216-aa0496307f57-S0 deactivated I0430 10:25:36.691385 88920 containerizer.cpp:2586] Destroying container 959b4cc7-e242-44a2-8290-d8cd5175f5dd in RUNNING state I0430 10:25:36.691385 88920 containerizer.cpp:3288] Transitioning the state of container 959b4cc7-e242-44a2-8290-d8cd5175f5dd from RUNNING to DESTROYING I0430 10:25:36.691385 88920 launcher.cpp:161] Asked to destroy container 959b4cc7-e242-44a2-8290-d8cd5175f5dd W0430 10:25:36.692384 85964 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=5232 to peer '192.10.1.4:61999': IO failed with error code: The specified network name is no longer available. W0430[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (790 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (807 ms total) [--] Global test environment tear-down [==] 1166 tests from 109 test cases ran. (605058 ms total) [ PASSED ] 1163 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 3 FAILED TESTS YOU HAVE 233 DISABLED TESTS 10:25:36.693365 85964 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=4168 to peer '192.10.1.4:62000': IO failed with error code: The specified network name is no longer available. I0430 10:25:36.710387 82088 containerizer.cpp:3127] Container 959b4cc7-e242-44a2-8290-d8cd5175f5dd has exited I0430 10:25:36.742403 88308 master.cpp:1135] Master terminating I0430 10:25:36.743381 83564 hierarchical.cpp:680] Removed agent 4af6c3a4-e700-47a3-9216-aa0496307f57-S0 I0430 10:25:38.289382 85964 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 29, 2019, 5:28 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70564/ > --- > > (Updated April 29, 2019, 5:28 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Fixed a performance issue in the random sorter. > > > Diffs > - > > src/master/allocator/sorter/random/sorter.cpp > f4132bbacd590389ae156f964d2463e79db5e27f > > > Diff: https://reviews.apache.org/r/70564/diff/1/ > > > Testing > --- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5 > > Before: > Added 3000 agents in 88.759226ms > Added 3000 frameworks in 19.519956346secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 19.091583161secs > Made 0 allocation in 18.428433277secs > > After: > > Added 3000 agents in 87.972155ms > Added 3000 frameworks in 19.372715548secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3856 allocations in 15.846013158secs > Made 0 allocation in 15.756238099secs > > > Thanks, > > Meng Zhu > >
Re: Review Request 70564: Fixed a performance issue in the random sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70564/#review214947 --- Ship it! Ship It! - Benjamin Mahler On April 29, 2019, 5:28 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70564/ > --- > > (Updated April 29, 2019, 5:28 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Fixed a performance issue in the random sorter. > > > Diffs > - > > src/master/allocator/sorter/random/sorter.cpp > f4132bbacd590389ae156f964d2463e79db5e27f > > > Diff: https://reviews.apache.org/r/70564/diff/1/ > > > Testing > --- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5 > > Before: > Added 3000 agents in 88.759226ms > Added 3000 frameworks in 19.519956346secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 19.091583161secs > Made 0 allocation in 18.428433277secs > > After: > > Added 3000 agents in 87.972155ms > Added 3000 frameworks in 19.372715548secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3856 allocations in 15.846013158secs > Made 0 allocation in 15.756238099secs > > > Thanks, > > Meng Zhu > >
Re: Review Request 70564: Fixed a performance issue in the random sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70564/#review214942 --- Patch looks great! Reviews applied: [70564] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 29, 2019, 5:28 a.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70564/ > --- > > (Updated April 29, 2019, 5:28 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Fixed a performance issue in the random sorter. > > > Diffs > - > > src/master/allocator/sorter/random/sorter.cpp > f4132bbacd590389ae156f964d2463e79db5e27f > > > Diff: https://reviews.apache.org/r/70564/diff/1/ > > > Testing > --- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5 > > Before: > Added 3000 agents in 88.759226ms > Added 3000 frameworks in 19.519956346secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter > Made 3856 allocations in 19.091583161secs > Made 0 allocation in 18.428433277secs > > After: > > Added 3000 agents in 87.972155ms > Added 3000 frameworks in 19.372715548secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3856 allocations in 15.846013158secs > Made 0 allocation in 15.756238099secs > > > Thanks, > > Meng Zhu > >
Review Request 70564: Fixed a performance issue in the random sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70564/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Fixed a performance issue in the random sorter. Diffs - src/master/allocator/sorter/random/sorter.cpp f4132bbacd590389ae156f964d2463e79db5e27f Diff: https://reviews.apache.org/r/70564/diff/1/ Testing --- make check Benchmarking: Optimized build with QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5 Before: Added 3000 agents in 88.759226ms Added 3000 frameworks in 19.519956346secs Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter Made 3856 allocations in 19.091583161secs Made 0 allocation in 18.428433277secs After: Added 3000 agents in 87.972155ms Added 3000 frameworks in 19.372715548secs Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks Made 3856 allocations in 15.846013158secs Made 0 allocation in 15.756238099secs Thanks, Meng Zhu
