Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-30 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214967
---


Ship it!




Ship It!

- Gilbert Song


On April 29, 2019, 11:39 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 11:39 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-30 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214966
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70567']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3299/mesos-review-70567

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3299/mesos-review-70567/logs/mesos-tests.log):

```
I0430 20:30:29.901481 90928 master.cpp:3312] Disconnecting agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0 at slave(504)@192.10.1.4:52888 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 20:30:29.901481 90928 master.cpp:3331] Deactivating agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0 at slave(504)@192.10.1.4:52888 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 20:30:29.901481 87944 hierarchical.cpp:392] Removed framework 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-
I0430 20:30:29.902482 87944 hierarchical.cpp:829] Agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0 deactivated
I0430 20:30:29.903481 87944 containerizer.cpp:2586] Destroying container 
9619350c-f543-47be-aabe-83458a2fce93 in RUNNING state
I0430 2[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (785 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (805 ms total)

[--] Global test environment tear-down
[==] 1166 tests from 109 test cases ran. (595892 ms total)
[  PASSED  ] 1163 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

0:30:29.903481 87944 containerizer.cpp:3288] Transitioning the state of 
container 9619350c-f543-47be-aabe-83458a2fce93 from RUNNING to DESTROYING
I0430 20:30:29.904494 87944 launcher.cpp:161] Asked to destroy container 
9619350c-f543-47be-aabe-83458a2fce93
W0430 20:30:29.905477 89680 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=9844 to peer '192.10.1.4:55300': IO failed with error 
code: The specified network name is no longer available.

W0430 20:30:29.905477 89680 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=9744 to peer '192.10.1.4:55301': IO failed with error 
code: The specified network name is no longer available.

I0430 20:30:29.997475 90928 containerizer.cpp:3127] Container 
9619350c-f543-47be-aabe-83458a2fce93 has exited
I0430 20:30:30.028479 82408 master.cpp:1135] Master terminating
I0430 20:30:30.029481 90928 hierarchical.cpp:680] Removed agent 
c4a9af6d-a462-4cbf-882b-c297de8b49e6-S0
I0430 20:30:31.452474 89680 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-30 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214965
---



Patch looks great!

Reviews applied: [70567]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-30 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214963
---


Fix it, then Ship it!




LGTM


src/slave/containerizer/mesos/isolators/linux/seccomp.cpp
Lines 35 (patched)


s/the/The/


- Vinod Kone


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-30 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214961
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70567']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3297/mesos-review-70567

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3297/mesos-review-70567/logs/mesos-tests.log):

```
I0430 11:41:34.875912 88944 master.cpp:3312] Disconnecting agent 
44ba2b61-f29a-48b5-af60-900144842795-S0 at slave(504)@192.10.1.4:62292 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 11:41:34.875912 88944 master.cpp:3331] Deactivating agent 
44ba2b61-f29a-48b5-af60-900144842795-S0 at slave(504)@192.10.1.4:62292 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0430 11:41:34.875912 87492 hierarchical.cpp:392] Removed framework 
44ba2b61-f29a-48b5-af60-900144842795-
I0430 11:41:34.875912 87492 hierarchical.cpp:829] Agent 
44ba2b61-f29a-48b5-af60-900144842795-S0 deactivated
I0430 11:41:34.891489 77184 containerizer.cpp:2586] Destroying container 
99ac903c-8c52-4462-8d58-31c250a935fb in RUNNING state
I0430 11:41:34.891489 77184 containerizer.cpp:3288] Transitioning the state of 
container 99ac903c-8c52-4462-8d58-31c250a935fb from RUNNING to DESTROYING
I0430 11:41:34.891489 77184 launcher.cpp:161] Asked to destroy container 
99ac903c[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (861 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (879 ms total)

[--] Global test environment tear-down
[==] 1166 tests from 109 test cases ran. (607272 ms total)
[  PASSED  ] 1163 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

-8c52-4462-8d58-31c250a935fb
W0430 11:41:34.891489 84244 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=4808 to peer '192.10.1.4:64715': IO failed with error 
code: The specified network name is no longer available.

W0430 11:41:34.891489 84244 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=4776 to peer '192.10.1.4:64716': IO failed with error 
code: The specified network name is no longer available.

I0430 11:41:34.985258 86352 containerizer.cpp:3127] Container 
99ac903c-8c52-4462-8d58-31c250a935fb has exited
I0430 11:41:35.016525 87160 master.cpp:1135] Master terminating
I0430 11:41:35.016525 87696 hierarchical.cpp:680] Removed agent 
44ba2b61-f29a-48b5-af60-900144842795-S0
I0430 11:41:37.097225 84244 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-29 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/#review214954
---



Patch looks great!

Reviews applied: [70567]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 29, 2019, 6:39 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70567/
> ---
> 
> (Updated April 29, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes dependency on `linux/seccomp.h` header, which
> may be missing on some Linux distributions.
> 
> 
> Diffs
> -
> 
>   configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
> 5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 
> 
> 
> Diff: https://reviews.apache.org/r/70567/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 70567: Allowed compiling Seccomp isolator on older kernel versions.

2019-04-29 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70567/
---

Review request for mesos, Benno Evers, Gilbert Song, and Qian Zhang.


Repository: mesos


Description
---

This patch removes dependency on `linux/seccomp.h` header, which
may be missing on some Linux distributions.


Diffs
-

  configure.ac e5afde4fcae320facd4a7cf2961999b238812b4b 
  src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 
5624c24fc08f0eeb5cccff9cfb2fe22eef4bfb50 


Diff: https://reviews.apache.org/r/70567/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik