Re: Review Request 70664: Made `activateRecoveredFramework()` return void instead of Nothing().

2019-05-20 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70664/#review215372
---


Ship it!




Thanks! I was a bit confused at first from the summary, I think the key part is 
that we're going from a Try to a void, rather than a Nothing to a void.

- Benjamin Mahler


On May 17, 2019, 3:02 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70664/
> ---
> 
> (Updated May 17, 2019, 3:02 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `Master::activateRecoveredFramework()` method always returns
> `Nothing()`. This patch changes its return type to `void` and removes
> the unused error handling code.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c523c937e294eaffe0e58306c267770c119c9f42 
>   src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d 
> 
> 
> Diff: https://reviews.apache.org/r/70664/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Review Request 70664: Made `activateRecoveredFramework()` return void instead of Nothing().

2019-05-17 Thread Andrei Sekretenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70664/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

The `Master::activateRecoveredFramework()` method always returns
`Nothing()`. This patch changes its return type to `void` and removes
the unused error handling code.


Diffs
-

  src/master/master.hpp c523c937e294eaffe0e58306c267770c119c9f42 
  src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d 


Diff: https://reviews.apache.org/r/70664/diff/1/


Testing
---


Thanks,

Andrei Sekretenko