Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-08-01 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/#review217024
---


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Line 330 (original), 330 (patched)


Fits in one line.


- Chun-Hung Hsiao


On July 29, 2019, 8:56 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71148/
> ---
> 
> (Updated July 29, 2019, 8:56 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Explicitly disabled periodic reconciliation for some provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69b59d48ceefebbb7accefe411c54ac5cecff1c3 
> 
> 
> Diff: https://reviews.apache.org/r/71148/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-07-29 Thread Benjamin Bannier 


> On July 26, 2019, 6:40 a.m., Chun-Hung Hsiao wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 846 (original), 846 (patched)
> > 
> >
> > How about using zero here, as described in `mesos.proto`?
> > 
> > And since most tests require no reconciliation, maybe making zero the 
> > default in `setupResourceProviderConfig`?

Makes sense. This actually uncovered that this series was incorrectly handling 
the zero duration case. Fixed the issue you raised here and corrected the 
handling.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/#review216877
---


On July 29, 2019, 10:56 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71148/
> ---
> 
> (Updated July 29, 2019, 10:56 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Explicitly disabled periodic reconciliation for some provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69b59d48ceefebbb7accefe411c54ac5cecff1c3 
> 
> 
> Diff: https://reviews.apache.org/r/71148/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-07-29 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/
---

(Updated July 29, 2019, 10:56 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Disable csi reconciliation in storage tests by default


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Explicitly disabled periodic reconciliation for some provider tests.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
69b59d48ceefebbb7accefe411c54ac5cecff1c3 


Diff: https://reviews.apache.org/r/71148/diff/2/

Changes: https://reviews.apache.org/r/71148/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-07-25 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/#review216877
---




src/tests/storage_local_resource_provider_tests.cpp
Line 846 (original), 846 (patched)


How about using zero here, as described in `mesos.proto`?

And since most tests require no reconciliation, maybe making zero the 
default in `setupResourceProviderConfig`?


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71148/
> ---
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Explicitly disabled periodic reconciliation for some provider tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 69861265d94ddf344da96b593797ce145394413e 
> 
> 
> Diff: https://reviews.apache.org/r/71148/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

2019-07-23 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/
---

Review request for mesos and Chun-Hung Hsiao.


Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254


Repository: mesos


Description
---

Explicitly disabled periodic reconciliation for some provider tests.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
69861265d94ddf344da96b593797ce145394413e 


Diff: https://reviews.apache.org/r/71148/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier