Re: Review Request 71263: Re-wrote the quota documentation to reflect quota limits.

[Benjamin Mahler]

> On Aug. 12, 2019, 6:51 p.m., Meng Zhu wrote:
> > Thanks for adding this. I like the brevity of the doc!
> > 
> > I think we should at least try to explain consumptions a bit. We mentioned 
> > this a few times in the doc, and it also shows up in the UI and endpoint 
> > response.
> > Maybe a note after viewing qutoa.
> > 
> > - A role's quota consumption includes both allocated an reserved. The 
> > latter is accounted even if it is not allocated. Outstanding offered 
> > resources are not charged against quota.

Ah, thanks for catching this!


> On Aug. 12, 2019, 6:51 p.m., Meng Zhu wrote:
> > docs/quota.md
> > Line 94 (original), 77-78 (patched)
> > 
> >
> > I suggest removing this point, since
> > 
> > - This is a minor low-level detail. 
> > - It also could be confusing if the reader thinks offered resources is 
> > also part of the consumption.
> > - This might change in the future if do admission control when 
> > accepting offers.

Ok, sounds reasonable. What I had in my mind when adding this was that this is 
only an "attempt" and therefore someone might see a quota limit get exceeded 
after they set it, which can be confusing. But if the "attempt" is overly 
aggressive at rescinding, that seems ok to me. Is it the latter?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71263/#review217159
---


On Aug. 9, 2019, 4:53 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71263/
> ---
> 
> (Updated Aug. 9, 2019, 4:53 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9427
> https://issues.apache.org/jira/browse/MESOS-9427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This takes a simpler approach compared to the previous version,
> which explained too many details that were not important for the
> user to understand.
> 
> This also documents that quota guarantees are deprecated and why.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md dd09845899a304885f12fa2e7682527ec9590a59 
>   docs/quota.md c42d5cd69a4534a71879e29be49b7fd7d9d075f6 
> 
> 
> Diff: https://reviews.apache.org/r/71263/diff/1/
> 
> 
> Testing
> ---
> 
> Review the rendered version here:
> 
> https://gist.github.com/bmahler/f85b67f5c7d0f2d7970d37a926f0d778
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71263: Re-wrote the quota documentation to reflect quota limits.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71263/#review217159
---



Thanks for adding this. I like the brevity of the doc!

I think we should at least try to explain consumptions a bit. We mentioned this 
a few times in the doc, and it also shows up in the UI and endpoint response.
Maybe a note after viewing qutoa.

- A role's quota consumption includes both allocated an reserved. The latter is 
accounted even if it is not allocated. Outstanding offered resources are not 
charged against quota.


docs/quota.md
Line 94 (original), 77-78 (patched)


I suggest removing this point, since

- This is a minor low-level detail. 
- It also could be confusing if the reader thinks offered resources is also 
part of the consumption.
- This might change in the future if do admission control when accepting 
offers.


- Meng Zhu


On Aug. 9, 2019, 9:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71263/
> ---
> 
> (Updated Aug. 9, 2019, 9:53 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9427
> https://issues.apache.org/jira/browse/MESOS-9427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This takes a simpler approach compared to the previous version,
> which explained too many details that were not important for the
> user to understand.
> 
> This also documents that quota guarantees are deprecated and why.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md dd09845899a304885f12fa2e7682527ec9590a59 
>   docs/quota.md c42d5cd69a4534a71879e29be49b7fd7d9d075f6 
> 
> 
> Diff: https://reviews.apache.org/r/71263/diff/1/
> 
> 
> Testing
> ---
> 
> Review the rendered version here:
> 
> https://gist.github.com/bmahler/f85b67f5c7d0f2d7970d37a926f0d778
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71263: Re-wrote the quota documentation to reflect quota limits.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71263/#review217146
---



Patch looks great!

Reviews applied: [71263]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 9, 2019, 9:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71263/
> ---
> 
> (Updated Aug. 9, 2019, 9:53 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9427
> https://issues.apache.org/jira/browse/MESOS-9427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This takes a simpler approach compared to the previous version,
> which explained too many details that were not important for the
> user to understand.
> 
> This also documents that quota guarantees are deprecated and why.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md dd09845899a304885f12fa2e7682527ec9590a59 
>   docs/quota.md c42d5cd69a4534a71879e29be49b7fd7d9d075f6 
> 
> 
> Diff: https://reviews.apache.org/r/71263/diff/1/
> 
> 
> Testing
> ---
> 
> Review the rendered version here:
> 
> https://gist.github.com/bmahler/f85b67f5c7d0f2d7970d37a926f0d778
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 71263: Re-wrote the quota documentation to reflect quota limits.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71263/
---

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-9427
https://issues.apache.org/jira/browse/MESOS-9427


Repository: mesos


Description
---

This takes a simpler approach compared to the previous version,
which explained too many details that were not important for the
user to understand.

This also documents that quota guarantees are deprecated and why.


Diffs
-

  docs/operator-http-api.md dd09845899a304885f12fa2e7682527ec9590a59 
  docs/quota.md c42d5cd69a4534a71879e29be49b7fd7d9d075f6 


Diff: https://reviews.apache.org/r/71263/diff/1/


Testing
---

Review the rendered version here:

https://gist.github.com/bmahler/f85b67f5c7d0f2d7970d37a926f0d778


Thanks,

Benjamin Mahler