Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71663/#review218779 --- Ship it! Ship It! - Till Toenshoff On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71663/ > --- > > (Updated Oct. 23, 2019, 7:37 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > --- > > Depending on the version of OpenSSL and what headers of OpenSSL > are included, the order of certain Windows headers may be included > in the "wrong" order. This results in hundreds of cryptic syntax > errors from MSVC. > > This sweeps through the existing sites with OpenSSL headers and > makes sure to include the Windows headers above them. > > > Diffs > - > > 3rdparty/libprocess/include/process/jwt.hpp > 62bf5c2ac3fcb6b76c88cd691d001358a4cb0aa6 > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 4a14a8ef7937e8c6adf3a78db3e9558333700a1b > 3rdparty/libprocess/include/process/ssl/tls_config.hpp > 18c51a8baabf07143c7892dbee0ad2d856457d8d > 3rdparty/libprocess/src/openssl.cpp > bd05866950e1043d9585a7c5fdc7b2147a233fd3 > 3rdparty/libprocess/src/ssl/utilities.cpp > c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 > > > Diff: https://reviews.apache.org/r/71663/diff/2/ > > > Testing > --- > > cmake --build . (Windows) > > > Thanks, > > Joseph Wu > >
Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71663/#review218660 --- Ship it! Ship It! - Benno Evers On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71663/ > --- > > (Updated Oct. 23, 2019, 7:37 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > --- > > Depending on the version of OpenSSL and what headers of OpenSSL > are included, the order of certain Windows headers may be included > in the "wrong" order. This results in hundreds of cryptic syntax > errors from MSVC. > > This sweeps through the existing sites with OpenSSL headers and > makes sure to include the Windows headers above them. > > > Diffs > - > > 3rdparty/libprocess/include/process/jwt.hpp > 62bf5c2ac3fcb6b76c88cd691d001358a4cb0aa6 > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 4a14a8ef7937e8c6adf3a78db3e9558333700a1b > 3rdparty/libprocess/include/process/ssl/tls_config.hpp > 18c51a8baabf07143c7892dbee0ad2d856457d8d > 3rdparty/libprocess/src/openssl.cpp > bd05866950e1043d9585a7c5fdc7b2147a233fd3 > 3rdparty/libprocess/src/ssl/utilities.cpp > c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 > > > Diff: https://reviews.apache.org/r/71663/diff/2/ > > > Testing > --- > > cmake --build . (Windows) > > > Thanks, > > Joseph Wu > >
Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71663/#review218370 --- Bad review! Reviews applied: [71663, 71662, 71661, 71660, 71659] Error: 2019-10-23 21:03:24 URL:https://reviews.apache.org/r/71663/diff/raw/ [3198/3198] -> "71663.patch" [1] error: patch failed: 3rdparty/libprocess/src/openssl.cpp:18 error: 3rdparty/libprocess/src/openssl.cpp: patch does not apply - Mesos Reviewbot On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71663/ > --- > > (Updated Oct. 23, 2019, 7:37 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > --- > > Depending on the version of OpenSSL and what headers of OpenSSL > are included, the order of certain Windows headers may be included > in the "wrong" order. This results in hundreds of cryptic syntax > errors from MSVC. > > This sweeps through the existing sites with OpenSSL headers and > makes sure to include the Windows headers above them. > > > Diffs > - > > 3rdparty/libprocess/include/process/jwt.hpp > 62bf5c2ac3fcb6b76c88cd691d001358a4cb0aa6 > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 4a14a8ef7937e8c6adf3a78db3e9558333700a1b > 3rdparty/libprocess/include/process/ssl/tls_config.hpp > 18c51a8baabf07143c7892dbee0ad2d856457d8d > 3rdparty/libprocess/src/openssl.cpp > bd05866950e1043d9585a7c5fdc7b2147a233fd3 > 3rdparty/libprocess/src/ssl/utilities.cpp > c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 > > > Diff: https://reviews.apache.org/r/71663/diff/1/ > > > Testing > --- > > cmake --build . (Windows) > > > Thanks, > > Joseph Wu > >
Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71663/ --- Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff. Bugs: MESOS-10009 https://issues.apache.org/jira/browse/MESOS-10009 Repository: mesos Description --- Depending on the version of OpenSSL and what headers of OpenSSL are included, the order of certain Windows headers may be included in the "wrong" order. This results in hundreds of cryptic syntax errors from MSVC. This sweeps through the existing sites with OpenSSL headers and makes sure to include the Windows headers above them. Diffs - 3rdparty/libprocess/include/process/jwt.hpp 62bf5c2ac3fcb6b76c88cd691d001358a4cb0aa6 3rdparty/libprocess/include/process/ssl/gtest.hpp 4a14a8ef7937e8c6adf3a78db3e9558333700a1b 3rdparty/libprocess/include/process/ssl/tls_config.hpp 18c51a8baabf07143c7892dbee0ad2d856457d8d 3rdparty/libprocess/src/openssl.cpp bd05866950e1043d9585a7c5fdc7b2147a233fd3 3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 Diff: https://reviews.apache.org/r/71663/diff/1/ Testing --- cmake --build . (Windows) Thanks, Joseph Wu
