Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/#review219386 --- Bad review! Reviews applied: [71782, 71781, 71780] Error: 2020-01-27 15:53:32 URL:https://reviews.apache.org/r/71780/diff/raw/ [1116/1116] -> "71780.patch" [1] error: patch failed: src/master/http.cpp:437 error: src/master/http.cpp: patch does not apply - Mesos Reviewbot On Nov. 21, 2019, 9:42 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71782/ > --- > > (Updated Nov. 21, 2019, 9:42 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Moved check on subscriber presences into subscribers.send. > > > Diffs > - > > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71782/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/#review218750 --- Patch looks great! Reviews applied: [71780, 71781, 71782] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 21, 2019, 9:42 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71782/ > --- > > (Updated Nov. 21, 2019, 9:42 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Moved check on subscriber presences into subscribers.send. > > > Diffs > - > > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71782/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/#review218745 --- Ship it! Ship It! - Benjamin Mahler On Nov. 21, 2019, 9:42 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71782/ > --- > > (Updated Nov. 21, 2019, 9:42 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Moved check on subscriber presences into subscribers.send. > > > Diffs > - > > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71782/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Review Request 71782: Moved check on subscriber presences into subscribers.send.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository: mesos Description --- Moved check on subscriber presences into subscribers.send. Diffs - src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 Diff: https://reviews.apache.org/r/71782/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier
