Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-22 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/#review218758
---


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 20, 2019, 3:49 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71787/
> ---
> 
> (Updated Nov. 20, 2019, 3:49 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test that verifies that the reservation for a
> persistent disk volume can be updated after it has been
> created.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 
> 
> 
> Diff: https://reviews.apache.org/r/71787/diff/3/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-21 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/#review218740
---



Patch looks great!

Reviews applied: [71785, 71787]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 20, 2019, 3:49 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71787/
> ---
> 
> (Updated Nov. 20, 2019, 3:49 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test that verifies that the reservation for a
> persistent disk volume can be updated after it has been
> created.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 
> 
> 
> Diff: https://reviews.apache.org/r/71787/diff/3/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-20 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/
---

(Updated Nov. 20, 2019, 2:49 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Address style comments.


Bugs: MESOS-9992
https://issues.apache.org/jira/browse/MESOS-9992


Repository: mesos


Description
---

Added a new test that verifies that the reservation for a
persistent disk volume can be updated after it has been
created.


Diffs (updated)
-

  src/tests/persistent_volume_endpoints_tests.cpp 
bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 


Diff: https://reviews.apache.org/r/71787/diff/3/

Changes: https://reviews.apache.org/r/71787/diff/2-3/


Testing
---

`./src/mesos-tests --gtest_filter="*ReservationUpdate*"`


Thanks,

Benno Evers

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-20 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/#review218720
---




src/tests/persistent_volume_endpoints_tests.cpp
Lines 347 (patched)


We are overloading this test, but could call out here that we also test 
that a persistent volume should not end up unreserved.



src/tests/persistent_volume_endpoints_tests.cpp
Lines 399 (patched)


Let's add a comment here that we are now re-reserving a persistent volume 
from `foo` to `bar`.



src/tests/persistent_volume_endpoints_tests.cpp
Lines 433 (patched)


nit: we could get rid of this empty line



src/tests/persistent_volume_endpoints_tests.cpp
Lines 456-457 (patched)


Let's get rid of one of these.


- Benjamin Bannier


On Nov. 20, 2019, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71787/
> ---
> 
> (Updated Nov. 20, 2019, 2:07 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test that verifies that the reservation for a
> persistent disk volume can be updated after it has been
> created.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 
> 
> 
> Diff: https://reviews.apache.org/r/71787/diff/2/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-20 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/
---

(Updated Nov. 20, 2019, 1:07 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Added a new check to verify persistent disks cannot be unreserved with a 
reservation update.


Bugs: MESOS-9992
https://issues.apache.org/jira/browse/MESOS-9992


Repository: mesos


Description
---

Added a new test that verifies that the reservation for a
persistent disk volume can be updated after it has been
created.


Diffs (updated)
-

  src/tests/persistent_volume_endpoints_tests.cpp 
bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 


Diff: https://reviews.apache.org/r/71787/diff/2/

Changes: https://reviews.apache.org/r/71787/diff/1-2/


Testing
---

`./src/mesos-tests --gtest_filter="*ReservationUpdate*"`


Thanks,

Benno Evers

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-19 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/#review218708
---



Patch looks great!

Reviews applied: [71785, 71787]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 19, 2019, 8:53 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71787/
> ---
> 
> (Updated Nov. 19, 2019, 8:53 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test that verifies that the reservation for a
> persistent disk volume can be updated after it has been
> created.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 
> 
> 
> Diff: https://reviews.apache.org/r/71787/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-19 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-9992
https://issues.apache.org/jira/browse/MESOS-9992


Repository: mesos


Description
---

Added a new test that verifies that the reservation for a
persistent disk volume can be updated after it has been
created.


Diffs
-

  src/tests/persistent_volume_endpoints_tests.cpp 
bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 


Diff: https://reviews.apache.org/r/71787/diff/1/


Testing
---

`./src/mesos-tests --gtest_filter="*ReservationUpdate*"`


Thanks,

Benno Evers