Re: Review Request 71815: WIP: Made default executor connect via domain sockets if available.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/#review218851 --- Patch looks great! Reviews applied: [71814, 71815] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 28, 2019, 4:44 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71815/ > --- > > (Updated Nov. 28, 2019, 4:44 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-10039 > https://issues.apache.org/jira/browse/MESOS-10039 > > > Repository: mesos > > > Description > --- > > Added support for the `MESOS_DOMAIN_SOCKET` environment variable > to the default executor. If this variable is present, the executor > will use the specified domain socket to connect to the agent, > as opposed to the IP address encoded in the agent PID. > > > Diffs > - > > src/executor/executor.cpp b4126037ed3e14a93d4acb9d02b62115ba4ef690 > src/launcher/default_executor.cpp 521494a2770192e39b5159624f057e01f2690c8a > src/tests/default_executor_tests.cpp > 49c4e3b37bde848dc7a4fd02a1458c650a84a16f > > > Diff: https://reviews.apache.org/r/71815/diff/2/ > > > Testing > --- > > Ran the new test. > > > Thanks, > > Benno Evers > >
Re: Review Request 71815: WIP: Made default executor connect via domain sockets if available.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/ --- (Updated Nov. 28, 2019, 4:44 p.m.) Review request for mesos and Benjamin Bannier. Changes --- Attempt to shorten path if necessary. Bugs: MESOS-10039 https://issues.apache.org/jira/browse/MESOS-10039 Repository: mesos Description --- Added support for the `MESOS_DOMAIN_SOCKET` environment variable to the default executor. If this variable is present, the executor will use the specified domain socket to connect to the agent, as opposed to the IP address encoded in the agent PID. Diffs (updated) - src/executor/executor.cpp b4126037ed3e14a93d4acb9d02b62115ba4ef690 src/launcher/default_executor.cpp 521494a2770192e39b5159624f057e01f2690c8a src/tests/default_executor_tests.cpp 49c4e3b37bde848dc7a4fd02a1458c650a84a16f Diff: https://reviews.apache.org/r/71815/diff/2/ Changes: https://reviews.apache.org/r/71815/diff/1-2/ Testing --- Ran the new test. Thanks, Benno Evers
Re: Review Request 71815: WIP: Made default executor connect via domain sockets if available.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/#review218790 --- Patch looks great! Reviews applied: [71814, 71815] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 25, 2019, 7:20 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71815/ > --- > > (Updated Nov. 25, 2019, 7:20 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-10039 > https://issues.apache.org/jira/browse/MESOS-10039 > > > Repository: mesos > > > Description > --- > > Added support for the `MESOS_DOMAIN_SOCKET` environment variable > to the default executor. If this variable is present, the executor > will use the specified domain socket to connect to the agent, > as opposed to the IP address encoded in the agent PID. > > > Diffs > - > > src/executor/executor.cpp b4126037ed3e14a93d4acb9d02b62115ba4ef690 > src/launcher/default_executor.cpp 521494a2770192e39b5159624f057e01f2690c8a > src/tests/default_executor_tests.cpp > 49c4e3b37bde848dc7a4fd02a1458c650a84a16f > > > Diff: https://reviews.apache.org/r/71815/diff/1/ > > > Testing > --- > > Ran the new test. > > > Thanks, > > Benno Evers > >
Review Request 71815: WIP: Made default executor connect via domain sockets if available.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-10039 https://issues.apache.org/jira/browse/MESOS-10039 Repository: mesos Description --- Added support for the `MESOS_DOMAIN_SOCKET` environment variable to the default executor. If this variable is present, the executor will use the specified domain socket to connect to the agent, as opposed to the IP address encoded in the agent PID. Diffs - src/executor/executor.cpp b4126037ed3e14a93d4acb9d02b62115ba4ef690 src/launcher/default_executor.cpp 521494a2770192e39b5159624f057e01f2690c8a src/tests/default_executor_tests.cpp 49c4e3b37bde848dc7a4fd02a1458c650a84a16f Diff: https://reviews.apache.org/r/71815/diff/1/ Testing --- Ran the new test. Thanks, Benno Evers
