Re: Review Request 71833: WIP: Added code to create domain socket on agent startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review218854 --- Bad patch! Reviews applied: [71832, 71833] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_71833"] Error: .. _STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" -DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" -DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include -I../3rd party/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include -I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o slave/container_loggers/mesos_logrotate_logger-logrotate.o `test -f 'slave/container_loggers/logrotate.cpp' || echo '../../src/'`slave/container_loggers/logrotate.cpp g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" -DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" -DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/ mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include -I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o slave/containerizer/mesos/io/mesos_io_switchboard-switchboard_main.o `test -f 'slave/containerizer/mesos/io/switchboard_main.cpp' || echo '../../src/'`slave/contain erizer/mesos/io/switchboard_main.cpp g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1
Re: Review Request 71833: WIP: Added code to create domain socket on agent startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/ --- (Updated Nov. 28, 2019, 4:46 p.m.) Review request for mesos and Benjamin Bannier. Changes --- Also create domain socket in unit tests. Bugs: MESOS-10036 https://issues.apache.org/jira/browse/MESOS-10036 Repository: mesos Description --- Added agent code to check whether domain socket support is enabled, and if so creates or opens the socket at MESOS_DOMAIN_SOCKET_LOCATION. Diffs (updated) - src/local/local.cpp 8ff43618f06463b4ba86b64b25e5de692e406448 src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 src/tests/cluster.cpp f7bc882a644ec65710ada3d15507e1d4c5ba06f7 src/tests/mock_slave.cpp 71be957884ea88258ef37e60649e3947e89b12d0 Diff: https://reviews.apache.org/r/71833/diff/3/ Changes: https://reviews.apache.org/r/71833/diff/2-3/ Testing --- Thanks, Benno Evers
Re: Review Request 71833: WIP: Added code to create domain socket on agent startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review218826 --- Bad patch! Reviews applied: [71832, 71833] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_71833"] Error: + : ubuntu:14.04 + : autotools + : gcc + : --verbose --disable-libtool-wrappers --disable-parallel-test-execution + : GLOG_v=1 MESOS_VERBOSE=1 + : 6 +++ dirname ./support/docker-build.sh ++ cd ./support/.. ++ pwd + MESOS_DIRECTORY=/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot-Linux + cd /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot-Linux + DOCKERFILE=Dockerfile + rm -f Dockerfile + case $OS in + append_dockerfile 'FROM ubuntu:14.04' + echo FROM ubuntu:14.04 + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' + echo RUN rm -rf /var/lib/apt/lists/apt.datadoghq.com_dists_stable_6_binary-amd64_Packages /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release.gpg /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_InRelease /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_puppet_binary-all_Packages /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_puppet_binary-amd64_Packages /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_puppet_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_Contents-amd64.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_Contents-i386.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_InRelease /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_main_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_main_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dis ts_bionic-backports_main_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_universe_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_universe_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_universe_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_Contents-amd64.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_Contents-i386.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_InRelease /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_main_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_main_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_main_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_multiverse_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_multiverse_binary-i386_Packages /var /lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_multiverse_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_restricted_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_restricted_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_restricted_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_Contents-amd64.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_Contents-i386.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_InRelease /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_main_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_main_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_main_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_multiverse_binary-amd64_Packages /var/lib/apt/li sts/archive.ubuntu.com_ubuntu_dists_bionic-security_multiverse_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_multiverse_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_restricted_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_restricted_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_restricted_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_universe_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_universe_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_universe_i18n_Translation-en
Re: Review Request 71833: WIP: Added code to create domain socket on agent startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/ --- (Updated Nov. 27, 2019, 3:11 p.m.) Review request for mesos and Benjamin Bannier. Changes --- Fixup some more constructor calls to `Slave`. Bugs: MESOS-10036 https://issues.apache.org/jira/browse/MESOS-10036 Repository: mesos Description --- Added agent code to check whether domain socket support is enabled, and if so creates or opens the socket at MESOS_DOMAIN_SOCKET_LOCATION. Diffs (updated) - src/local/local.cpp 8ff43618f06463b4ba86b64b25e5de692e406448 src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 src/tests/cluster.cpp f7bc882a644ec65710ada3d15507e1d4c5ba06f7 src/tests/mock_slave.cpp 71be957884ea88258ef37e60649e3947e89b12d0 Diff: https://reviews.apache.org/r/71833/diff/2/ Changes: https://reviews.apache.org/r/71833/diff/1-2/ Testing --- Thanks, Benno Evers
Re: Review Request 71833: WIP: Added code to create domain socket on agent startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review218822 --- Bad patch! Reviews applied: [71832, 71833] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_71833"] Error: + : ubuntu:14.04 + : autotools + : gcc + : --verbose --disable-libtool-wrappers --disable-parallel-test-execution + : GLOG_v=1 MESOS_VERBOSE=1 + : 6 +++ dirname ./support/docker-build.sh ++ cd ./support/.. ++ pwd + MESOS_DIRECTORY=/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot-Linux + cd /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot-Linux + DOCKERFILE=Dockerfile + rm -f Dockerfile + case $OS in + append_dockerfile 'FROM ubuntu:14.04' + echo FROM ubuntu:14.04 + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' + echo RUN rm -rf /var/lib/apt/lists/apt.datadoghq.com_dists_stable_6_binary-amd64_Packages /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release.gpg /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_InRelease /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_puppet_binary-all_Packages /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_puppet_binary-amd64_Packages /var/lib/apt/lists/apt.puppetlabs.com_dists_bionic_puppet_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_Contents-amd64.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_Contents-i386.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_InRelease /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_main_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_main_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dis ts_bionic-backports_main_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_universe_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_universe_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-backports_universe_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_Contents-amd64.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_Contents-i386.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_InRelease /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_main_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_main_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_main_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_multiverse_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_multiverse_binary-i386_Packages /var /lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_multiverse_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_restricted_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_restricted_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic_restricted_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_Contents-amd64.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_Contents-i386.lz4 /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_InRelease /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_main_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_main_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_main_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_multiverse_binary-amd64_Packages /var/lib/apt/li sts/archive.ubuntu.com_ubuntu_dists_bionic-security_multiverse_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_multiverse_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_restricted_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_restricted_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_restricted_i18n_Translation-en /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_universe_binary-amd64_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_universe_binary-i386_Packages /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_bionic-security_universe_i18n_Translation-en
Review Request 71833: WIP: Added code to create domain socket on agent startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-10036 https://issues.apache.org/jira/browse/MESOS-10036 Repository: mesos Description --- Added agent code to check whether domain socket support is enabled, and if so creates or opens the socket at MESOS_DOMAIN_SOCKET_LOCATION. Diffs - src/local/local.cpp 8ff43618f06463b4ba86b64b25e5de692e406448 src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 Diff: https://reviews.apache.org/r/71833/diff/1/ Testing --- Thanks, Benno Evers
