Re: Review Request 71837: Dont reject the word 'WIP' in commit titles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71837/#review218829 --- Bad review! Reviews applied: [71837] Error: 2019-11-27 19:31:48 URL:https://reviews.apache.org/r/71837/diff/raw/ [732/732] -> "71837.patch" [1] error: patch failed: support/gitlint:15 error: support/gitlint: patch does not apply - Mesos Reviewbot On Nov. 27, 2019, 3:18 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71837/ > --- > > (Updated Nov. 27, 2019, 3:18 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Change gitlint rules to not reject the word 'WIP' in commit > titles anymore, since we want to encourage placing this marker > as visible as possible for WIP commits, to prevent accidental > merging of a commit that was not considered ready by the > author. > > > Diffs > - > > support/gitlint cac9253323f5a9a99876a0e3bd6dd4acbc19d9c1 > > > Diff: https://reviews.apache.org/r/71837/diff/1/ > > > Testing > --- > > Created a commit containing the word `WIP` in the title. > > > Thanks, > > Benno Evers > >
Re: Review Request 71837: Dont reject the word 'WIP' in commit titles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71837/#review218824 --- Ship it! LGTM. - Benjamin Bannier On Nov. 27, 2019, 4:18 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71837/ > --- > > (Updated Nov. 27, 2019, 4:18 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Change gitlint rules to not reject the word 'WIP' in commit > titles anymore, since we want to encourage placing this marker > as visible as possible for WIP commits, to prevent accidental > merging of a commit that was not considered ready by the > author. > > > Diffs > - > > support/gitlint cac9253323f5a9a99876a0e3bd6dd4acbc19d9c1 > > > Diff: https://reviews.apache.org/r/71837/diff/1/ > > > Testing > --- > > Created a commit containing the word `WIP` in the title. > > > Thanks, > > Benno Evers > >
Review Request 71837: Dont reject the word 'WIP' in commit titles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71837/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Change gitlint rules to not reject the word 'WIP' in commit titles anymore, since we want to encourage placing this marker as visible as possible for WIP commits, to prevent accidental merging of a commit that was not considered ready by the author. Diffs - support/gitlint cac9253323f5a9a99876a0e3bd6dd4acbc19d9c1 Diff: https://reviews.apache.org/r/71837/diff/1/ Testing --- Created a commit containing the word `WIP` in the title. Thanks, Benno Evers
