Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

2020-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71955/
---

(Updated March 16, 2020, 5:13 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description
---

Added a new parameter `resourceLimits` to the `createTask` methods.


Diffs (updated)
-

  src/tests/mesos.hpp 17fcaa3eff28e8139e6770629a5dfbb7c29289ec 


Diff: https://reviews.apache.org/r/71955/diff/3/

Changes: https://reviews.apache.org/r/71955/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

2020-03-11 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71955/#review219878
---




src/tests/mesos.hpp
Lines 105 (patched)


We always use fully-qualified names in headers; could you remove this 
`using` directive?


- Greg Mann


On March 10, 2020, 8:50 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71955/
> ---
> 
> (Updated March 10, 2020, 8:50 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new parameter `resourceLimits` to the `createTask` methods.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 17fcaa3eff28e8139e6770629a5dfbb7c29289ec 
> 
> 
> Diff: https://reviews.apache.org/r/71955/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

2020-03-10 Thread Qian Zhang 


> On March 5, 2020, 11:57 p.m., Greg Mann wrote:
> > Please change the commit message to past-tense.

Done, thanks for catching it!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71955/#review219801
---


On March 10, 2020, 4:50 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71955/
> ---
> 
> (Updated March 10, 2020, 4:50 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new parameter `resourceLimits` to the `createTask` methods.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 17fcaa3eff28e8139e6770629a5dfbb7c29289ec 
> 
> 
> Diff: https://reviews.apache.org/r/71955/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

2020-03-10 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71955/
---

(Updated March 10, 2020, 4:50 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Updated another overload of `createTask()` helper.


Summary (updated)
-

Added a new parameter `resourceLimits` to the `createTask` methods.


Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047


Repository: mesos


Description (updated)
---

Added a new parameter `resourceLimits` to the `createTask` methods.


Diffs (updated)
-

  src/tests/mesos.hpp 17fcaa3eff28e8139e6770629a5dfbb7c29289ec 


Diff: https://reviews.apache.org/r/71955/diff/2/

Changes: https://reviews.apache.org/r/71955/diff/1-2/


Testing
---


Thanks,

Qian Zhang