Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/
---

(Updated March 16, 2020, 9:52 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72027/diff/5/

Changes: https://reviews.apache.org/r/72027/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/
---

(Updated March 16, 2020, 5:17 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72027/diff/4/

Changes: https://reviews.apache.org/r/72027/diff/3-4/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-10 Thread Qian Zhang 


> On March 6, 2020, 8:44 p.m., Greg Mann wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4325 (patched)
> > 
> >
> > Agent is using all of the host memory right?

My bad, thanks for catching it!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/#review219821
---


On March 10, 2020, 4:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72027/
> ---
> 
> (Updated March 10, 2020, 4:54 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
> 
> 
> Diff: https://reviews.apache.org/r/72027/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-10 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/
---

(Updated March 10, 2020, 4:54 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72027/diff/3/

Changes: https://reviews.apache.org/r/72027/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

2020-03-06 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/
---

(Updated March 7, 2020, 10:34 a.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Updated the commit message.


Summary (updated)
-

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description (updated)
---

Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72027/diff/2/

Changes: https://reviews.apache.org/r/72027/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang