Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-17 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/#review219976
---


Ship it!




Ship It!

- Greg Mann


On March 17, 2020, 7:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72211/
> ---
> 
> (Updated March 17, 2020, 7:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
> 
> 
> Diff: https://reviews.apache.org/r/72211/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-17 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/
---

(Updated March 17, 2020, 3:01 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72211/diff/4/

Changes: https://reviews.apache.org/r/72211/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang 


> On March 16, 2020, 8:23 p.m., Greg Mann wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4624-4628 (patched)
> > 
> >
> > Are we sure this will hold for all systems? Can we just check that the 
> > task cgroup's limit is infinite?

See my comment here: https://reviews.apache.org/r/72210/#comment308193 . And 
what do you mean for `task cgroup's limit`? I do not think we support task 
group in Docker containerizer.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/#review219954
---


On March 16, 2020, 9:52 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72211/
> ---
> 
> (Updated March 16, 2020, 9:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
> 
> 
> Diff: https://reviews.apache.org/r/72211/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/
---

(Updated March 16, 2020, 9:52 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Minor change.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72211/diff/3/

Changes: https://reviews.apache.org/r/72211/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/#review219954
---




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4617 (patched)


s/cannot be set any limits/cannot have any limit set/



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4624-4628 (patched)


Are we sure this will hold for all systems? Can we just check that the task 
cgroup's limit is infinite?


- Greg Mann


On March 16, 2020, 9:22 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72211/
> ---
> 
> (Updated March 16, 2020, 9:22 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
> https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 689a7220a09f2a58dffdf0dc9fd9f0548600be0e 
> 
> 
> Diff: https://reviews.apache.org/r/72211/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/
---

(Updated March 16, 2020, 5:22 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72211/diff/2/

Changes: https://reviews.apache.org/r/72211/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-07 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10053
https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
---

Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
689a7220a09f2a58dffdf0dc9fd9f0548600be0e 


Diff: https://reviews.apache.org/r/72211/diff/1/


Testing
---


Thanks,

Qian Zhang