Re: Review Request 72263: Moved containerizer utils in CMakeLists.

2020-03-24 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72263/#review220072
---


Ship it!




Ship It!

- Greg Mann


On March 24, 2020, 8:40 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72263/
> ---
> 
> (Updated March 24, 2020, 8:40 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-10048
> https://issues.apache.org/jira/browse/MESOS-10048
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to ensure the function `calculateOOMScoreAdj()` can be resolved
> on Windows.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5133550561ace4c2a6dfbdae2e333c921eb531cb 
> 
> 
> Diff: https://reviews.apache.org/r/72263/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 72263: Moved containerizer utils in CMakeLists.

2020-03-24 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72263/#review220067
---



Patch looks great!

Reviews applied: [72263]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 24, 2020, 8:40 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72263/
> ---
> 
> (Updated March 24, 2020, 8:40 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-10048
> https://issues.apache.org/jira/browse/MESOS-10048
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to ensure the function `calculateOOMScoreAdj()` can be resolved
> on Windows.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5133550561ace4c2a6dfbdae2e333c921eb531cb 
> 
> 
> Diff: https://reviews.apache.org/r/72263/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 72263: Moved containerizer utils in CMakeLists.

2020-03-24 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72263/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-10048
https://issues.apache.org/jira/browse/MESOS-10048


Repository: mesos


Description
---

This is to ensure the function `calculateOOMScoreAdj()` can be resolved
on Windows.


Diffs
-

  src/CMakeLists.txt 5133550561ace4c2a6dfbdae2e333c921eb531cb 


Diff: https://reviews.apache.org/r/72263/diff/1/


Testing
---


Thanks,

Qian Zhang