Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-05-01 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220579
---



Patch looks great!

Reviews applied: [72398, 72399, 72401, 72391, 72402]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 30, 2020, 10:03 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 30, 2020, 10:03 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/7/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-05-01 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220577
---


Ship it!




Ship It!

- Greg Mann


On April 30, 2020, 2:03 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 30, 2020, 2:03 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/7/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-29 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220560
---



Bad review!

Reviews applied: [72402, 72449]

Error:
2020-04-30 02:05:26 URL:https://reviews.apache.org/r/72449/diff/raw/ 
[7278/7278] -> "72449.patch" [1]
error: patch failed: src/slave/containerizer/docker.cpp:1677
error: src/slave/containerizer/docker.cpp: patch does not apply

- Mesos Reviewbot


On April 30, 2020, 10:03 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 30, 2020, 10:03 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/7/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-29 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 30, 2020, 10:03 a.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
  src/tests/containerizer/docker_containerizer_tests.cpp 
b069f518d51225c39f0cd5126c02fa08674566ab 


Diff: https://reviews.apache.org/r/72402/diff/7/

Changes: https://reviews.apache.org/r/72402/diff/6-7/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-29 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220549
---



Patch looks great!

Reviews applied: [72398, 72399, 72401, 72449, 72402]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 29, 2020, 8:18 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 29, 2020, 8:18 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-29 Thread Qian Zhang 


> On April 29, 2020, 4:37 a.m., Greg Mann wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 2077-2099 (patched)
> > 
> >
> > What do you think about moving this logic into the conditionals below 
> > where `totalCPUs` and `totalMem` are used?

Agree!


> On April 29, 2020, 4:37 a.m., Greg Mann wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 2164-2167 (patched)
> > 
> >
> > Should we have an `#else` case here which does not check the value of 
> > `cgroups_enable_cfs`?

Hmm, I think we do not need that because we do not need to set CPU hard limit 
in usage in this case for the platforms other than Linux.


> On April 29, 2020, 4:37 a.m., Greg Mann wrote:
> > src/slave/containerizer/docker.cpp
> > Line 2095 (original), 2179-2181 (patched)
> > 
> >
> > Why don't we set the soft limit in this case?

Because we do not enforce soft limit in this case, see 
https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L715:L717 .


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220530
---


On April 29, 2020, 8:18 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 29, 2020, 8:18 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/6/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-29 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 29, 2020, 8:18 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Addressed review comments.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
  src/tests/containerizer/docker_containerizer_tests.cpp 
b069f518d51225c39f0cd5126c02fa08674566ab 


Diff: https://reviews.apache.org/r/72402/diff/6/

Changes: https://reviews.apache.org/r/72402/diff/5-6/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-28 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220530
---




src/slave/containerizer/docker.cpp
Lines 2077-2099 (patched)


What do you think about moving this logic into the conditionals below where 
`totalCPUs` and `totalMem` are used?



src/slave/containerizer/docker.cpp
Lines 2164-2167 (patched)


Should we have an `#else` case here which does not check the value of 
`cgroups_enable_cfs`?



src/slave/containerizer/docker.cpp
Line 2095 (original), 2179-2181 (patched)


Why don't we set the soft limit in this case?


- Greg Mann


On April 25, 2020, 10:55 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 25, 2020, 10:55 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/5/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220494
---



Patch looks great!

Reviews applied: [72398, 72399, 72401, 72391, 72402]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 25, 2020, 10:55 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> ---
> 
> (Updated April 25, 2020, 10:55 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Docker containerizer's `usage()` to support resource limits.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> b069f518d51225c39f0cd5126c02fa08674566ab 
> 
> 
> Diff: https://reviews.apache.org/r/72402/diff/5/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 25, 2020, 6:55 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Set container's hard CPU limit to host total CPU numbers if the CPU limit 
specified by framework is infinity.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
  src/tests/containerizer/docker_containerizer_tests.cpp 
b069f518d51225c39f0cd5126c02fa08674566ab 


Diff: https://reviews.apache.org/r/72402/diff/5/

Changes: https://reviews.apache.org/r/72402/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220485
---



Bad patch!

Reviews applied: [72398, 72399, 72401, 72391, 72402]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72402"]

Error:
ubuntu-16.04: Pulling from mesos/mesos-build
18d680d61657: Pulling fs layer
0addb6fece63: Pulling fs layer
78e58219b215: Pulling fs layer
eb6959a66df2: Pulling fs layer
1105027a5560: Pulling fs layer
c36946130a38: Pulling fs layer
6a6a5e68faab: Pulling fs layer
80e07249924c: Pulling fs layer
c4c63e2501db: Pulling fs layer
668b207c2829: Pulling fs layer
ed76dddad568: Pulling fs layer
eb6959a66df2: Waiting
1105027a5560: Waiting
6a6a5e68faab: Waiting
c36946130a38: Waiting
80e07249924c: Waiting
ed76dddad568: Waiting
c4c63e2501db: Waiting
0addb6fece63: Verifying Checksum
0addb6fece63: Download complete
78e58219b215: Verifying Checksum
78e58219b215: Download complete
eb6959a66df2: Verifying Checksum
eb6959a66df2: Download complete
c36946130a38: Verifying Checksum
c36946130a38: Download complete
18d680d61657: Download complete
6a6a5e68faab: Verifying Checksum
6a6a5e68faab: Download complete
80e07249924c: Verifying Checksum
80e07249924c: Download complete
668b207c2829: Verifying Checksum
668b207c2829: Download complete
c4c63e2501db: Verifying Checksum
c4c63e2501db: Download complete
ed76dddad568: Verifying Checksum
ed76dddad568: Download complete
18d680d61657: Pull complete
0addb6fece63: Pull complete
78e58219b215: Pull complete
eb6959a66df2: Pull complete
1105027a5560: Verifying Checksum
1105027a5560: Download complete
1105027a5560: Pull complete
c36946130a38: Pull complete
6a6a5e68faab: Pull complete
80e07249924c: Pull complete
c4c63e2501db: Pull complete
668b207c2829: Pull complete
ed76dddad568: Pull complete
Digest: sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Status: Downloaded newer image for mesos/mesos-build:ubuntu-16.04
docker.io/mesos/mesos-build:ubuntu-16.04
Cloning into '/tmp/SRC'...
Note: checking out '35458471c78c31299c0cbdcd6e82018ad93279dc'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b 

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: running: libtoolize --copy
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --warnings=all
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:50: installing './ar-lib'
configure.ac:34: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:46: installing './install-sh'
configure.ac:46: installing './missing'
3rdparty/Makefile.am:307: warning: source file '$(HTTP_PARSER)/http_parser.c' 
is in a subdir

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-24 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 24, 2020, 8:25 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Set container's hard memory limit to host total memory if the memory limit 
specified by framework is infinity.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
  src/tests/containerizer/docker_containerizer_tests.cpp 
b069f518d51225c39f0cd5126c02fa08674566ab 


Diff: https://reviews.apache.org/r/72402/diff/4/

Changes: https://reviews.apache.org/r/72402/diff/3-4/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-22 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220416
---



Bad patch!

Reviews applied: [72398, 72399, 72401, 72391, 72402]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72402"]

Error:
..
69-47db-805f-03f11a6c4547) for operation UUID 
6b51fd87-f41b-43b9-97e0-caeabd58ea91 on agent 
e8e24b72-c44c-4d6c-922c-b5791b26c835-S0
I0422 09:56:05.163906  3084 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.2:43435/slave(1243)/api/v1/resource_provider
I0422 09:56:05.164996  3086 process.cpp:3671] Handling HTTP event for process 
'slave(1243)' with path: '/slave(1243)/api/v1/resource_provider'
I0422 09:56:05.167958  3091 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.015319ms
I0422 09:56:05.168737  3088 master.cpp:9485] Sending offers [ 
e8e24b72-c44c-4d6c-922c-b5791b26c835-O3 ] to framework 
e8e24b72-c44c-4d6c-922c-b5791b26c835- (default) at 
scheduler-a718d6b5-9296-4da9-bfb2-7652accaf7aa@172.17.0.2:43435
I0422 09:56:05.169420  3088 sched.cpp:934] Scheduler::resourceOffers took 
91699ns
I0422 09:56:05.172495  3085 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0422 09:56:05.174480  3095 http.cpp:1436] HTTP POST for /master/api/v1 from 
172.17.0.2:59734
I0422 09:56:05.174779  3095 http.cpp:277] Processing call CREATE_VOLUMES
I0422 09:56:05.175732  3095 master.cpp:3705] Authorizing principal 
'test-principal' to perform action CREATE_VOLUME on object 
{"value":"storage/default-role","resource":{"provider_id":{"value":"526fa287-44a4-4553-b81b-ac6a54daba0f"},"name":"disk","type":"SCALAR","scalar":{"value":2048.0},"reservations":[{"type":"DYNAMIC","role":"storage"},{"type":"DYNAMIC","role":"storage/default-role","principal":"test-principal"}],"disk":{"persistence":{"id":"aeb87db2-6550-468f-ae78-7641df27b2b7","principal":"test-principal"},"volume":{"mode":"RW","container_path":"volume"},"source":{"type":"MOUNT","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"vendor":"org.apache.mesos.csi.test.local","id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_4Lsosc/2GB-42a3bc6d-8581-45b5-9fcb-8ec7afce2c09","profile":"test"
I0422 09:56:05.177361  3091 sched.cpp:960] Rescinded offer 
e8e24b72-c44c-4d6c-922c-b5791b26c835-O3
I0422 09:56:05.177450  3091 sched.cpp:971] Scheduler::offerRescinded took 
25418ns
I0422 09:56:05.177851  3097 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_4Lsosc/2GB-42a3bc6d-8581-45b5-9fcb-8ec7afce2c09,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_4Lsosc/2GB-42a3bc6d-8581-45b5-9fcb-8ec7afce2c09,test)]:2048,
 offered or allocated: {}) on agent e8e24b72-c44c-4d6c-922c-b5791b26c835-S0 
from framework e8e24
 b72-c44c-4d6c-922c-b5791b26c835-
I0422 09:56:05.177999  3087 master.cpp:11784] Removing offer 
e8e24b72-c44c-4d6c-922c-b5791b26c835-O3
I0422 09:56:05.179555  3097 hierarchical.cpp:1625] Framework 
e8e24b72-c44c-4d6c-922c-b5791b26c835- filtered agent 
e8e24b72-c44c-4d6c-922c-b5791b26c835-S0 for 5secs
I0422 09:56:05.182458  3090 master.cpp:11649] Sending operation '' (uuid: 
2b2a4f85-d2dd-4bc5-84e5-736437c172dc) to agent 
e8e24b72-c44c-4d6c-922c-b5791b26c835-S0 at slave(1243)@172.17.0.2:43435 
(82e6e8f010ed)
I0422 09:56:05.183130  3090 slave.cpp:4545] Ignoring new checkpointed resources 
and operations identical to the current version
I0422 09:56:05.186406  3093 provider.cpp:498] Received APPLY_OPERATION event
I0422 09:56:05.186453  3093 provider.cpp:1351] Received CREATE operation '' 
(uuid: 2b2a4f85-d2dd-4bc5-84e5-736437c172dc)
I0422 09:56:05.190909  3082 master.cpp:5533] Processing REVIVE call for 
framework e8e24b72-c44c-4d6c-922c-b5791b26c835- (default) at 
scheduler-a718d6b5-9296-4da9-bfb2-7652accaf7aa@172.17.0.2:43435
I0422 09:56:05.191416  3089 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-22 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 22, 2020, 4:13 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Updated the test `ROOT_DOCKER_Usage`.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
  src/tests/containerizer/docker_containerizer_tests.cpp 
b069f518d51225c39f0cd5126c02fa08674566ab 


Diff: https://reviews.apache.org/r/72402/diff/3/

Changes: https://reviews.apache.org/r/72402/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-21 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

(Updated April 22, 2020, 8:13 a.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
---

Fix a build error on MacOS


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 


Diff: https://reviews.apache.org/r/72402/diff/2/

Changes: https://reviews.apache.org/r/72402/diff/1-2/


Testing (updated)
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-21 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220400
---



Bad patch!

Reviews applied: [72398, 72399, 72400, 72401, 72391, 72402]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72402"]

Error:
..
c9-4737-a6e3-ca2edfd73017) for operation UUID 
cdf52570-bae5-483f-873e-8ebab662316c on agent 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0
I0421 15:16:50.142735  3116 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.2:39421/slave(1243)/api/v1/resource_provider
I0421 15:16:50.144177  3102 process.cpp:3671] Handling HTTP event for process 
'slave(1243)' with path: '/slave(1243)/api/v1/resource_provider'
I0421 15:16:50.147536  3110 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.154475ms
I0421 15:16:50.148366  3117 master.cpp:9485] Sending offers [ 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-O3 ] to framework 
bffc3f66-e431-4b06-9b3b-83e48ec55a41- (default) at 
scheduler-0d3636d3-5c9a-47b4-a491-52b46efa95bf@172.17.0.2:39421
I0421 15:16:50.149140  3117 sched.cpp:934] Scheduler::resourceOffers took 
106047ns
I0421 15:16:50.152581  3113 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0421 15:16:50.154829  3112 http.cpp:1436] HTTP POST for /master/api/v1 from 
172.17.0.2:57852
I0421 15:16:50.155150  3112 http.cpp:277] Processing call CREATE_VOLUMES
I0421 15:16:50.156154  3112 master.cpp:3705] Authorizing principal 
'test-principal' to perform action CREATE_VOLUME on object 
{"value":"storage/default-role","resource":{"provider_id":{"value":"dd6f554f-b06c-4174-8993-2f76c8863f42"},"name":"disk","type":"SCALAR","scalar":{"value":2048.0},"reservations":[{"type":"DYNAMIC","role":"storage"},{"type":"DYNAMIC","role":"storage/default-role","principal":"test-principal"}],"disk":{"persistence":{"id":"f3b30858-2e92-430b-866c-4c8594aa10de","principal":"test-principal"},"volume":{"mode":"RW","container_path":"volume"},"source":{"type":"MOUNT","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"vendor":"org.apache.mesos.csi.test.local","id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_D44Aci/2GB-0e2de956-5828-44c9-9ed3-004584b16548","profile":"test"
I0421 15:16:50.157893  3117 sched.cpp:960] Rescinded offer 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-O3
I0421 15:16:50.157977  3117 sched.cpp:971] Scheduler::offerRescinded took 
26745ns
I0421 15:16:50.158427  3103 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_D44Aci/2GB-0e2de956-5828-44c9-9ed3-004584b16548,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_D44Aci/2GB-0e2de956-5828-44c9-9ed3-004584b16548,test)]:2048,
 offered or allocated: {}) on agent bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0 
from framework bffc3
 f66-e431-4b06-9b3b-83e48ec55a41-
I0421 15:16:50.158565  3110 master.cpp:11784] Removing offer 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-O3
I0421 15:16:50.160090  3103 hierarchical.cpp:1625] Framework 
bffc3f66-e431-4b06-9b3b-83e48ec55a41- filtered agent 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0 for 5secs
I0421 15:16:50.162694  3113 master.cpp:11649] Sending operation '' (uuid: 
b8903c93-0234-498f-87c1-4448d77832d0) to agent 
bffc3f66-e431-4b06-9b3b-83e48ec55a41-S0 at slave(1243)@172.17.0.2:39421 
(76b885a4b2f3)
I0421 15:16:50.163290  3113 slave.cpp:4545] Ignoring new checkpointed resources 
and operations identical to the current version
I0421 15:16:50.166703  3105 provider.cpp:498] Received APPLY_OPERATION event
I0421 15:16:50.166751  3105 provider.cpp:1351] Received CREATE operation '' 
(uuid: b8903c93-0234-498f-87c1-4448d77832d0)
I0421 15:16:50.170713  3116 master.cpp:5533] Processing REVIVE call for 
framework bffc3f66-e431-4b06-9b3b-83e48ec55a41- (default) at 
scheduler-0d3636d3-5c9a-47b4-a491-52b46efa95bf@172.17.0.2:39421
I0421 15:16:50.171152  3116 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-r

Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

2020-04-21 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10117
https://issues.apache.org/jira/browse/MESOS-10117


Repository: mesos


Description
---

Updated Docker containerizer's `usage()` to support resource limits.


Diffs
-

  src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 


Diff: https://reviews.apache.org/r/72402/diff/1/


Testing
---


Thanks,

Qian Zhang