[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for simplifyi...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10716#discussion_r49424418
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -608,7 +609,16 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case Not(a And b) => Or(Not(a), Not(b))
case Not(Not(e)) => e
+}
+ }
+}
+/**
+ * Simplifies conditional expressions (if / case).
+ */
+object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper
{
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+case q: LogicalPlan => q transformExpressionsUp {
case If(TrueLiteral, trueValue, _) => trueValue
case If(FalseLiteral, _, falseValue) => falseValue
--- End diff --
This patch doesn't change the rule. That should be done in
https://issues.apache.org/jira/browse/SPARK-12770
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for simplifyi...
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/10716#discussion_r49424324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -608,7 +609,16 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case Not(a And b) => Or(Not(a), Not(b))
case Not(Not(e)) => e
+}
+ }
+}
+/**
+ * Simplifies conditional expressions (if / case).
+ */
+object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper
{
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+case q: LogicalPlan => q transformExpressionsUp {
case If(TrueLiteral, trueValue, _) => trueValue
case If(FalseLiteral, _, falseValue) => falseValue
--- End diff --
Also add the null testing? `e @ If(Literal(null, _), _, _) => Literal(null,
e.dataType)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-170832063 Oh, ok, thank you @gatorsmile :), will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10620][WIP] Migrate TaskMetrics to accu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10717#issuecomment-170832360 **[Test build #49225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49225/consoleFull)** for PR 10717 at commit [`4d681fa`](https://github.com/apache/spark/commit/4d681fa04f2c4d8ea5d22b03a15724e7394cbc0e). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10620][WIP] Migrate TaskMetrics to accu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10717#issuecomment-170832397 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10620][WIP] Migrate TaskMetrics to accu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10717#issuecomment-170832399 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49225/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/10722 [SPARK-12768][SQL] Remove CaseKeyWhen expression This patch removes CaseKeyWhen expression and replaces it with a factory method that generates the equivalent CaseWhen. This reduces the amount of code we'd need to maintain in the future for both code generation and optimizer. Note that we introduced CaseKeyWhen to avoid duplicate evaluations of the key. This is no longer a problem because we now have common subexpression elimination. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark SPARK-12768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/10722.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10722 commit 98a3b038dcd8de00502e7192e0bb6ebe13c4b338 Author: Reynold Xin Date: 2016-01-12T03:03:32Z [SPARK-12762][SQL] Add unit test for simplifying if expression. commit 7ba85c21e207b3ff0bfc8356a888f2e395a1f139 Author: Reynold Xin Date: 2016-01-12T03:04:54Z Unit test. commit e7c8475c26dad87d5785f0b0c0b5b8415fdf5e40 Author: Reynold Xin Date: 2016-01-12T05:06:48Z Fix import style. commit 5c03a76a0267fb2f63954aa53898a73ea2af8f53 Author: Reynold Xin Date: 2016-01-12T06:59:57Z Fix CombiningLimitsSuite commit d8a08edb669c17c99a8212fecc7d30ae6b42a172 Author: Reynold Xin Date: 2016-01-12T07:44:37Z Revert logDebug commit 6be7b956835010248d48f551d469a176f5a946e1 Author: Reynold Xin Date: 2016-01-12T08:08:20Z [SPARK-12768][SQL] Remove CaseKeyWhen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170833510 This is based on https://github.com/apache/spark/pull/10716 I will rebase once that is merged. To see the actual diff, see https://github.com/rxin/spark/commit/6be7b956835010248d48f551d469a176f5a946e1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-170833528 **[Test build #49227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49227/consoleFull)** for PR 10563 at commit [`94a095e`](https://github.com/apache/spark/commit/94a095edeb6852e90b5d8db64951dbf9cc4fde4c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9844][CORE] File appender race conditio...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10714#issuecomment-170835179 **[Test build #49219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49219/consoleFull)** for PR 10714 at commit [`20d8e7b`](https://github.com/apache/spark/commit/20d8e7b564bbc7bd5f0f3d0d1b17391b1a367d29). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9844][CORE] File appender race conditio...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10714#issuecomment-170835328 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9844][CORE] File appender race conditio...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10714#issuecomment-170835329 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49219/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170836251 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49228/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170836249 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-170836770 **[Test build #49227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49227/consoleFull)** for PR 10563 at commit [`94a095e`](https://github.com/apache/spark/commit/94a095edeb6852e90b5d8db64951dbf9cc4fde4c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-170836811 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49227/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-170836809 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170837582 **[Test build #49229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49229/consoleFull)** for PR 10722 at commit [`3c3fd93`](https://github.com/apache/spark/commit/3c3fd93575e84eed1d103b95fbbd2ac8bb8d1ccc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170837632 **[Test build #2368 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2368/consoleFull)** for PR 10722 at commit [`3c3fd93`](https://github.com/apache/spark/commit/3c3fd93575e84eed1d103b95fbbd2ac8bb8d1ccc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-170839874 **[Test build #49231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49231/consoleFull)** for PR 8880 at commit [`6b9abc5`](https://github.com/apache/spark/commit/6b9abc51a98982938cac4d82b93ffa00e27edd56). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][SQL] Scala style: Fix the...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10718#issuecomment-170840718 **[Test build #49218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49218/consoleFull)** for PR 10718 at commit [`5ddba9d`](https://github.com/apache/spark/commit/5ddba9dc040f6f9284cb3a230a7c6c7e35c76cce). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170841017 **[Test build #49230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49230/consoleFull)** for PR 10719 at commit [`5d4b1a9`](https://github.com/apache/spark/commit/5d4b1a9b29764654d86ce8e917c02b69ce973c75). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12543] [SQL] [WIP] Subquery in expressi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-170841052 **[Test build #49232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49232/consoleFull)** for PR 10706 at commit [`2d88bb3`](https://github.com/apache/spark/commit/2d88bb30860b965af0fc3224c293808ef4580a8e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][SQL] Scala style: Fix the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10718#issuecomment-170841007 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49218/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][SQL] Scala style: Fix the...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10718#issuecomment-170841004 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12543] [SQL] [WIP] Subquery in expressi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-170841342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49232/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12543] [SQL] [WIP] Subquery in expressi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-170841334 **[Test build #49232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49232/consoleFull)** for PR 10706 at commit [`2d88bb3`](https://github.com/apache/spark/commit/2d88bb30860b965af0fc3224c293808ef4580a8e). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12543] [SQL] [WIP] Subquery in expressi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-170841341 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170841485 **[Test build #49220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49220/consoleFull)** for PR 10695 at commit [`3a9acaa`](https://github.com/apache/spark/commit/3a9acaac9ba51bf5d6ec35269889522930674041). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][SQL] Scala style: Fix the...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10718#issuecomment-170841433 I'm going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170841647 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49220/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170841646 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][SQL] Scala style: Fix the...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10719#discussion_r49427925
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -36,7 +36,7 @@ import org.apache.spark.util.Utils
trait Logging {
// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
- @transient private var log_ : Logger = null
+ @transient private var _log: Logger = null
--- End diff --
Why don't we reset this change and just turn the rule off here-- otherwise
the huge mima exclusion is pretty annoying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10719#discussion_r49428147
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -36,7 +36,7 @@ import org.apache.spark.util.Utils
trait Logging {
// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
- @transient private var log_ : Logger = null
+ @transient private var _log: Logger = null
--- End diff --
It's reasonable. I'll do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10719#discussion_r49428301
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -36,7 +36,7 @@ import org.apache.spark.util.Utils
trait Logging {
// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
- @transient private var log_ : Logger = null
+ @transient private var _log: Logger = null
--- End diff --
So should we reset the change in flume/sink/Logging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170843520 **[Test build #49233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49233/consoleFull)** for PR 10695 at commit [`e9ec20f`](https://github.com/apache/spark/commit/e9ec20f1911cb9dfc26fb2d34dc7d460f17f20d5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10719#discussion_r49428523
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -36,7 +36,7 @@ import org.apache.spark.util.Utils
trait Logging {
// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
- @transient private var log_ : Logger = null
+ @transient private var _log: Logger = null
--- End diff --
It is less big of a deal there since it is already done and it is small.
But feel free to do whatever you deem fit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10719#discussion_r49428834
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -36,7 +36,7 @@ import org.apache.spark.util.Utils
trait Logging {
// Make the log field transient so that objects with Logging can
// be serialized and used on another machine
- @transient private var log_ : Logger = null
+ @transient private var _log: Logger = null
--- End diff --
O.K, it's less big deal. I'll only reset for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for SimplifyC...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10716#issuecomment-170846282 **[Test build #49222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49222/consoleFull)** for PR 10716 at commit [`5c03a76`](https://github.com/apache/spark/commit/5c03a76a0267fb2f63954aa53898a73ea2af8f53). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for SimplifyC...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10716#issuecomment-170846799 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for SimplifyC...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10716#issuecomment-170846802 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49222/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170846697 **[Test build #49234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49234/consoleFull)** for PR 10719 at commit [`e953d13`](https://github.com/apache/spark/commit/e953d1388238ca279a72d514cea6e6187aead4e2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170847516 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170851051 **[Test build #49234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49234/consoleFull)** for PR 10719 at commit [`e953d13`](https://github.com/apache/spark/commit/e953d1388238ca279a72d514cea6e6187aead4e2). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for SimplifyC...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10716#issuecomment-170850925 **[Test build #49226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49226/consoleFull)** for PR 10716 at commit [`d8a08ed`](https://github.com/apache/spark/commit/d8a08edb669c17c99a8212fecc7d30ae6b42a172). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170851127 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170851131 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49234/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for SimplifyC...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10716#issuecomment-170851389 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49226/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12762][SQL] Add unit test for SimplifyC...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10716#issuecomment-170851388 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12685] [MLlib] [Backport to 1.4]word2ve...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10721#issuecomment-170852868 [Test build #49223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49223/consoleFull) for PR 10721 at commit [`27ba586`](https://github.com/apache/spark/commit/27ba58609805c1b51082305eba4c1970de72c498). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12685] [MLlib] [Backport to 1.4]word2ve...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10721#issuecomment-170853097 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12685] [MLlib] [Backport to 1.4]word2ve...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10721#issuecomment-170853102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49223/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-170854032 @ygcao sorry for the delay, I was on vacation and not checking email regularly. I'm pretty much happy with this, but I'd like to just get one of @srowen @jkbradley @mengxr to give it a final review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7615] [MLLIB] MLLIB Word2Vec wordVector...
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/10696#issuecomment-170854343 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170855008 The additional mima exclusions are few so I'll add them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-170858673 **[Test build #49235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49235/consoleFull)** for PR 7753 at commit [`5e031ce`](https://github.com/apache/spark/commit/5e031ce3cc90a6b77133488b8070288dff11ce95). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-170860861 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170860916 **[Test build #2368 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2368/consoleFull)** for PR 10722 at commit [`3c3fd93`](https://github.com/apache/spark/commit/3c3fd93575e84eed1d103b95fbbd2ac8bb8d1ccc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-170860844 **[Test build #49235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49235/consoleFull)** for PR 7753 at commit [`5e031ce`](https://github.com/apache/spark/commit/5e031ce3cc90a6b77133488b8070288dff11ce95). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-170860864 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49235/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/10723 [SPARK-12689][SQL] Migrate DDL parsing to the newly absorbed parser: describe command JIRA: https://issues.apache.org/jira/browse/SPARK-12689 DDLParser processes three commands: createTable, describeTable and refreshTable. This patch migrates describe command. Other commands will be migrated in other PRs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/viirya/spark-1 migrate-ddl-describe Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/10723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10723 commit f886f67587a7e756c8518e5f18e94708c33e51df Author: Liang-Chi Hsieh Date: 2016-01-12T10:05:30Z Migrate DDL parsing to the newly absorbed parser: describe command. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7874][MESOS] Don’t allocate more than...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/9027#issuecomment-170863194 The discussions started on Nov. 19 2015, "Removing the Mesos fine-grained mode". but I only have it in my inbox. I'm sure there's some archive somewhere, but I don't have a link at hand. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170862882 **[Test build #49236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49236/consoleFull)** for PR 10719 at commit [`9079c27`](https://github.com/apache/spark/commit/9079c27fd7e7fd1f98fd50e49821effcd297054b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170864358 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49229/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-170864084 **[Test build #49237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49237/consoleFull)** for PR 10723 at commit [`f886f67`](https://github.com/apache/spark/commit/f886f67587a7e756c8518e5f18e94708c33e51df). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170864085 **[Test build #49229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49229/consoleFull)** for PR 10722 at commit [`3c3fd93`](https://github.com/apache/spark/commit/3c3fd93575e84eed1d103b95fbbd2ac8bb8d1ccc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12768][SQL] Remove CaseKeyWhen expressi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10722#issuecomment-170864356 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-170866829 **[Test build #49231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49231/consoleFull)** for PR 8880 at commit [`6b9abc5`](https://github.com/apache/spark/commit/6b9abc51a98982938cac4d82b93ffa00e27edd56). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-170867100 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49231/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-170867096 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r49436980
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -130,4 +130,49 @@ class MiscFunctionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
}
}
+
+ test("aesEncrypt") {
+checkEvaluation(Base64(AesEncrypt(Literal("ABC".getBytes),
+ Literal("1234567890123456".getBytes))), "y6Ss+zCYObpCbgfWfyNWTw==")
+checkEvaluation(Base64(AesEncrypt(Literal("".getBytes),
+ Literal("1234567890123456".getBytes))), "BQGHoM3lqYcsurCRq3PlUw==")
+
+// Before testing this, installing Java Cryptography Extension (JCE)
+// Unlimited Strength Jurisdiction Policy Files first
+//checkEvaluation(Base64(AesEncrypt(Literal("ABC".getBytes),
+// Literal("12345678901234561234567890123456".getBytes))),
"nYfCuJeRd5eD60yXDw7WEA==")
--- End diff --
Because Oracle JRE/JDK supports AES-128 out of the box. AES-192 and AES-256
are supported if Java Cryptography Extension (JCE) Unlimited Strength
Jurisdiction Policy Files are installed. In this test case, key size is 256
bits. We should install JCE not only with this test also any test with 192/256
bits key. I commented out this test by default in case this test fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-170870268 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-170870144 **[Test build #49237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49237/consoleFull)** for PR 10723 at commit [`f886f67`](https://github.com/apache/spark/commit/f886f67587a7e756c8518e5f18e94708c33e51df). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-170870270 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49237/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170871012 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170871013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49230/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170870805 **[Test build #49230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49230/consoleFull)** for PR 10719 at commit [`5d4b1a9`](https://github.com/apache/spark/commit/5d4b1a9b29764654d86ce8e917c02b69ce973c75). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12724] SQL generation support for persi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10712#issuecomment-170874935 **[Test build #49238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49238/consoleFull)** for PR 10712 at commit [`d53d540`](https://github.com/apache/spark/commit/d53d5400f1ac83b92b079f349fb1700e7c3cf4a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10713#issuecomment-170877285 @jasoncl I agree with this change, though I think this ends up returning RDDs that depend on other RDDs which you then unpersist before use. I agree with the comment on test style. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9844][CORE] File appender race conditio...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10714#discussion_r49440804
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala ---
@@ -58,20 +58,29 @@ private[spark] class FileAppender(inputStream:
InputStream, file: File, bufferSi
protected def appendStreamToFile() {
try {
logDebug("Started appending thread")
- openFile()
- val buf = new Array[Byte](bufferSize)
- var n = 0
- while (!markedForStop && n != -1) {
-n = inputStream.read(buf)
-if (n != -1) {
- appendToFile(buf, n)
+ Utils.tryWithSafeFinally {
+openFile()
+val buf = new Array[Byte](bufferSize)
+var n = 0
+while (!markedForStop && n != -1) {
+ try {
+n = inputStream.read(buf)
+ } catch {
+case e: IOException =>
--- End diff --
I don't think it's worth changing as this is fine, but I think you could
just write
```
case _: IOException if markedForStop => // do nothing because ...
```
... but maybe I'm missing something about how that works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12761] [CORE] Remove duplicated code
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10711#issuecomment-170878281 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170878704 **[Test build #2369 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2369/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10713#issuecomment-170878837 **[Test build #2373 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2373/consoleFull)** for PR 10713 at commit [`0f78c0e`](https://github.com/apache/spark/commit/0f78c0e22e99727f461e9c1c4e62f2d1cdf31ddb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-170878877 **[Test build #2371 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2371/consoleFull)** for PR 10520 at commit [`b1e2d13`](https://github.com/apache/spark/commit/b1e2d13b323d204a15be50b3afdb1d964120ee8a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-170878810 **[Test build #2372 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2372/consoleFull)** for PR 10152 at commit [`214d0d9`](https://github.com/apache/spark/commit/214d0d9d3350a624f98f36aff2393b7b61fd6176). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-170879414 **[Test build #2371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2371/consoleFull)** for PR 10520 at commit [`b1e2d13`](https://github.com/apache/spark/commit/b1e2d13b323d204a15be50b3afdb1d964120ee8a). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12765] [ML] [CountVectorizer]fix CountV...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10720#issuecomment-170878856 **[Test build #2370 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2370/consoleFull)** for PR 10720 at commit [`09a80a7`](https://github.com/apache/spark/commit/09a80a7d925927f2be3e702f1c5ccb695299dcf7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12685] [MLlib] [Backport to 1.4]word2ve...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10721#issuecomment-170879667 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12685] [MLlib] [Backport to 1.4]word2ve...
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/10721#issuecomment-170880217 Hi @srowen , Thanks for taking a look. I'm not sure if I should send separate PRs for release 1.5 and 1.6, can you please advice? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170881340 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49233/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170880890 **[Test build #49233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49233/consoleFull)** for PR 10695 at commit [`e9ec20f`](https://github.com/apache/spark/commit/e9ec20f1911cb9dfc26fb2d34dc7d460f17f20d5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12747][SQL] Use correct type name for P...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10695#issuecomment-170881336 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-12655] [GraphX] GraphX does not unpersi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10713#issuecomment-170882902 **[Test build #2373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2373/consoleFull)** for PR 10713 at commit [`0f78c0e`](https://github.com/apache/spark/commit/0f78c0e22e99727f461e9c1c4e62f2d1cdf31ddb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-170885940 **[Test build #2372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2372/consoleFull)** for PR 10152 at commit [`214d0d9`](https://github.com/apache/spark/commit/214d0d9d3350a624f98f36aff2393b7b61fd6176). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12765] [ML] [CountVectorizer]fix CountV...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10720#issuecomment-170889085 **[Test build #2370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2370/consoleFull)** for PR 10720 at commit [`09a80a7`](https://github.com/apache/spark/commit/09a80a7d925927f2be3e702f1c5ccb695299dcf7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170891449 **[Test build #49236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49236/consoleFull)** for PR 10719 at commit [`9079c27`](https://github.com/apache/spark/commit/9079c27fd7e7fd1f98fd50e49821effcd297054b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170891764 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49236/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12692][BUILD][CORE] Scala style: Fix th...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10719#issuecomment-170891763 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7615] [MLLIB] MLLIB Word2Vec wordVector...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10696#issuecomment-170894194 @sarutak @jkbradley can one of you try merging this? `git` keeps failing for me and I don't know why; trying to track down whether it's something local or not --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
