[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4590/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98210/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98210/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4589/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22852 I would be fine with adding it more places, including perhaps the overview page: http://spark.apache.org/docs/latest/ and quick start pages. Perhaps we should agree upon the wording here first though. I'm not exactly sure where this pr stands honestly. @srowen are you going to put up a different one with wording you prefer? > If someone lands on this page, do they pretty easily come away with the impression they need to set spark.authenticate and network security if they care about security? Everyone reads text slightly different and I'm by no means a doc expert, so I'm definitely open to reword if there is consensus on it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4588/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4588/ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hado...
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/21588 Can you clarify what you mean by drop builtin metastore support? Are you just saying users must always provide jars to use it or something more? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4588/ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98210/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98205/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98205/testReport)** for PR 22146 at commit [`5faea62`](https://github.com/apache/spark/commit/5faea6277c2581844786f4367f04b0355e3d9788). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98198/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4586/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4585/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98201/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98201/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22875 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22823 **[Test build #98208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98208/testReport)** for PR 22823 at commit [`0cfac24`](https://github.com/apache/spark/commit/0cfac246aba9e8336f943e38e2afd4aee067399c). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22823 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22823 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98208/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98199/testReport)** for PR 22844 at commit [`fbdbf83`](https://github.com/apache/spark/commit/fbdbf83c98a6ee61260ab1af30dfe7dae2890a25). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98199/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98198/testReport)** for PR 22845 at commit [`6d1f1f5`](https://github.com/apache/spark/commit/6d1f1f5b7246fcb1577354dd87f56f6c4dbaa738). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22877 **[Test build #98209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98209/testReport)** for PR 22877 at commit [`5995570`](https://github.com/apache/spark/commit/599557012cc9f4d4e5f36744180121cc8845413c). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98209/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22275 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4587/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4584/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98195/testReport)** for PR 22845 at commit [`004ed13`](https://github.com/apache/spark/commit/004ed139c59fee3c863b52cd6ec1eba539fe9135). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22830 **[Test build #98194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98194/testReport)** for PR 22830 at commit [`e9d9e0e`](https://github.com/apache/spark/commit/e9d9e0eb6a7caf0b3fda27bfb3d03fa419e4487e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22823 **[Test build #98208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98208/testReport)** for PR 22823 at commit [`0cfac24`](https://github.com/apache/spark/commit/0cfac246aba9e8336f943e38e2afd4aee067399c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98205/testReport)** for PR 22146 at commit [`5faea62`](https://github.com/apache/spark/commit/5faea6277c2581844786f4367f04b0355e3d9788). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98201/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22861 **[Test build #98207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98207/testReport)** for PR 22861 at commit [`59f167d`](https://github.com/apache/spark/commit/59f167dd1d22ecf6ce9868dd52614ef441416858). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98198/testReport)** for PR 22845 at commit [`6d1f1f5`](https://github.com/apache/spark/commit/6d1f1f5b7246fcb1577354dd87f56f6c4dbaa738). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22755 **[Test build #98206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98206/testReport)** for PR 22755 at commit [`50fb517`](https://github.com/apache/spark/commit/50fb517eb4eaa64c9f03bc3999f66aaaf14d6a8e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22873 **[Test build #98196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98196/testReport)** for PR 22873 at commit [`874c9c0`](https://github.com/apache/spark/commit/874c9c039fbfa2094790a4538e8fa603c8f3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98199/testReport)** for PR 22844 at commit [`fbdbf83`](https://github.com/apache/spark/commit/fbdbf83c98a6ee61260ab1af30dfe7dae2890a25). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22275 **[Test build #98202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98202/testReport)** for PR 22275 at commit [`d6fefee`](https://github.com/apache/spark/commit/d6fefee68c30aa579b345c32d9f00b32bf9a505b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22877 **[Test build #98209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98209/testReport)** for PR 22877 at commit [`5995570`](https://github.com/apache/spark/commit/599557012cc9f4d4e5f36744180121cc8845413c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22868: [SPARK-25833][SQL][DOCS] Update migration guide for Hive...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22868 **[Test build #98197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98197/testReport)** for PR 22868 at commit [`84d9e8c`](https://github.com/apache/spark/commit/84d9e8c20c12e5e3e3150de9a97f581858e3c9bd). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22309 **[Test build #98200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98200/testReport)** for PR 22309 at commit [`893b6fc`](https://github.com/apache/spark/commit/893b6fc54e10c4200b50a056b97a465316e20462). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22309 **[Test build #98203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98203/testReport)** for PR 22309 at commit [`c31f7e7`](https://github.com/apache/spark/commit/c31f7e766a4b8b6cab9710ed30dbf1cdfd1998bc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98204/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22877: [MINOR][SQL] Avoid hardcoded configuration keys i...
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/22877 [MINOR][SQL] Avoid hardcoded configuration keys in SQLConf's `doc` ## What changes were proposed in this pull request? This PR proposes to avoid hardcorded configuration keys in SQLConf's `doc. ## How was this patch tested? Manually verified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/spark minor-conf-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22877.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22877 commit 599557012cc9f4d4e5f36744180121cc8845413c Author: hyukjinkwon Date: 2018-10-29T12:42:54Z Avoid hardcoded configuration keys in SQLConf's `doc` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22876: [SPARK-25869] [YARN] the original diagnostics is missing...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22876 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22876: [SPARK-25869] [YARN] the original diagnostics is missing...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22876 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22876: [SPARK-25869] [YARN] the original diagnostics is missing...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22876 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22876: [SPARK-25869] [YARN] the original diagnostics is ...
GitHub user Cangyl opened a pull request: https://github.com/apache/spark/pull/22876 [SPARK-25869] [YARN] the original diagnostics is missing when job failed ma⦠When submit spark on yarn jobs, the diagnostics message may be missing when job failed maxAppAttempts times For more details, please check https://issues.apache.org/jira/browse/SPARK-25869 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Cangyl/spark SPARK-25869 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22876 commit afce7a0986ae04610eb2a9cfb9d8c50fe8de69c1 Author: ä»ä¸äº® 10202330 Date: 2018-10-29T11:59:49Z Spark on YARN: the original diagnostics is missing when job failed maxAppAttempts times --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22872: [SPARK-25864][SQL][TEST] Make main args accessibl...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22872 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22872 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98185/testReport)** for PR 22872 at commit [`2696321`](https://github.com/apache/spark/commit/269632148cac72c1e19a6d843a1ec647dfd10bf4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98185/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22617: [SPARK-25484][SQL][TEST] Refactor ExternalAppendO...
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22617#discussion_r228889856
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
---
@@ -68,9 +100,7 @@ object ExternalAppendOnlyUnsafeRowArrayBenchmark {
benchmark.addCase("ExternalAppendOnlyUnsafeRowArray") { _: Int =>
var sum = 0L
for (_ <- 0L until iterations) {
-val array = new ExternalAppendOnlyUnsafeRowArray(
-
ExternalAppendOnlyUnsafeRowArray.DefaultInitialSizeOfInMemoryBuffer,
- numSpillThreshold)
+val array = new
ExternalAppendOnlyUnsafeRowArray(numSpillThreshold, numSpillThreshold)
--- End diff --
Thanks for the feedback @dongjoon-hyun. I added some details to the
description.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98192/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user yucai commented on the issue: https://github.com/apache/spark/pull/22872 @HyukjinKwon @cloud-fan My previous tests have been passed :). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98192/testReport)** for PR 22844 at commit [`7d23c18`](https://github.com/apache/spark/commit/7d23c18f10e50f55f0f08116284c17cf572ed326). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98187/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98187/testReport)** for PR 22872 at commit [`2696321`](https://github.com/apache/spark/commit/269632148cac72c1e19a6d843a1ec647dfd10bf4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22870 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98191/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22870: [SPARK-25862][SQL] Remove rangeBetween APIs introduced i...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22870 **[Test build #98191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98191/testReport)** for PR 22870 at commit [`23d31bb`](https://github.com/apache/spark/commit/23d31bb7c55b228d748c8911e2c730db9b59552e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22872 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22530 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22530: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22530 retest this please -- --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22078#discussion_r228882841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -626,6 +626,14 @@ object SQLConf {
.stringConf
.createWithDefault("parquet")
+ val DATA_SOURCE_TABLE_INHERIT_PERMS =
buildConf("spark.sql.datasource.table.inherit.perms")
+.internal()
+.doc("Set this to true if the table directories should be inheriting
the permission " +
+ "of the warehouse or database directory " +
--- End diff --
Hive configuration doc itself doesn't looks quite clear to me as well
actually.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r228881996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -70,7 +76,6 @@ case class InsertIntoHadoopFsRelationCommand( val hadoopConf = sparkSession.sessionState.newHadoopConfWithOptions(options) val fs = outputPath.getFileSystem(hadoopConf) val qualifiedOutputPath = outputPath.makeQualified(fs.getUri, fs.getWorkingDirectory) - --- End diff -- I would remove unrelated newline changes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22078#discussion_r228881824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -261,4 +272,69 @@ case class InsertIntoHadoopFsRelationCommand(
}
}.toMap
}
+
+ private def isExtendedAclEnabled(hadoopConf: Configuration): Boolean =
+hadoopConf.getBoolean(DFS_NAMENODE_ACLS_ENABLED_KEY,
DFS_NAMENODE_ACLS_ENABLED_DEFAULT)
+
+ private def getFullFileStatus(
+ conf: SQLConf,
+ hadoopConf: Configuration,
+ pathExists: Boolean,
+ fs: FileSystem,
+ file: Path): (Option[FsPermission], Option[AclStatus]) = {
+var permission: Option[FsPermission] = None
+var aclStatus: Option[AclStatus] = None
+if (conf.isDataSouceTableInheritPerms && pathExists) {
+ permission = Some(fs.getFileStatus(file).getPermission)
+ if (isExtendedAclEnabled(hadoopConf)) aclStatus =
Some(fs.getAclStatus(file))
+}
+(permission, aclStatus)
--- End diff --
I would remove `var` by, for instance:
```scala
val shouldFetchPermission = conf.isDataSouceTableInheritPerms && pathExists
val shouldFetchAclStatus = shouldFetchPermission &&
isExtendedAclEnabled(hadoopConf)
val permission = if (shouldFetchPermission) {
Some(fs.getFileStatus(file).getPermission)
} else {
None
}
val aclStatus = if (shouldFetchAclStatus) {
Some(fs.getAclStatus(file))
} else {
None
}
(permission, aclStatus)
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22845 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98190/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98190/testReport)** for PR 22847 at commit [`b0ce2ca`](https://github.com/apache/spark/commit/b0ce2cae731620a0ce7417b2b46c24cffb023059). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...
Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228879109
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -180,11 +189,13 @@ object ScalaReflection extends ScalaReflection {
* @param tpe The `Type` of deserialized object.
* @param path The expression which can be used to extract serialized
value.
* @param walkedTypePath The paths from top to bottom to access current
field when deserializing.
+ * @param instantiateValueClass If `true`, create an instance for Scala
value class
--- End diff --
ok, I updated the comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98186/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22721 **[Test build #98186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98186/testReport)** for PR 22721 at commit [`6c8a73f`](https://github.com/apache/spark/commit/6c8a73f0fe74f618b429dee23869a00e706b125d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98193/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22275 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98193/testReport)** for PR 22844 at commit [`15c0893`](https://github.com/apache/spark/commit/15c08933866d7a14e28fad2afd58fb062814ce87). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228866822
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -180,11 +189,13 @@ object ScalaReflection extends ScalaReflection {
* @param tpe The `Type` of deserialized object.
* @param path The expression which can be used to extract serialized
value.
* @param walkedTypePath The paths from top to bottom to access current
field when deserializing.
+ * @param instantiateValueClass If `true`, create an instance for Scala
value class
--- End diff --
it will be good to explain when we need to instantiate value class and why
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22875: [SPARK-25867][ML] Remove KMeans computeCost
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22875 [SPARK-25867][ML] Remove KMeans computeCost ## What changes were proposed in this pull request? The PR removes the deprecated method `computeCost` of `KMeans`. ## How was this patch tested? NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgaido91/spark SPARK-25867 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22875.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22875 commit 9ee93b14a838fda3b61d36c39e5ee77c032c8fb8 Author: Marco Gaido Date: 2018-10-29T10:08:58Z [SPARK-25867][ML] Remove KMeans computeCost --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22868: [SPARK-25833][SQL][DOCS] Update migration guide for Hive...
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22868 @dongjoon-hyun Do you mean SPARK-25833? Since SPARK-24864 is resolved as Won't Fix, I updated type, priority and title of SPARK-25833. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
