[GitHub] [spark] dilipbiswal commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
dilipbiswal commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889982 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889800 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109991/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889796 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889800 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109991/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889255 **[Test build #109991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109991/testReport)** for PR 25532 at commit [`d0a3dbd`](https://github.com/apache/spark/commit/d0a3dbd718bdc59c8ed6bc3205f7d2d1bf8c6fec). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889796 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889776 **[Test build #109991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109991/testReport)** for PR 25532 at commit [`d0a3dbd`](https://github.com/apache/spark/commit/d0a3dbd718bdc59c8ed6bc3205f7d2d1bf8c6fec). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889255 **[Test build #109991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109991/testReport)** for PR 25532 at commit [`d0a3dbd`](https://github.com/apache/spark/commit/d0a3dbd718bdc59c8ed6bc3205f7d2d1bf8c6fec). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889166 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15010/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15010/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526889166 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on issue #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors
viirya commented on issue #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors URL: https://github.com/apache/spark/pull/25639#issuecomment-526888497 Thanks all. I will try to merge this tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
dilipbiswal commented on a change in pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#discussion_r319744058 ## File path: docs/sql-ref-syntax-aux-cache-cache-table.md ## @@ -19,4 +19,65 @@ license: | limitations under the License. --- -**This page is under construction** +### Description +`CACHE TABLE` statement caches the table's contents with the given storage level. This reduces scanning of the original files in future queries. Review comment: @huaxingao caches contents of a given table or output of a query ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
dilipbiswal commented on a change in pull request #25532:
[SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
URL: https://github.com/apache/spark/pull/25532#discussion_r319743998
##
File path: docs/sql-ref-syntax-aux-cache-cache-table.md
##
@@ -19,4 +19,65 @@ license: |
limitations under the License.
---
-**This page is under construction**
+### Description
+`CACHE TABLE` statement caches the table's contents with the given storage
level. This reduces scanning of the original files in future queries.
+
+### Syntax
+{% highlight sql %}
+CACHE [ LAZY ] TABLE table_name
+[ OPTIONS ( 'storageLevel' [ = ] value ) ] [ [ AS ] query ]
+{% endhighlight %}
+
+### Parameters
+
+ LAZY
+ Only cache the table when it is first used, instead of immediately.
+
+
+
+ table_name
+ The name of the table to be cached.
+
+
+
+ OPTIONS ( 'storageLevel' [ = ] value )
+
+ OPTIONS clause with storageLevel key and value
pair. If a key other than storageLevel is used, a WARN with
message "org.apache.spark.sql.execution.command.CacheTableCommand: Invalid
options: -> " will be issued. The valid options for
storageLevel are:
+
+ NONE
+ DISK_ONLY
+ DISK_ONLY_2
+ MEMORY_ONLY
+ MEMORY_ONLY_2
+ MEMORY_ONLY_SER
+ MEMORY_ONLY_SER_2
+ MEMORY_AND_DISK
+ MEMORY_AND_DISK_2
+ MEMORY_AND_DISK_SER
+ MEMORY_AND_DISK_SER_2
+ OFF_HEAP
+
+If invalid value is set for storageLevel,
"java.lang.IllegalArgumentException: Invalid StorageLevel: " will be
issued. If storageLevel is not explicitly set using
OPTIONS clause,the default storageLevel is set to
MEMORY_AND_DISK.
+
+
+
+
+ query
+ A query that produces the rows to be inserted. It can be in one of
following formats:
Review comment:
@huaxingao you meant "to be cached" ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
dilipbiswal commented on a change in pull request #25532:
[SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
URL: https://github.com/apache/spark/pull/25532#discussion_r319743984
##
File path: docs/sql-ref-syntax-aux-cache-cache-table.md
##
@@ -19,4 +19,65 @@ license: |
limitations under the License.
---
-**This page is under construction**
+### Description
+`CACHE TABLE` statement caches the table's contents with the given storage
level. This reduces scanning of the original files in future queries.
+
+### Syntax
+{% highlight sql %}
+CACHE [ LAZY ] TABLE table_name
+[ OPTIONS ( 'storageLevel' [ = ] value ) ] [ [ AS ] query ]
+{% endhighlight %}
+
+### Parameters
+
+ LAZY
+ Only cache the table when it is first used, instead of immediately.
+
+
+
+ table_name
+ The name of the table to be cached.
+
+
+
+ OPTIONS ( 'storageLevel' [ = ] value )
+
+ OPTIONS clause with storageLevel key and value
pair. If a key other than storageLevel is used, a WARN with
message "org.apache.spark.sql.execution.command.CacheTableCommand: Invalid
options: -> " will be issued. The valid options for
storageLevel are:
Review comment:
@huaxingao Do we need to detail the exact warning message ? We could say "An
warning is issued when event occurs" ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] asfgit closed pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API
asfgit closed pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] brkyvz commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API
brkyvz commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526885439 LGTM. Merging to master. Thanks @rdblue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] brkyvz commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog
brkyvz commented on a change in pull request #25363: [SPARK-28628][SQL]
Implement SupportsNamespaces in V2SessionCatalog
URL: https://github.com/apache/spark/pull/25363#discussion_r319743125
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala
##
@@ -753,3 +760,293 @@ class V2SessionCatalogSuite
assert(exc.message.contains("RENAME TABLE source and destination databases
do not match"))
}
}
+
+class V2SessionCatalogNamespaceSuite extends V2SessionCatalogBaseSuite {
+
+ import org.apache.spark.sql.catalog.v2.CatalogV2Implicits._
+
+ def checkMetadata(
+ expected: scala.collection.Map[String, String],
+ actual: scala.collection.Map[String, String]): Unit = {
+// remove location and comment that are automatically added by HMS unless
they are expected
+val toRemove =
V2SessionCatalog.RESERVED_PROPERTIES.filter(expected.contains)
+assert(expected -- toRemove === actual)
+ }
+
+ test("listNamespaces: basic behavior") {
+val catalog = newCatalog()
+catalog.createNamespace(testNs, Map("property" -> "value").asJava)
+
+assert(catalog.listNamespaces() === Array(testNs, defaultNs))
+assert(catalog.listNamespaces(Array()) === Array(testNs, defaultNs))
+assert(catalog.listNamespaces(testNs) === Array())
+
+catalog.dropNamespace(testNs)
+ }
+
+ test("listNamespaces: fail if missing namespace") {
+val catalog = newCatalog()
+
+assert(catalog.namespaceExists(testNs) === false)
+
+val exc = intercept[NoSuchNamespaceException] {
+ assert(catalog.listNamespaces(testNs) === Array())
+}
+
+assert(exc.getMessage.contains(testNs.quoted))
+assert(catalog.namespaceExists(testNs) === false)
+ }
+
+ test("loadNamespaceMetadata: fail missing namespace") {
+val catalog = newCatalog()
+
+val exc = intercept[NoSuchNamespaceException] {
+ catalog.loadNamespaceMetadata(testNs)
+}
+
+assert(exc.getMessage.contains(testNs.quoted))
+ }
+
+ test("loadNamespaceMetadata: non-empty metadata") {
+val catalog = newCatalog()
+
+assert(catalog.namespaceExists(testNs) === false)
+
+catalog.createNamespace(testNs, Map("property" -> "value").asJava)
+
+val metadata = catalog.loadNamespaceMetadata(testNs)
+
+assert(catalog.namespaceExists(testNs) === true)
+checkMetadata(metadata.asScala, Map("property" -> "value"))
+
+catalog.dropNamespace(testNs)
+ }
+
+ test("loadNamespaceMetadata: empty metadata") {
+val catalog = newCatalog()
+
+assert(catalog.namespaceExists(testNs) === false)
+
+catalog.createNamespace(testNs, emptyProps)
+
+val metadata = catalog.loadNamespaceMetadata(testNs)
+
+assert(catalog.namespaceExists(testNs) === true)
+checkMetadata(metadata.asScala, emptyProps.asScala)
+
+catalog.dropNamespace(testNs)
+ }
+
+ test("createNamespace: basic behavior") {
+val catalog = newCatalog()
+val expectedPath =
sqlContext.sessionState.catalog.getDefaultDBPath(testNs(0)).toString
+
+catalog.createNamespace(testNs, Map("property" -> "value").asJava)
+
+assert(expectedPath ===
spark.catalog.getDatabase(testNs(0)).locationUri.toString)
+
+assert(catalog.namespaceExists(testNs) === true)
+val metadata = catalog.loadNamespaceMetadata(testNs).asScala
+checkMetadata(metadata, Map("property" -> "value"))
+assert(expectedPath === metadata("location"))
+
+catalog.dropNamespace(testNs)
+ }
+
+ test("createNamespace: initialize location") {
+val catalog = newCatalog()
+val expectedPath = "file:/tmp/db.db"
+
+catalog.createNamespace(testNs, Map("location" -> expectedPath).asJava)
+
+assert(expectedPath ===
spark.catalog.getDatabase(testNs(0)).locationUri.toString)
+
+assert(catalog.namespaceExists(testNs) === true)
+val metadata = catalog.loadNamespaceMetadata(testNs).asScala
+checkMetadata(metadata, Map.empty)
+assert(expectedPath === metadata("location"))
+
+catalog.dropNamespace(testNs)
+ }
+
+ test("createNamespace: fail if namespace already exists") {
+val catalog = newCatalog()
+
+catalog.createNamespace(testNs, Map("property" -> "value").asJava)
+
+val exc = intercept[NamespaceAlreadyExistsException] {
+ catalog.createNamespace(testNs, Map("property" -> "value2").asJava)
+}
+
+assert(exc.getMessage.contains(testNs.quoted))
+assert(catalog.namespaceExists(testNs) === true)
+checkMetadata(catalog.loadNamespaceMetadata(testNs).asScala,
Map("property" -> "value"))
+
+catalog.dropNamespace(testNs)
+ }
+
+ test("createNamespace: fail nested namespace") {
+val catalog = newCatalog()
+
+// ensure the parent exists
+catalog.createNamespace(Array("db"), emptyProps)
+
+val exc = intercept[IllegalArgumentException] {
+ catalog.createNamespace(Array("db", "nested"), emptyProps)
+}
+
+assert(exc.getMessage.contains("Invalid namespace name: db.nested"))
+
+catalog.
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319741468
##
File path: appveyor.yml
##
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
Oh, do you mean
https://github.com/apache/spark/blob/master/R/WINDOWS.md#building-sparkr-on-windows
? Actually this flag fixed an issue specific to Appveyor. So regular Windows
build won't need this flag.
Actually, I have some more additional and required information to document
there. Building Spark on Windows requires `bash` (by Windows 11 or Cygwin) due
to, at least, here:
https://github.com/apache/spark/blob/9ea37b09cf6fa0ccf3436b0256b43d60b9099fd1/core/pom.xml#L464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319741468
##
File path: appveyor.yml
##
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
Oh, do you mean
https://github.com/apache/spark/blob/master/R/WINDOWS.md#building-sparkr-on-windows
? Actually this flag fixed an issue specific to Appveyor. So regular Windows
build won't need this flag.
Actually, I have some more additional and required information to document
there. Building Spark on Windows requires `bash` (by Windows 11 or Cygwin) due
to, at least, here:
https://github.com/apache/spark/blob/eed6de1a6533f259cbd60654d3e537ff7088f296/project/SparkBuild.scala#L516
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S] Upgrade kubernetes client to 4.4.2
dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526882891 cc @skonto , too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319741497
##
File path: appveyor.yml
##
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
Let me document this it later in few days.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319741468
##
File path: appveyor.yml
##
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
Oh, do you mean
https://github.com/apache/spark/blob/master/R/WINDOWS.md#building-sparkr-on-windows
? Yes, I guess we better note it.
Actually, I have some more additional and required information to document
there. Building Spark on Windows requires `bash` (by Windows 11 or Cygwin) due
to, at least, here:
https://github.com/apache/spark/blob/eed6de1a6533f259cbd60654d3e537ff7088f296/project/SparkBuild.scala#L516
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319741468
##
File path: appveyor.yml
##
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
Oh, do you mean
https://github.com/apache/spark/blob/master/R/WINDOWS.md#building-sparkr-on-windows
? Yes, I guess we better note it.
Actually, I have some more additional and required information to document
there. Building Spark on Windows requires `bash` (by Windows 11 or Cygwin) due
to here:
https://github.com/apache/spark/blob/eed6de1a6533f259cbd60654d3e537ff7088f296/project/SparkBuild.scala#L516
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526877877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109989/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526877875 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526877877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109989/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526877875 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526870514 **[Test build #109989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109989/testReport)** for PR 25640 at commit [`9a29d0b`](https://github.com/apache/spark/commit/9a29d0b28be115e6e4a025648b57a4e69758bfb8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-52682 **[Test build #109989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109989/testReport)** for PR 25640 at commit [`9a29d0b`](https://github.com/apache/spark/commit/9a29d0b28be115e6e4a025648b57a4e69758bfb8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL]
SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI
URL: https://github.com/apache/spark/pull/25611#discussion_r319740457
##
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
##
@@ -258,7 +266,11 @@ object HiveThriftServer2 extends Logging {
def onOperationClosed(id: String): Unit = synchronized {
executionList(id).closeTimestamp = System.currentTimeMillis
+ val lastState = executionList(id).state
executionList(id).state = ExecutionState.CLOSED
+ if (lastState == ExecutionState.STARTED || lastState ==
ExecutionState.COMPILED) {
+totalRunning -= 1
+ }
Review comment:
> does FINISHED need to be handled somewhere?
this place is to handle situation like : we have call close before finish,
then the totalRunning value should -1 too. If we call `cancel()` or it
finished, then when we call closeOperation, we won't do `totalRunning -= 1`.
Since for FINISHED, has do `totalRunning -= 1 `, so here don't need to contain
FINISHED
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876906 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876441 **[Test build #109990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109990/testReport)** for PR 25532 at commit [`6912965`](https://github.com/apache/spark/commit/691296562e9b5e22cf54c731d2b2e3c871745c4d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876815 **[Test build #109990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109990/testReport)** for PR 25532 at commit [`6912965`](https://github.com/apache/spark/commit/691296562e9b5e22cf54c731d2b2e3c871745c4d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876906 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876907 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109990/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876907 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109990/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
SparkQA commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876441 **[Test build #109990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109990/testReport)** for PR 25532 at commit [`6912965`](https://github.com/apache/spark/commit/691296562e9b5e22cf54c731d2b2e3c871745c4d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876362 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15009/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #25490: [SPARK-28756][R][FOLLOW-UP] Specify minimum and maximum Java versions
srowen commented on issue #25490: [SPARK-28756][R][FOLLOW-UP] Specify minimum and maximum Java versions URL: https://github.com/apache/spark/pull/25490#issuecomment-526876410 @felixcheung Oh yes I just meant specify in the CRAN config or whatever that it uses Java 8 only, if that causes it to test vs Java 8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876361 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876362 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15009/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
AmplabJenkins removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526876361 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference
huaxingao removed a comment on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-523690824  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold
huaxingao commented on issue #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold URL: https://github.com/apache/spark/pull/25623#issuecomment-526876236 Thanks all for your help! @srowen @dilipbiswal @gatorsmile This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] felixcheung commented on issue #25280: [SPARK-28548][SQL] explain() shows wrong result for persisted DataFrames after some operations
felixcheung commented on issue #25280: [SPARK-28548][SQL] explain() shows wrong result for persisted DataFrames after some operations URL: https://github.com/apache/spark/pull/25280#issuecomment-526875967 ... where are we on this? this seems to be severe correctness impacting issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] felixcheung commented on a change in pull request #25633: [SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
felixcheung commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319739934
##
File path: appveyor.yml
##
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
do we need to document this as "building spark on windows" then? ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] felixcheung commented on issue #25490: [SPARK-28756][R][FOLLOW-UP] Specify minimum and maximum Java versions
felixcheung commented on issue #25490: [SPARK-28756][R][FOLLOW-UP] Specify minimum and maximum Java versions URL: https://github.com/apache/spark/pull/25490#issuecomment-526875809 > If for some reason we find that JDK 11 + SparkR or CRAN is having trouble, we can just tell CRAN to test vs 8 for its purposes. +1 believe me, we couldn't "tell" them to do stuff... very long story. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526875518 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109988/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526875517 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526875518 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109988/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526875517 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] felixcheung commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI
felixcheung commented on a change in pull request #25611: [SPARK-28901][SQL]
SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI
URL: https://github.com/apache/spark/pull/25611#discussion_r319739823
##
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
##
@@ -258,7 +266,11 @@ object HiveThriftServer2 extends Logging {
def onOperationClosed(id: String): Unit = synchronized {
executionList(id).closeTimestamp = System.currentTimeMillis
+ val lastState = executionList(id).state
executionList(id).state = ExecutionState.CLOSED
+ if (lastState == ExecutionState.STARTED || lastState ==
ExecutionState.COMPILED) {
+totalRunning -= 1
+ }
Review comment:
does FINISHED need to be handled somewhere?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
SparkQA removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526868953 **[Test build #109988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109988/testReport)** for PR 25634 at commit [`069e4ab`](https://github.com/apache/spark/commit/069e4abf41263daef571f7465d06e89220fac6c0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
SparkQA commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526875429 **[Test build #109988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109988/testReport)** for PR 25634 at commit [`069e4ab`](https://github.com/apache/spark/commit/069e4abf41263daef571f7465d06e89220fac6c0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] felixcheung commented on issue #25614: [WIP][SPARK-28887][K8S] Executor pod status fix
felixcheung commented on issue #25614: [WIP][SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526875391 please update the PR description also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations
SparkQA removed a comment on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-526866710 **[Test build #4854 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4854/testReport)** for PR 25558 at commit [`6e9bb61`](https://github.com/apache/spark/commit/6e9bb612c3c3d863f19d4019abe31f855783e44d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations
SparkQA commented on issue #25558: [SPARK-28855][CORE][ML][SQL][STREAMING] Remove outdated usages of Experimental, Evolving annotations URL: https://github.com/apache/spark/pull/25558#issuecomment-526875019 **[Test build #4854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4854/testReport)** for PR 25558 at commit [`6e9bb61`](https://github.com/apache/spark/commit/6e9bb612c3c3d863f19d4019abe31f855783e44d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
dongjoon-hyun removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526873668 Now, we are waiting Java11 and K8s integration test result~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526873668 Now, we are waiting Java11 and K8s integration test result~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
dongjoon-hyun edited a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526873597 Got it. However, this PR intentionally violates our templates. Our template consists of four parts and the second part is the following. The author had better follow the official Apache Spark guideline. > ### Why are the changes needed? Please update the PR description before you merge this, @gatorsmile . Thanks~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
dongjoon-hyun edited a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526873597 Got it. However, this PR intentionally violates our templates. Our template consists of four parts and the second part is the following. The author had better follow the official Apache Spark guideline. > ### Why are the changes needed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
dongjoon-hyun edited a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526873597 Got it. However, this PR intentionally violated our templates. Our template consists of four parts and the second part is the following. The author had better follow the official Apache Spark guideline. > ### Why are the changes needed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526866741 **[Test build #4855 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4855/testReport)** for PR 25640 at commit [`9a29d0b`](https://github.com/apache/spark/commit/9a29d0b28be115e6e4a025648b57a4e69758bfb8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
dongjoon-hyun commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526873597 Got it. However, this PR intentionally violated our templates. Our template consists of four parts and the second part is the following. > ### Why are the changes needed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526873583 **[Test build #4855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4855/testReport)** for PR 25640 at commit [`9a29d0b`](https://github.com/apache/spark/commit/9a29d0b28be115e6e4a025648b57a4e69758bfb8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526872261 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526872265 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15008/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526872257 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15008/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526872261 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
AmplabJenkins removed a comment on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526872265 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15008/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2
gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add
UPDATE support for DataSource V2
URL: https://github.com/apache/spark/pull/25626#discussion_r319738668
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -474,6 +475,14 @@ selectClause
: SELECT (hints+=hint)* setQuantifier? namedExpressionSeq
;
+setClause
+: SET assign (',' assign)*
+;
+
+assign
+: key=multipartIdentifier EQ value=valueExpression
Review comment:
valueExpression -> expression.
Although we do not support subqueries, we should make the parser support it
and issue an exception in the analyzer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2
gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r319738632 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -215,6 +215,7 @@ statement | SET .*? #setConfiguration | RESET #resetConfiguration | DELETE FROM multipartIdentifier tableAlias whereClause #deleteFromTable Review comment: Also, we should make whereClause optional too for DELETE. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2
gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r319738632 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -215,6 +215,7 @@ statement | SET .*? #setConfiguration | RESET #resetConfiguration | DELETE FROM multipartIdentifier tableAlias whereClause #deleteFromTable Review comment: Also, we should make whereClause optional for DELETE too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2
gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r319738632 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -215,6 +215,7 @@ statement | SET .*? #setConfiguration | RESET #resetConfiguration | DELETE FROM multipartIdentifier tableAlias whereClause #deleteFromTable Review comment: Also, we should make whereClause too for DELETE. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526871558 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15008/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2
gatorsmile commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r319738585 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -215,6 +215,7 @@ statement | SET .*? #setConfiguration | RESET #resetConfiguration | DELETE FROM multipartIdentifier tableAlias whereClause #deleteFromTable +| UPDATE multipartIdentifier tableAlias setClause whereClause #updateTable Review comment: whereClause is optional. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #25081: [SPARK-28309][R][INFRA] Fix AppVeyor to run SparkR tests by avoiding to use devtools for testthat
HyukjinKwon commented on issue #25081: [SPARK-28309][R][INFRA] Fix AppVeyor to run SparkR tests by avoiding to use devtools for testthat URL: https://github.com/apache/spark/pull/25081#issuecomment-526871081 Can you file a JIRA with showing the console output? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526870576 Also, if possible, please specify the version number of EKS which you are mentioning, @andygrove . `latest` becomes obsolete very soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
SparkQA commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526870514 **[Test build #109989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109989/testReport)** for PR 25640 at commit [`9a29d0b`](https://github.com/apache/spark/commit/9a29d0b28be115e6e4a025648b57a4e69758bfb8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2
dongjoon-hyun edited a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526870103 According to your error message, are you running it in JDK11? We need to do this in JDK8. > Could not find artifact jdk.tools:jdk.tools:jar:1.6 at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar Apache Spark 2.x doesn't support JDK11 yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2
dongjoon-hyun commented on issue #25640: [SPARK-28921][BUILD][K8S][test-hadoop3.2][test-java11] Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526870326 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25641: SPARK-28921: Update kubernetes client to 4.4.2 for Spark 2.4 branch
dongjoon-hyun commented on issue #25641: SPARK-28921: Update kubernetes client to 4.4.2 for Spark 2.4 branch URL: https://github.com/apache/spark/pull/25641#issuecomment-526870103 According to your error message, are you running it in JDK11? We need to do this in JDK8. > Could not find artifact jdk.tools:jdk.tools:jar:1.6 at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526869238 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15007/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526869236 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526869236 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526869238 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15007/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
AmplabJenkins removed a comment on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526599082 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
SparkQA commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526868953 **[Test build #109988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109988/testReport)** for PR 25634 at commit [`069e4ab`](https://github.com/apache/spark/commit/069e4abf41263daef571f7465d06e89220fac6c0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
gatorsmile commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526868860 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
gatorsmile commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526868873 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
gatorsmile commented on a change in pull request #25634: [SPARK-28929][CORE]
Spark Logging level should be INFO instead of DEBUG in Executor Plugin API
URL: https://github.com/apache/spark/pull/25634#discussion_r319737605
##
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##
@@ -139,20 +139,20 @@ private[spark] class Executor(
private val executorPlugins: Seq[ExecutorPlugin] = {
val pluginNames = conf.get(EXECUTOR_PLUGINS)
if (pluginNames.nonEmpty) {
- logDebug(s"Initializing the following plugins: ${pluginNames.mkString(",
")}")
+ logInfo(s"Initializing the following plugins: ${pluginNames.mkString(",
")}")
Review comment:
It sounds reasonable to use logInfo for this message. The message is only
shown once for each executor. Debug level might be too low here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #25627: [SPARK-28923][SQL] Deduplicate the codes 'multipartIdentifier' and 'identifierSeq'
maropu commented on a change in pull request #25627: [SPARK-28923][SQL]
Deduplicate the codes 'multipartIdentifier' and 'identifierSeq'
URL: https://github.com/apache/spark/pull/25627#discussion_r319737529
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -567,11 +567,7 @@ sampleMethod
;
identifierList
-: '(' identifierSeq ')'
-;
-
-identifierSeq
-: ident+=errorCapturingIdentifier (',' ident+=errorCapturingIdentifier)*
Review comment:
oh, right. I missed it...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile closed pull request #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold
gatorsmile closed pull request #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold URL: https://github.com/apache/spark/pull/25623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold
gatorsmile commented on issue #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold URL: https://github.com/apache/spark/pull/25623#issuecomment-526868174 Thanks! Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #23531: [SPARK-24497][SQL] Support recursive SQL query
gatorsmile commented on issue #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-526867920 cc @maryannxue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile closed pull request #25527: [SPARK-28803][DOCS][SQL] Document DESCRIBE TABLE in SQL Reference
gatorsmile closed pull request #25527: [SPARK-28803][DOCS][SQL] Document DESCRIBE TABLE in SQL Reference URL: https://github.com/apache/spark/pull/25527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #25527: [SPARK-28803][DOCS][SQL] Document DESCRIBE TABLE in SQL Reference
gatorsmile commented on issue #25527: [SPARK-28803][DOCS][SQL] Document DESCRIBE TABLE in SQL Reference URL: https://github.com/apache/spark/pull/25527#issuecomment-526867427 LGTM Thanks! Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25640: SPARK-28921: Upgrade kubernetes client to 4.4.2
SparkQA commented on issue #25640: SPARK-28921: Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#issuecomment-526866741 **[Test build #4855 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4855/testReport)** for PR 25640 at commit [`9a29d0b`](https://github.com/apache/spark/commit/9a29d0b28be115e6e4a025648b57a4e69758bfb8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
