[GitHub] [spark] AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559923275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19474/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
SparkQA commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559923334 **[Test build #114643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114643/testReport)** for PR 26720 at commit [`d546870`](https://github.com/apache/spark/commit/d54687093a8dc755b7cd1d5e67b4d2be182b10a9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559923272 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559923275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19474/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559923272 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
SparkQA commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559923121 **[Test build #114652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114652/testReport)** for PR 26722 at commit [`933cd5d`](https://github.com/apache/spark/commit/933cd5d1ca4911d612c86e65376a4e931b0b32c4). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559922412 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114651/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559922410 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559922410 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559922412 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114651/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
SparkQA commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559922344 **[Test build #114651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114651/testReport)** for PR 26722 at commit [`d08fab9`](https://github.com/apache/spark/commit/d08fab961ab2e05ad16a88f3fe493b683eb8da23). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
SparkQA removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559919341 **[Test build #114651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114651/testReport)** for PR 26722 at commit [`d08fab9`](https://github.com/apache/spark/commit/d08fab961ab2e05ad16a88f3fe493b683eb8da23). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559919038 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins removed a comment on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559919039 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19473/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
SparkQA commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559919341 **[Test build #114651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114651/testReport)** for PR 26722 at commit [`d08fab9`](https://github.com/apache/spark/commit/d08fab961ab2e05ad16a88f3fe493b683eb8da23). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559919039 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19473/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
AmplabJenkins commented on issue #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large URL: https://github.com/apache/spark/pull/26722#issuecomment-559919038 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya opened a new pull request #26722: [SPARK-24666][ML] Fix infinity vectors produced by Word2Vec when numIterations are large
viirya opened a new pull request #26722: [SPARK-24666][ML] Fix infinity vectors
produced by Word2Vec when numIterations are large
URL: https://github.com/apache/spark/pull/26722
### What changes were proposed in this pull request?
This patch adds normalization to word vectors when fitting dataset in
Word2Vec.
### Why are the changes needed?
Running Word2Vec on some datasets, when numIterations is large, can produce
infinity word vectors.
### Does this PR introduce any user-facing change?
Yes. After this patch, Word2Vec won't produce infinity word vectors.
### How was this patch tested?
Manually. This issue is not always reproducible on any dataset. The dataset
known to reproduce it is too large (925M) to upload.
```scala
case class Sentences(name: String, words: Array[String])
val dataset = spark.read
.option("header", "true").option("sep", "\t")
.option("quote", "").option("nullValue", "\\N")
.csv("/tmp/title.akas.tsv")
.filter("region = 'US' or language = 'en'")
.select("title")
.as[String]
.map(s => Sentences(s, s.split(' ')))
.persist()
println("Training model...")
val word2Vec = new Word2Vec()
.setInputCol("words")
.setOutputCol("vector")
.setVectorSize(64)
.setWindowSize(4)
.setNumPartitions(50)
.setMinCount(5)
.setMaxIter(30)
val model = word2Vec.fit(dataset)
model.getVectors.show()
```
```
Training model...
+-++
| word| vector|
+-++
| Unspoken|[-Infinity,-Infin...|
| Talent|[-Infinity,Infini...|
|Hourglass|[2.02805806500023...|
|Nickelodeon's|[-4.2918617120906...|
| Priests|[-1.3570403355926...|
|Religion:|[-6.7049072282803...|
| Bu|[5.05591774315586...|
| Totoro:|[-1.0539840178632...|
| Trouble,|[-3.5363592836003...|
| Hatter|[4.90413981352826...|
| '79|[7.50436471285412...|
| Vile|[-2.9147142985312...|
| 9/11|[-Infinity,Infini...|
| Santino|[1.30005911270850...|
| Motives|[-1.2538958306253...|
| '13|[-4.5040152427657...|
| Fierce|[Infinity,Infinit...|
[GitHub] [spark] AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559918681 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114646/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559918680 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559918680 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
SparkQA removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559915258 **[Test build #114646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114646/testReport)** for PR 26716 at commit [`b43fca5`](https://github.com/apache/spark/commit/b43fca5de1b4d8d3d219101a01cd7dcccd69a6cd). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559918681 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114646/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
SparkQA commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559918668 **[Test build #114646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114646/testReport)** for PR 26716 at commit [`b43fca5`](https://github.com/apache/spark/commit/b43fca5de1b4d8d3d219101a01cd7dcccd69a6cd). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26717#issuecomment-559918555 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19472/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26717#issuecomment-559918554 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26717#issuecomment-559918555 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19472/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26717#issuecomment-559918554 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
SparkQA commented on issue #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26717#issuecomment-559918483 **[Test build #114650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114650/testReport)** for PR 26717 at commit [`074309d`](https://github.com/apache/spark/commit/074309d2e4c3766c02b36bfa1677d073507aa6b8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
huaxingao commented on a change in pull request #26717: [SPARK-30077][SQL]
Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26717#discussion_r352270225
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##
@@ -169,64 +169,6 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
}
}
- /**
- * Create a table, returning a [[CreateTable]] logical plan.
- *
- * This is used to produce CreateTempViewUsing from CREATE TEMPORARY TABLE.
- *
- * TODO: Remove this. It is used because CreateTempViewUsing is not a
Catalyst plan.
- * Either move CreateTempViewUsing into catalyst as a parsed logical plan,
or remove it because
- * it is deprecated.
- */
- override def visitCreateTable(ctx: CreateTableContext): LogicalPlan =
withOrigin(ctx) {
-val (ident, temp, ifNotExists, external) =
visitCreateTableHeader(ctx.createTableHeader)
-
-if (!temp || ctx.query != null) {
- super.visitCreateTable(ctx)
Review comment:
Thanks! Updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-559918166 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19471/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-559918164 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins removed a comment on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-559918164 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column
AmplabJenkins commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-559918166 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19471/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column
SparkQA commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-559918073 **[Test build #114649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114649/testReport)** for PR 26697 at commit [`23bef9c`](https://github.com/apache/spark/commit/23bef9cb752cc9a83eccd8e69a49eb57bdbd91fa). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column
HyukjinKwon commented on issue #26697: [SPARK-28461][SQL][test-hadoop3.2] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/26697#issuecomment-559917710 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
HyukjinKwon edited a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916772 @shahidki31, let's wait and see other builds. This specific test failure (after https://github.com/apache/spark/commit/4a73bed3180aeb79c92bb19aea2ac5a97899731a) might happen only in my PR too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
SparkQA commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559916807 **[Test build #114648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114648/testReport)** for PR 26720 at commit [`d546870`](https://github.com/apache/spark/commit/d54687093a8dc755b7cd1d5e67b4d2be182b10a9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
HyukjinKwon commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916772 @shahidki31, let's wait and see other builds. This specific test failure might happen only in my PR too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916507 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916509 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19470/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559916490 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19469/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559916488 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916509 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19470/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916507 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559916490 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19469/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559916488 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
HyukjinKwon commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559916408 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
SparkQA commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916418 **[Test build #114647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114647/testReport)** for PR 26707 at commit [`b35a586`](https://github.com/apache/spark/commit/b35a586b2714cc1db704c9b21e0440255fada8fd). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
HyukjinKwon commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916376 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
HyukjinKwon commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559916372 That one looked flaky, yes. Sure, let's see if that works. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915739 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114645/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915738 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915738 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
SparkQA commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915729 **[Test build #114645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114645/testReport)** for PR 26721 at commit [`563f6e1`](https://github.com/apache/spark/commit/563f6e119c65cef708fbfa964aef6be371d563b8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915739 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114645/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
SparkQA removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915251 **[Test build #114645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114645/testReport)** for PR 26721 at commit [`563f6e1`](https://github.com/apache/spark/commit/563f6e119c65cef708fbfa964aef6be371d563b8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559915314 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19468/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins removed a comment on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559915310 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19467/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559915314 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19468/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19467/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins removed a comment on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915294 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
AmplabJenkins commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915294 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
AmplabJenkins commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559915310 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking
SparkQA commented on issue #26716: [SPARK-30083][SQL] visitArithmeticUnary should wrap PLUS case with UnaryPositive for type checking URL: https://github.com/apache/spark/pull/26716#issuecomment-559915258 **[Test build #114646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114646/testReport)** for PR 26716 at commit [`b43fca5`](https://github.com/apache/spark/commit/b43fca5de1b4d8d3d219101a01cd7dcccd69a6cd). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
SparkQA commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915251 **[Test build #114645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114645/testReport)** for PR 26721 at commit [`563f6e1`](https://github.com/apache/spark/commit/563f6e119c65cef708fbfa964aef6be371d563b8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
huaxingao commented on issue #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721#issuecomment-559915236 I know there are other inconsistencies. I will fix one by one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao opened a new pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference
huaxingao opened a new pull request #26721: [SPARK-30085][SQL][DOC] Standardize partition spec in sql reference URL: https://github.com/apache/spark/pull/26721 ### What changes were proposed in this pull request? Standardize partition spec in sql reference ### Why are the changes needed? To have consistent docs ### Does this PR introduce any user-facing change? Yes ### How was this patch tested? Tested using jykyll build --serve This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559914873 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114641/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559914873 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114641/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559914870 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
SparkQA removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559909986 **[Test build #114641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114641/testReport)** for PR 26707 at commit [`b35a586`](https://github.com/apache/spark/commit/b35a586b2714cc1db704c9b21e0440255fada8fd). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
AmplabJenkins removed a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559914870 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
SparkQA commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559914827 **[Test build #114641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114641/testReport)** for PR 26707 at commit [`b35a586`](https://github.com/apache/spark/commit/b35a586b2714cc1db704c9b21e0440255fada8fd). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26709: [SPARK-30075][CORE][TESTS] Fix the hashCode implementation of ArrayKeyIndexType correctly
SparkQA commented on issue #26709: [SPARK-30075][CORE][TESTS] Fix the hashCode implementation of ArrayKeyIndexType correctly URL: https://github.com/apache/spark/pull/26709#issuecomment-559914242 **[Test build #114644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114644/testReport)** for PR 26709 at commit [`7a74f06`](https://github.com/apache/spark/commit/7a74f0635cdb77df908e256bed1d950c4100c2a3). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #26709: [SPARK-30075][CORE][TESTS] Fix the hashCode implementation of ArrayKeyIndexType correctly
HeartSaVioR commented on a change in pull request #26709:
[SPARK-30075][CORE][TESTS] Fix the hashCode implementation of ArrayKeyIndexType
correctly
URL: https://github.com/apache/spark/pull/26709#discussion_r352267764
##
File path:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java
##
@@ -38,7 +38,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
-return key.hashCode();
+return Arrays.hashCode(key);
Review comment:
That might be the reason of participating only key, but your suggestion
would be symmetrical and no big deal (as it had been completely broken). Thanks
for the suggestion! Applied.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559913971 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559913973 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19466/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins removed a comment on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559913971 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
AmplabJenkins commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559913973 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19466/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
SparkQA commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559913925 **[Test build #114643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114643/testReport)** for PR 26720 at commit [`d546870`](https://github.com/apache/spark/commit/d54687093a8dc755b7cd1d5e67b4d2be182b10a9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
shahidki31 commented on issue #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720#issuecomment-559913792 cc @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 opened a new pull request #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module
shahidki31 opened a new pull request #26720: [MINOR][TESTS]Avoid Mockito test issue in thrift server module URL: https://github.com/apache/spark/pull/26720 We need to add `HiveThriftServer2ListenerSuite` in `testsWhichShouldRunInTheirOwnDedicatedJvm` as that also uses Mockito now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
viirya commented on a change in pull request #26717: [SPARK-30077][SQL] Create
TEMPORARY VIEW USING should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26717#discussion_r352267220
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##
@@ -169,64 +169,6 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
}
}
- /**
- * Create a table, returning a [[CreateTable]] logical plan.
- *
- * This is used to produce CreateTempViewUsing from CREATE TEMPORARY TABLE.
- *
- * TODO: Remove this. It is used because CreateTempViewUsing is not a
Catalyst plan.
- * Either move CreateTempViewUsing into catalyst as a parsed logical plan,
or remove it because
- * it is deprecated.
- */
- override def visitCreateTable(ctx: CreateTableContext): LogicalPlan =
withOrigin(ctx) {
-val (ident, temp, ifNotExists, external) =
visitCreateTableHeader(ctx.createTableHeader)
-
-if (!temp || ctx.query != null) {
- super.visitCreateTable(ctx)
Review comment:
After this PR, `CREATE TEMPORARY TABLE ` is not supported at all. Previously
it was supported, though deprecated. Only `CREATE TEMPORARY TABLE IF NOT
EXISTS` is not supported at all.
We should update the message `CREATE TEMPORARY TABLE IF NOT EXISTS` in
`operationNotAllowed`.
Previously `CREATE TEMPORARY TABLE ... USING ...` is not supported by the
catalyst parser but supported by SparkSqlParser. We should update the comment
too (remove `by the catalyst parser`).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on issue #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI
shahidki31 commented on issue #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#issuecomment-559913147 Thanks a lot @gengliangwang @juliuszsompolski @AngersZh for the reviews This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 edited a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
shahidki31 edited a comment on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559913079 I think now we need to add `HiveThriftServer2ListenerSuite` in `testsWhichShouldRunInTheirOwnDedicatedJvm` as that also uses Mockito now. I will try using scala Mockito as a followup PR, to let me see if it fixes the issues. https://github.com/mockito/mockito-scala. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0
shahidki31 commented on issue #26707: [SPARK-30076][BUILD][TESTS] Upgrade Mockito to 3.1.0 URL: https://github.com/apache/spark/pull/26707#issuecomment-559913079 I think now we need to add `HiveThriftServer2ListenerSuite` in testsWhichShouldRunInTheirOwnDedicatedJvm as that also uses Mockito now. I will try using scala Mockito as a followup PR, to let me see if it fixes the issues. https://github.com/mockito/mockito-scala. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911443 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911444 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19465/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911444 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19465/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911443 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
SparkQA commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911379 **[Test build #114642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114642/testReport)** for PR 26594 at commit [`476d60e`](https://github.com/apache/spark/commit/476d60e469c213951e4a2ce16572328b62cb85ba). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
wangyum commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911319 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #24518: [SPARK-27627][SQL] Make option "pathGlobFilter" as a general option for all file sources
HyukjinKwon commented on a change in pull request #24518: [SPARK-27627][SQL] Make option "pathGlobFilter" as a general option for all file sources URL: https://github.com/apache/spark/pull/24518#discussion_r352265968 ## File path: python/pyspark/sql/readwriter.py ## @@ -120,6 +120,9 @@ def option(self, key, value): * ``timeZone``: sets the string that indicates a timezone to be used to parse timestamps in the JSON/CSV datasources or partition values. If it isn't set, it uses the default value, session local timezone. +* ``pathGlobFilter``: an optional glob pattern to only include files with paths matching Review comment: Sorry, actually can we move this documentation to each implementation of CSV, Parquet, ORC, text? It will only work with such internal file based sources. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #26698: [SPARK-29685][SQL] Adds format to the spark-sql output like its implemented by Dataset showString
wangyum commented on issue #26698: [SPARK-29685][SQL] Adds format to the spark-sql output like its implemented by Dataset showString URL: https://github.com/apache/spark/pull/26698#issuecomment-559911274 Hi @javierivanov Are you interested in implementing a new Spark CLI similar to `spark-sql`, but does not include any Hive dependency. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11
AngersZh commented on issue #26594: [SPARK-29957][TEST][test-java11][test-hadoop3.2][test-maven] Reset MiniKDC's default enctypes to fit jdk8/jdk11 URL: https://github.com/apache/spark/pull/26594#issuecomment-559911249 > Not yet seen execution with `[test-maven]`, is it not possible? Could you help to trigger reresr? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #24830: [SPARK-27990][SQL][ML] Provide a way to recursively load data from datasource
HyukjinKwon commented on a change in pull request #24830:
[SPARK-27990][SQL][ML] Provide a way to recursively load data from datasource
URL: https://github.com/apache/spark/pull/24830#discussion_r352265773
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala
##
@@ -62,6 +62,10 @@ abstract class PartitioningAwareFileIndex(
pathGlobFilter.forall(_.accept(file.getPath))
}
+ protected lazy val recursiveFileLookup = {
+parameters.getOrElse("recursiveFileLookup", "false").toBoolean
Review comment:
Guys, we should also update `DataStreamReadaer` and `streaming.py`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26718: [SPARK-27990][SPARK-29903][PYTHON] Add recursiveFileLookup option to Python DataFrameReader
HyukjinKwon commented on a change in pull request #26718: [SPARK-27990][SPARK-29903][PYTHON] Add recursiveFileLookup option to Python DataFrameReader URL: https://github.com/apache/spark/pull/26718#discussion_r352265743 ## File path: python/pyspark/sql/readwriter.py ## @@ -300,9 +304,12 @@ def table(self, tableName): return self._df(self._jreader.table(tableName)) @since(1.4) -def parquet(self, *paths): +def parquet(self, *paths, **options): Review comment: seems fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26719: [SPARK-30084] Document how to trigger Jekyll build on Python API doc changes
HyukjinKwon commented on a change in pull request #26719: [SPARK-30084] Document how to trigger Jekyll build on Python API doc changes URL: https://github.com/apache/spark/pull/26719#discussion_r352265649 ## File path: docs/README.md ## @@ -102,3 +102,17 @@ using [MkDocs](https://www.mkdocs.org/). NOTE: To skip the step of building and copying over the Scala, Java, Python, R and SQL API docs, run `SKIP_API=1 jekyll build`. In addition, `SKIP_SCALADOC=1`, `SKIP_PYTHONDOC=1`, `SKIP_RDOC=1` and `SKIP_SQLDOC=1` can be used to skip a single step of the corresponding language. `SKIP_SCALADOC` indicates skipping both the Scala and Java docs. + +### Automatically Rebuilding API Docs + +`jekyll serve --watch` will only watch what's in `docs/`, and it [won't follow symlinks](https://github.com/jekyll/jekyll/issues/233). That means it won't monitor your API docs. Review comment: If the only reason to use `entr` is this symbolic links problem, I think it's better to either fix the configurations in jekyll to allow or verify if there are other more problems .. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
