[GitHub] [spark] AmplabJenkins commented on pull request #28550: [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28550:
URL: https://github.com/apache/spark/pull/28550#issuecomment-629600181







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


SparkQA commented on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629600161







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629600162


   **[Test build #122719 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122719/testReport)**
 for PR 28539 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `class AvroDeserializer(`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28550: [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure

2020-05-16 Thread GitBox


SparkQA commented on pull request #28550:
URL: https://github.com/apache/spark/pull/28550#issuecomment-629600163







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA commented on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629600166


   **[Test build #122705 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122705/testReport)**
 for PR 28526 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `class AvroDeserializer(`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


SparkQA commented on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629600168


   **[Test build #122696 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122696/testReport)**
 for PR 28517 at commit 
[`84c172f`](https://github.com/apache/spark/commit/84c172fb20321b082fc98fa419f9756ec44a6a7e).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629599183


   **[Test build #122719 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122719/testReport)**
 for PR 28539 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


SparkQA commented on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629600160


   **[Test build #122702 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122702/testReport)**
 for PR 28538 at commit 
[`db11dcc`](https://github.com/apache/spark/commit/db11dccaf6424e4207a1fffe03a540ce3276cf22).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `class ExpressionInfoSuite extends QueryTest with SharedSparkSession `



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


SparkQA commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629600165


   **[Test build #122715 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122715/testReport)**
 for PR 28463 at commit 
[`978e60e`](https://github.com/apache/spark/commit/978e60e171e35b01ee166e00c4f63da3db877aad).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `//   starting closure (in class T)`
 * `// we need to track calls from \"inner closure\" to outer classes 
relative to it (class T, A, B)`
 * `logDebug(s\"found inner class $ownerExternalName\")`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629600189







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629600194







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629600237







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28550: [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28550:
URL: https://github.com/apache/spark/pull/28550#issuecomment-629600239







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629600195







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629600334







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629600237


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629600194


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629600296







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629600378







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28550: [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28550:
URL: https://github.com/apache/spark/pull/28550#issuecomment-629600181







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28550: [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28550:
URL: https://github.com/apache/spark/pull/28550#issuecomment-629600246


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122706/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629600202


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122715/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629584111


   **[Test build #122702 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122702/testReport)**
 for PR 28538 at commit 
[`db11dcc`](https://github.com/apache/spark/commit/db11dccaf6424e4207a1fffe03a540ce3276cf22).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629593355


   **[Test build #122715 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122715/testReport)**
 for PR 28463 at commit 
[`978e60e`](https://github.com/apache/spark/commit/978e60e171e35b01ee166e00c4f63da3db877aad).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629600195







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629600378


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629600334


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629600189


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28550: [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28550:
URL: https://github.com/apache/spark/pull/28550#issuecomment-629586148







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629600335


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122705/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629600299


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122710/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629600380


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122696/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629568814


   **[Test build #122696 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122696/testReport)**
 for PR 28517 at commit 
[`84c172f`](https://github.com/apache/spark/commit/84c172fb20321b082fc98fa419f9756ec44a6a7e).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629588704







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629585507


   **[Test build #122705 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122705/testReport)**
 for PR 28526 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629600190


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122719/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629600241


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122702/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


MaxGekk commented on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629601326


   jenkins, retest this, please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


SparkQA commented on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629601546


   **[Test build #122720 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122720/testReport)**
 for PR 28538 at commit 
[`db11dcc`](https://github.com/apache/spark/commit/db11dccaf6424e4207a1fffe03a540ce3276cf22).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629601692







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28538: [SPARK-31526][SQL][TESTS][FOLLOWUP] Make ExpressionInfo independent from local time zone

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28538:
URL: https://github.com/apache/spark/pull/28538#issuecomment-629601692







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HeartSaVioR commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


HeartSaVioR commented on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629601828


   retest this, please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] karolchmist commented on pull request #28545: [WIP][SPARK-30090][SHELL] Adapt Spark REPL to Scala 2.13

2020-05-16 Thread GitBox


karolchmist commented on pull request #28545:
URL: https://github.com/apache/spark/pull/28545#issuecomment-629602098


   > > I couldn't find a way to run the initialization code with existing REPL 
classes in Scala 2.13.2
   > 
   > Did you try writing the auto-run script to a temporary file, calling 
`System.setProperty("scala.repl.autoruncode", "/tmp/path/to/script")`?
   
   I considered it, but then a new temp file would be created every time the 
REPL is started... It would work probably. 
   
   Also, I thought that maybe this setting should be left untouched to the user.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


SparkQA commented on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629602289


   **[Test build #122721 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122721/testReport)**
 for PR 28517 at commit 
[`84c172f`](https://github.com/apache/spark/commit/84c172fb20321b082fc98fa419f9756ec44a6a7e).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629602389







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28517:
URL: https://github.com/apache/spark/pull/28517#issuecomment-629602389







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426130288



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"exiting spark-submit JVM.")
+System.exit(0)
+  case _ =>
+Thread.sleep(REPORT_DRIVER_STATUS_INTERVAL)

Review comment:
   @Ngone51 Thanks for reviewing. I tried simulating that case by 
increasing the `Thread.sleep `time and I see that `onDisconnected` is called 
when the master is stopped during sleep time and following logs are generated:
   ```
   20/05/16 13:24:44 ERROR ClientEndpoint: Error connecting to master 
127.0.0.1:7077.
   20/05/16 13:24:44 ERROR ClientEndpoint: No master is available, exiting.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


HyukjinKwon commented on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629606571


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


HyukjinKwon commented on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629606600


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


HyukjinKwon commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629606640


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629606823


   **[Test build #122723 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122723/testReport)**
 for PR 28539 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


SparkQA commented on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629606826


   **[Test build #122722 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122722/testReport)**
 for PR 28547 at commit 
[`01aeeba`](https://github.com/apache/spark/commit/01aeebac964485971c2d79083c25815fa7b68fb9).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA commented on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629606837


   **[Test build #122724 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122724/testReport)**
 for PR 28526 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629607009







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629607023







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629607045







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629607009







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28526:
URL: https://github.com/apache/spark/pull/28526#issuecomment-629607045







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28547: [SPARK-31732][TESTS] Disable some flaky tests temporarily

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28547:
URL: https://github.com/apache/spark/pull/28547#issuecomment-629607023







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AngersZhuuuu commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AngersZh commented on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629611586


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


SparkQA commented on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629612032


   **[Test build #122725 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122725/testReport)**
 for PR 28509 at commit 
[`692db6a`](https://github.com/apache/spark/commit/692db6aee585af63ce57cd22733b78beaf3d1b51).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629612196







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629612196







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629613378







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


SparkQA commented on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629613372


   **[Test build #122725 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122725/testReport)**
 for PR 28509 at commit 
[`692db6a`](https://github.com/apache/spark/commit/692db6aee585af63ce57cd22733b78beaf3d1b51).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629612032


   **[Test build #122725 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122725/testReport)**
 for PR 28509 at commit 
[`692db6a`](https://github.com/apache/spark/commit/692db6aee585af63ce57cd22733b78beaf3d1b51).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629613378


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629613379


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122725/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-05-16 Thread GitBox


cloud-fan commented on pull request #28055:
URL: https://github.com/apache/spark/pull/28055#issuecomment-629614195


   thanks, merging to master/3.0!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan closed pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-05-16 Thread GitBox


cloud-fan closed pull request #28055:
URL: https://github.com/apache/spark/pull/28055


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] EnricoMi commented on pull request #27378: [SPARK-30366][WebUI] Show cached subplan of InMemoryTableScan and remove redundant subplans

2020-05-16 Thread GitBox


EnricoMi commented on pull request #27378:
URL: https://github.com/apache/spark/pull/27378#issuecomment-629620890


   Would be nice if a committer would take a look into this. The author has 
addressed all comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426130288



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"exiting spark-submit JVM.")
+System.exit(0)
+  case _ =>
+Thread.sleep(REPORT_DRIVER_STATUS_INTERVAL)

Review comment:
   @Ngone51 Thanks for reviewing. I tried simulating that case by 
increasing the `Thread.sleep `time and I see that `onDisconnected` is called 
when the master is stopped during sleep time and following logs are generated:
   ```
   20/05/16 13:24:44 ERROR ClientEndpoint: Error connecting to master 
127.0.0.1:7077.
   20/05/16 13:24:44 ERROR ClientEndpoint: No master is available, exiting.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426142394



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -61,6 +61,10 @@ private class ClientEndpoint(
 
private val lostMasters = new HashSet[RpcAddress]
private var activeMasterEndpoint: RpcEndpointRef = null
+   private val waitAppCompletion = 
conf.getBoolean("spark.standalone.submit.waitAppCompletion",

Review comment:
   @Ngone51 There doesn't seem to be any config class specific to 
standalone deploy related code. Could you kindly suggest where I should be 
adding this config?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AngersZhuuuu commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-16 Thread GitBox


AngersZh commented on pull request #28509:
URL: https://github.com/apache/spark/pull/28509#issuecomment-629632383


   @dongjoon-hyun Seems something still wrong, missing something on branch-3.0?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


maropu commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629634906


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


SparkQA commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629635747


   **[Test build #122726 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122726/testReport)**
 for PR 28463 at commit 
[`978e60e`](https://github.com/apache/spark/commit/978e60e171e35b01ee166e00c4f63da3db877aad).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629635916







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629635916







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] TJX2014 commented on pull request #28534: [SPARK-31710][SQL]Fix millisecond and microsecond convert to timestamp in to_timestamp

2020-05-16 Thread GitBox


TJX2014 commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-629636309


   @cloud-fan Could you please help me review it ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] TJX2014 edited a comment on pull request #28534: [SPARK-31710][SQL]Fix millisecond and microsecond convert to timestamp in to_timestamp

2020-05-16 Thread GitBox


TJX2014 edited a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-629636309


   @cloud-fan @MaxGekk  Could you please help me review it ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629636983


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629635747


   **[Test build #122726 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122726/testReport)**
 for PR 28463 at commit 
[`978e60e`](https://github.com/apache/spark/commit/978e60e171e35b01ee166e00c4f63da3db877aad).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


SparkQA commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629636980


   **[Test build #122726 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122726/testReport)**
 for PR 28463 at commit 
[`978e60e`](https://github.com/apache/spark/commit/978e60e171e35b01ee166e00c4f63da3db877aad).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `//   starting closure (in class T)`
 * `// we need to track calls from \"inner closure\" to outer classes 
relative to it (class T, A, B)`
 * `logDebug(s\"found inner class $ownerExternalName\")`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629636983







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28463: [SPARK-31399][CORE][test-hadoop3.2][test-java11] Support indylambda Scala closure in ClosureCleaner

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28463:
URL: https://github.com/apache/spark/pull/28463#issuecomment-629636986


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122726/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150126



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +

Review comment:
   Thanks, updated in the latest commit.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150154



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"exiting spark-submit JVM.")
+System.exit(0)
+  case _ =>
+Thread.sleep(REPORT_DRIVER_STATUS_INTERVAL)
+logInfo(s"State of $submittedDriverID is ${state.get}, " +

Review comment:
   Thanks, I have changed it to use `logDebug`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150245



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"exiting spark-submit JVM.")
+System.exit(0)
+  case _ =>
+Thread.sleep(REPORT_DRIVER_STATUS_INTERVAL)

Review comment:
   @Ngone51 Thanks for reviewing. I have updated to use the task scheduler 
to do the same. Kindly review it again.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150313



##
File path: docs/spark-standalone.md
##
@@ -374,6 +374,25 @@ To run an interactive Spark shell against the cluster, run 
the following command
 
 You can also pass an option `--total-executor-cores ` to control the 
number of cores that spark-shell uses on the cluster.
 
+# Client Properties
+
+Spark applications supports the following configuration properties specific to 
standalone mode: 
+
+
+  Property NameDefault 
ValueMeaningSince Version
+  
+  spark.standalone.submit.waitAppCompletion
+  false
+  
+  In standalone cluster mode, controls whether the client waits to exit until 
the application completes.
+  If set to true, the client process will stay alive polling the 
application's status.

Review comment:
   Thanks, updated to `driver's`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150555



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"exiting spark-submit JVM.")
+System.exit(0)
+  case _ =>
+Thread.sleep(REPORT_DRIVER_STATUS_INTERVAL)
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"continue monitoring driver status.")
+asyncSendToMasterAndForwardReply[DriverStatusResponse](

Review comment:
   @jiangxb1987 Thanks for reviewing. I have changed it to 10 seconds and 
took care of your other comments. Kindly review the PR again.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150622



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -124,44 +129,53 @@ private class ClientEndpoint(
 }
   }
 
-  /* Find out driver status then exit the JVM */
+  /**
+   * Find out driver status then exit the JVM. If the waitAppCompletion is set 
to true, monitors
+   * the application until it finishes, fails or is killed.
+   */
   def pollAndReportStatus(driverId: String): Unit = {
 // Since ClientEndpoint is the only RpcEndpoint in the process, blocking 
the event loop thread
 // is fine.
 logInfo("... waiting before polling master for driver state")
 Thread.sleep(5000)
 logInfo("... polling master for driver state")
-val statusResponse =
-  
activeMasterEndpoint.askSync[DriverStatusResponse](RequestDriverStatus(driverId))
-if (statusResponse.found) {
-  logInfo(s"State of $driverId is ${statusResponse.state.get}")
-  // Worker node, if present
-  (statusResponse.workerId, statusResponse.workerHostPort, 
statusResponse.state) match {
-case (Some(id), Some(hostPort), Some(DriverState.RUNNING)) =>
-  logInfo(s"Driver running on $hostPort ($id)")
-case _ =>
-  }
-  // Exception, if present
-  statusResponse.exception match {
-case Some(e) =>
-  logError(s"Exception from cluster was: $e")
-  e.printStackTrace()
-  System.exit(-1)
-case _ =>
-  System.exit(0)
+  val statusResponse =

Review comment:
   Thanks, updated the indentation in the latest commit.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-16 Thread GitBox


akshatb1 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r426150245



##
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##
@@ -176,6 +190,25 @@ private class ClientEndpoint(
   } else if (!Utils.responseFromBackup(message)) {
 System.exit(-1)
   }
+
+case DriverStatusResponse(found, state, _, _, _) =>
+  if (found) {
+state.get match {
+  case DriverState.FINISHED | DriverState.FAILED |
+   DriverState.ERROR | DriverState.KILLED =>
+logInfo(s"State of $submittedDriverID is ${state.get}, " +
+  s"exiting spark-submit JVM.")
+System.exit(0)
+  case _ =>
+Thread.sleep(REPORT_DRIVER_STATUS_INTERVAL)

Review comment:
   @Ngone51 Thanks for reviewing. I have updated to use the task scheduler 
to do the same. Kindly review it again and let me know your comments.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] beliefer commented on a change in pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-16 Thread GitBox


beliefer commented on a change in pull request #28551:
URL: https://github.com/apache/spark/pull/28551#discussion_r426150861



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -260,7 +260,7 @@ object FunctionRegistry {
 expression[Pow]("pow", true),
 expression[Pow]("power"),
 expression[ToRadians]("radians"),
-expression[Rint]("rint"),
+expression[Rint]("rint", true),

Review comment:
   I reference 
https://github.com/apache/spark/blob/a89006aba03a623960e5c4c6864ca8c899c81db9/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L66.
   So the default pretty name of `Rint` is 'Round',  I think we can use this 
method to make it as 'Rint'.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] beliefer commented on a change in pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-16 Thread GitBox


beliefer commented on a change in pull request #28551:
URL: https://github.com/apache/spark/pull/28551#discussion_r426150960



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -251,7 +251,7 @@ object FunctionRegistry {
 expression[Log10]("log10"),
 expression[Log1p]("log1p"),
 expression[Log2]("log2"),
-expression[Log]("ln"),
+expression[Log]("ln", true),

Review comment:
   I reference 
https://github.com/apache/spark/blob/a89006aba03a623960e5c4c6864ca8c899c81db9/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L66.
   So the default pretty name of `Log` is 'LOG',  I think we can use this 
method to make it as 'ln'.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629642723


   **[Test build #122723 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122723/testReport)**
 for PR 28539 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `class AvroDeserializer(`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


SparkQA removed a comment on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629606823


   **[Test build #122723 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122723/testReport)**
 for PR 28539 at commit 
[`9f14144`](https://github.com/apache/spark/commit/9f14144d191c8c41d8b3bd9585d78eb7ddae8407).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins commented on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629642973







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28539: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28539:
URL: https://github.com/apache/spark/pull/28539#issuecomment-629642973







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-16 Thread GitBox


SparkQA commented on pull request #28551:
URL: https://github.com/apache/spark/pull/28551#issuecomment-629643538


   **[Test build #122727 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122727/testReport)**
 for PR 28551 at commit 
[`883a98e`](https://github.com/apache/spark/commit/883a98ee213e0df29a3f3046bc33134e6e5a9206).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28551: [SPARK-31393][SQL][FOLLOW-UP] Show the correct alias in schema for expression

2020-05-16 Thread GitBox


AmplabJenkins removed a comment on pull request #28551:
URL: https://github.com/apache/spark/pull/28551#issuecomment-629643742







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   >