[GitHub] [spark] HyukjinKwon commented on pull request #29042: [SPARK-32231][R][INFRA] Use Hadoop 3 winutils in AppVeyor build

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #29042:
URL: https://github.com/apache/spark/pull/29042#issuecomment-655940330


   Awesome!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon closed pull request #29040: [SPARK-32230][R][INFRA] Use Hadoop 2.7 profile in AppVeyor SparkR build

2020-07-09 Thread GitBox


HyukjinKwon closed pull request #29040:
URL: https://github.com/apache/spark/pull/29040


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29042: [SPARK-32231][R][INFRA] Use Hadoop 3 winutils in AppVeyor build

2020-07-09 Thread GitBox


SparkQA commented on pull request #29042:
URL: https://github.com/apache/spark/pull/29042#issuecomment-655941220


   **[Test build #125440 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125440/testReport)**
 for PR 29042 at commit 
[`f432ddc`](https://github.com/apache/spark/commit/f432ddcfcd971fd05f3947d2a9e8f342f5db3052).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-09 Thread GitBox


SparkQA commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-655942845


   **[Test build #125436 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125436/testReport)**
 for PR 29031 at commit 
[`a24d93f`](https://github.com/apache/spark/commit/a24d93feaa14f01e7878df1a8b2557ec26ea6104).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


SparkQA commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655942863


   **[Test build #125435 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125435/testReport)**
 for PR 29022 at commit 
[`6e422ff`](https://github.com/apache/spark/commit/6e422ff503d03191d47d44d6659fe9a6027a4fd9).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655943137







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-09 Thread GitBox


SparkQA commented on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-655942865


   **[Test build #125434 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125434/testReport)**
 for PR 28998 at commit 
[`04c18a0`](https://github.com/apache/spark/commit/04c18a0d88db9878de707b6b0d467f32da70145a).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `sealed trait UTCTimestamp extends BinaryExpression with 
ImplicitCastInputTypes with NullIntolerant `



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655942987







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


SparkQA commented on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655942853


   **[Test build #125439 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125439/testReport)**
 for PR 27428 at commit 
[`16d8c1d`](https://github.com/apache/spark/commit/16d8c1d26681c875d61e50305de43f3ca5e75154).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


SparkQA commented on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655942854


   **[Test build #125438 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125438/testReport)**
 for PR 28969 at commit 
[`7abf2b5`](https://github.com/apache/spark/commit/7abf2b5382f587049049fa111ae0c6b15aad17d5).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-09 Thread GitBox


SparkQA commented on pull request #28911:
URL: https://github.com/apache/spark/pull/28911#issuecomment-655942846


   **[Test build #125437 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125437/testReport)**
 for PR 28911 at commit 
[`da14484`](https://github.com/apache/spark/commit/da14484bb520662372b739078d4aa78433ac46a3).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


SparkQA commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655942866


   **[Test build #125432 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125432/testReport)**
 for PR 29041 at commit 
[`474cc70`](https://github.com/apache/spark/commit/474cc702794644a5d70ef9e097b982e15152465c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28911:
URL: https://github.com/apache/spark/pull/28911#issuecomment-655943144







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-655942958







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


SparkQA commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655942851







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-655902143


   **[Test build #125434 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125434/testReport)**
 for PR 28998 at commit 
[`04c18a0`](https://github.com/apache/spark/commit/04c18a0d88db9878de707b6b0d467f32da70145a).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655943482


   ok to test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655922667


   **[Test build #125438 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125438/testReport)**
 for PR 28969 at commit 
[`7abf2b5`](https://github.com/apache/spark/commit/7abf2b5382f587049049fa111ae0c6b15aad17d5).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-655942958


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655943793







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655925158


   **[Test build #125439 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125439/testReport)**
 for PR 27428 at commit 
[`16d8c1d`](https://github.com/apache/spark/commit/16d8c1d26681c875d61e50305de43f3ca5e75154).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-655943369







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a change in pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


HyukjinKwon commented on a change in pull request #29044:
URL: https://github.com/apache/spark/pull/29044#discussion_r452007377



##
File path: bin/load-spark-env.cmd
##
@@ -29,10 +29,7 @@ if [%SPARK_ENV_LOADED%] == [] (
 set SPARK_CONF_DIR=%~dp0..\conf
   )
 
-  set SPARK_ENV_CMD=%SPARK_CONF_DIR%\%SPARK_ENV_CMD%
-  if exist %SPARK_ENV_CMD% (
-call %SPARK_ENV_CMD%
-  )
+  call :LoadSparkEnv

Review comment:
   Yeah .. I vaguely remember setting env twice isn't allowed ..





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655943537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28911:
URL: https://github.com/apache/spark/pull/28911#issuecomment-655943144


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655942987


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #28911:
URL: https://github.com/apache/spark/pull/28911#issuecomment-655920412


   **[Test build #125437 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125437/testReport)**
 for PR 28911 at commit 
[`da14484`](https://github.com/apache/spark/commit/da14484bb520662372b739078d4aa78433ac46a3).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-655915346


   **[Test build #125436 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125436/testReport)**
 for PR 29031 at commit 
[`a24d93f`](https://github.com/apache/spark/commit/a24d93feaa14f01e7878df1a8b2557ec26ea6104).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655908793


   **[Test build #125435 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125435/testReport)**
 for PR 29022 at commit 
[`6e422ff`](https://github.com/apache/spark/commit/6e422ff503d03191d47d44d6659fe9a6027a4fd9).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655870033


   **[Test build #125432 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125432/testReport)**
 for PR 29041 at commit 
[`474cc70`](https://github.com/apache/spark/commit/474cc702794644a5d70ef9e097b982e15152465c).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-655943369


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655943137


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655943456







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


SparkQA removed a comment on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655865341







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655942999


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125439/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655943537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655943456


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655943148


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125438/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28911:
URL: https://github.com/apache/spark/pull/28911#issuecomment-655943157


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125437/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655943793


   Merged build finished. Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-655942972


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125436/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28998: [SPARK-32173][SQL] Deduplicate code in FromUTCTimestamp and ToUTCTimestamp

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28998:
URL: https://github.com/apache/spark/pull/28998#issuecomment-655943374


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125434/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655621925


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655943805


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125432/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655943665


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125428/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


SparkQA commented on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655944700


   **[Test build #125441 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125441/testReport)**
 for PR 29044 at commit 
[`bb018bb`](https://github.com/apache/spark/commit/bb018bbf7e4f549c8ade65e4e72d639b42e451a1).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655943460


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125435/
   Test FAILed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655945459







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a change in pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


HyukjinKwon commented on a change in pull request #29044:
URL: https://github.com/apache/spark/pull/29044#discussion_r452009537



##
File path: bin/load-spark-env.cmd
##
@@ -29,10 +29,7 @@ if [%SPARK_ENV_LOADED%] == [] (
 set SPARK_CONF_DIR=%~dp0..\conf
   )
 
-  set SPARK_ENV_CMD=%SPARK_CONF_DIR%\%SPARK_ENV_CMD%

Review comment:
   Can't you just replace `%SPARK_ENV_CMD%` to  `spark-env.cmd`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655945459







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655946625


   @warrenzhu25 it should be best to the input like your command you tried and 
output from the command explicitly in PR description especially given that not 
so many dev people here arguably don't have Windows env.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon edited a comment on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


HyukjinKwon edited a comment on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655946625


   @warrenzhu25 it should be best to show the input like your command you tried 
and output from the command explicitly in PR description especially given that 
not so many dev people here arguably don't have Windows env.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon edited a comment on pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

2020-07-09 Thread GitBox


HyukjinKwon edited a comment on pull request #29044:
URL: https://github.com/apache/spark/pull/29044#issuecomment-655946625


   @warrenzhu25 it should be best to show the input like your command you tried 
and output from the command explicitly before/after the fix in PR description 
especially given that not so many dev people here arguably don't have Windows 
env.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655947062


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] xuanyuanking commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-09 Thread GitBox


xuanyuanking commented on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-655947410


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655947411


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655947641


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on pull request #29009: [SPARK-32193][SQL][DOCS] Update regexp usage in SQL docs

2020-07-09 Thread GitBox


maropu commented on pull request #29009:
URL: https://github.com/apache/spark/pull/29009#issuecomment-655948027


   Thanks! Merged to master/3.0.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu closed pull request #29009: [SPARK-32193][SQL][DOCS] Update regexp usage in SQL docs

2020-07-09 Thread GitBox


maropu closed pull request #29009:
URL: https://github.com/apache/spark/pull/29009


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


SparkQA commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655948604


   **[Test build #125443 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125443/testReport)**
 for PR 29022 at commit 
[`6e422ff`](https://github.com/apache/spark/commit/6e422ff503d03191d47d44d6659fe9a6027a4fd9).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-09 Thread GitBox


SparkQA commented on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-655948736


   **[Test build #125445 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125445/testReport)**
 for PR 28904 at commit 
[`8034ca4`](https://github.com/apache/spark/commit/8034ca4bb8401f2070b8bb8048722255d145fdec).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


SparkQA commented on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655948624


   **[Test build #125444 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125444/testReport)**
 for PR 28969 at commit 
[`7abf2b5`](https://github.com/apache/spark/commit/7abf2b5382f587049049fa111ae0c6b15aad17d5).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


SparkQA commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655948609


   **[Test build #125442 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125442/testReport)**
 for PR 29041 at commit 
[`474cc70`](https://github.com/apache/spark/commit/474cc702794644a5d70ef9e097b982e15152465c).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655949283







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655949327







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-655949341







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-655949341







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655949360







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29041: [SPARK-20680][SQL][FOLLOW-UP] Revert NullType.simpleString from 'unknown' to 'null'

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655949283







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28969:
URL: https://github.com/apache/spark/pull/28969#issuecomment-655949360







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655949327







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-09 Thread GitBox


HyukjinKwon commented on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-655952212


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on a change in pull request #29009: [SPARK-32193][SQL][DOCS] Update regexp usage in SQL docs

2020-07-09 Thread GitBox


maropu commented on a change in pull request #29009:
URL: https://github.com/apache/spark/pull/29009#discussion_r452015664



##
File path: docs/sql-ref-syntax-qry-select-like.md
##
@@ -26,7 +26,7 @@ A LIKE predicate is used to search for a specific pattern.
 ### Syntax
 
 ```sql
-[ NOT ] { LIKE search_pattern [ ESCAPE esc_char ] | RLIKE regex_pattern }
+[ NOT ] { LIKE search_pattern [ ESCAPE esc_char ] | RLIKE regex_pattern | 
REGEXP regex_pattern}

Review comment:
   Btw, this reminded me that there are still missing keywords in the SQL 
docs: https://issues.apache.org/jira/browse/SPARK-31753
   Its very helpful if you take this over.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-655953086







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-09 Thread GitBox


dongjoon-hyun commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-655953401


   Retest this please.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-655953086







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 opened a new pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


Ngone51 opened a new pull request #29050:
URL: https://github.com/apache/spark/pull/29050


   
   
   ### What changes were proposed in this pull request?
   
   
   This PR proposes to use `Utils.getSimpleName(function)` instead of 
`function.getClass.getSimpleName` to get the class name.
   
   
   ### Why are the changes needed?
   
   
   For some functions(see the demo below),  using 
`function.getClass.getSimpleName` can hit "Malformed class name" error.
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   Yes.  For the demo,
   
   ```scala
object MalformedClassObject extends Serializable {
   class MalformedNonPrimitiveFunction extends (String => Int) with 
Serializable {
 override def apply(v1: String): Int = v1.toInt / 0
   }
 }
OuterScopes.addOuterScope(MalformedClassObject)
val f = new MalformedClassObject.MalformedNonPrimitiveFunction()
Seq("20").toDF("col").select(udf(f).apply(Column("col"))).collect()
   ```
   
   Before this PR, user can only see the error about "Malformed class name":
   
   ```scala
   An exception or error caused a run to abort: Malformed class name 
   java.lang.InternalError: Malformed class name
at java.lang.Class.getSimpleName(Class.java:1330)
at 
org.apache.spark.sql.catalyst.expressions.ScalaUDF.udfErrorMessage$lzycompute(ScalaUDF.scala:1157)
at 
org.apache.spark.sql.catalyst.expressions.ScalaUDF.udfErrorMessage(ScalaUDF.scala:1155)
at 
org.apache.spark.sql.catalyst.expressions.ScalaUDF.doGenCode(ScalaUDF.scala:1077)
at 
org.apache.spark.sql.catalyst.expressions.Expression.$anonfun$genCode$3(Expression.scala:147)
at scala.Option.getOrElse(Option.scala:189)
at 
org.apache.spark.sql.catalyst.expressions.Expression.genCode(Expression.scala:142)
at 
org.apache.spark.sql.catalyst.expressions.Alias.genCode(namedExpressions.scala:160)
at 
org.apache.spark.sql.execution.ProjectExec.$anonfun$doConsume$1(basicPhysicalOperators.scala:69)
   ...
   ```
   
   After this PR, user can see the real root cause of the udf failure:
   
   ```scala
   org.apache.spark.SparkException: Failed to execute user defined 
function(UDFSuite$MalformedClassObject$MalformedNonPrimitiveFunction: (string) 
=> int)
at 
org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown
 Source)
at 
org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at 
org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:753)
at 
org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:340)
at 
org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
at 
org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
at 
org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:127)
at 
org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:464)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1377)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:467)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
   Caused by: java.lang.ArithmeticException: / by zero
at 
org.apache.spark.sql.UDFSuite$MalformedClassObject$MalformedNonPrimitiveFunction.apply(UDFSuite.scala:677)
at 
org.apache.spark.sql.UDFSuite$MalformedClassObject$MalformedNonPrimitiveFunction.apply(UDFSuite.scala:676)
... 17 more
   
   ```
   ### How was this patch tested?
   
   
   Added a test.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] beliefer opened a new pull request #29051: [WIP][SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


beliefer opened a new pull request #29051:
URL: https://github.com/apache/spark/pull/29051


   ### What changes were proposed in this pull request?
   This PR used to test only, about https://github.com/apache/spark/pull/27428.
   If test pass, I will close this PR.
   
   
   ### Why are the changes needed?
   Just test.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   
   
   ### How was this patch tested?
   Jenkins test.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


Ngone51 commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655955330


   cc @cloud-fan @maropu @viirya Please take a look, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-09 Thread GitBox


SparkQA commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-655956230


   **[Test build #125449 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125449/testReport)**
 for PR 28683 at commit 
[`dbdab2d`](https://github.com/apache/spark/commit/dbdab2d72762af0e5e3301ee863f2e99d5bf28cd).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956198


   **[Test build #125447 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125447/testReport)**
 for PR 29050 at commit 
[`4117f99`](https://github.com/apache/spark/commit/4117f99b476d92954f667d1d6bf2d0e4ae5f5ffe).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29051: [WIP][SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


SparkQA commented on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-655956165


   **[Test build #125446 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125446/testReport)**
 for PR 29051 at commit 
[`3c49156`](https://github.com/apache/spark/commit/3c491564c8db4935699a25eb8f9fc74367f6ee95).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


SparkQA commented on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655956175


   **[Test build #125450 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125450/testReport)**
 for PR 27428 at commit 
[`3c49156`](https://github.com/apache/spark/commit/3c491564c8db4935699a25eb8f9fc74367f6ee95).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-09 Thread GitBox


SparkQA commented on pull request #28977:
URL: https://github.com/apache/spark/pull/28977#issuecomment-655956154


   **[Test build #125448 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125448/testReport)**
 for PR 28977 at commit 
[`0124cf3`](https://github.com/apache/spark/commit/0124cf3924d8b7f9962739f5ce3579c9ed0d0db9).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-655956796







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655956747







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956720







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #27428:
URL: https://github.com/apache/spark/pull/27428#issuecomment-655956747







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29051: [WIP][SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins commented on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-655956927







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-655956796







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956720







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29051: [WIP][SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-09 Thread GitBox


AmplabJenkins removed a comment on pull request #29051:
URL: https://github.com/apache/spark/pull/29051#issuecomment-655956927







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-09 Thread GitBox


cloud-fan commented on pull request #28975:
URL: https://github.com/apache/spark/pull/28975#issuecomment-655959230


   thanks, merging to master/3.0!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan closed pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-09 Thread GitBox


cloud-fan closed pull request #28975:
URL: https://github.com/apache/spark/pull/28975


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


cloud-fan commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452025662



##
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
 val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
 checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
   }
+
+  object MalformedClassObject extends Serializable {
+class MalformedNonPrimitiveFunction extends (String => Int) with 
Serializable {
+  override def apply(v1: String): Int = v1.toInt / 0
+}
+
+class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+  override def apply(v1: Int): Int = v1 / 0
+}
+  }
+
+  test("Use Utils.getSimpleName to avoid hitting Malformed class name") {

Review comment:
   can we add the jira id?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Ngone51 commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


Ngone51 commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452026471



##
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
 val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
 checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
   }
+
+  object MalformedClassObject extends Serializable {
+class MalformedNonPrimitiveFunction extends (String => Int) with 
Serializable {
+  override def apply(v1: String): Int = v1.toInt / 0
+}
+
+class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+  override def apply(v1: Int): Int = v1 / 0
+}
+  }
+
+  test("Use Utils.getSimpleName to avoid hitting Malformed class name") {

Review comment:
   yes, added.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


cloud-fan commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655963493


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF

2020-07-09 Thread GitBox


SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655964561


   **[Test build #125451 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125451/testReport)**
 for PR 29050 at commit 
[`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-09 Thread GitBox


SparkQA commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-655964549


   **[Test build #125452 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125452/testReport)**
 for PR 27983 at commit 
[`fcb0957`](https://github.com/apache/spark/commit/fcb09572d822e4491ee1bb8f0fd21ad76e3ec238).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-09 Thread GitBox


cloud-fan commented on pull request #29031:
URL: https://github.com/apache/spark/pull/29031#issuecomment-655965142


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   7   8   9   10   >