[GitHub] [spark] AmplabJenkins removed a comment on pull request #32411: [SPARK-28551][SQL]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32411:
URL: https://github.com/apache/spark/pull/32411#issuecomment-832430678


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138156/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832430676


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138151/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832430675


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138161/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832430679


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138150/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32407:
URL: https://github.com/apache/spark/pull/32407#issuecomment-832430680


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138157/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832430676


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138151/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832430675


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138161/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32411: [SPARK-28551][SQL]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32411:
URL: https://github.com/apache/spark/pull/32411#issuecomment-832430678


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138156/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32407:
URL: https://github.com/apache/spark/pull/32407#issuecomment-832430680


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138157/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832430679


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138150/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832328083


   **[Test build #138161 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138161/testReport)**
 for PR 32330 at commit 
[`4f0be6c`](https://github.com/apache/spark/commit/4f0be6c267abebb1fa3f3375678e1cd146f62bc9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


SparkQA commented on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832428019


   **[Test build #138161 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138161/testReport)**
 for PR 32330 at commit 
[`4f0be6c`](https://github.com/apache/spark/commit/4f0be6c267abebb1fa3f3375678e1cd146f62bc9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32407:
URL: https://github.com/apache/spark/pull/32407#issuecomment-832327983


   **[Test build #138157 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138157/testReport)**
 for PR 32407 at commit 
[`ca7ea47`](https://github.com/apache/spark/commit/ca7ea471d46b9304487099aca501090f3078a377).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-04 Thread GitBox


SparkQA commented on pull request #32407:
URL: https://github.com/apache/spark/pull/32407#issuecomment-832426232


   **[Test build #138157 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138157/testReport)**
 for PR 32407 at commit 
[`ca7ea47`](https://github.com/apache/spark/commit/ca7ea471d46b9304487099aca501090f3078a377).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832327900


   **[Test build #138150 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138150/testReport)**
 for PR 32425 at commit 
[`58923f4`](https://github.com/apache/spark/commit/58923f46dd5bb10a444f398c561e028513ca1689).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


SparkQA commented on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832425695


   **[Test build #138150 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138150/testReport)**
 for PR 32425 at commit 
[`58923f4`](https://github.com/apache/spark/commit/58923f46dd5bb10a444f398c561e028513ca1689).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `trait ExtractValue extends Expression `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32411: [SPARK-28551][SQL]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32411:
URL: https://github.com/apache/spark/pull/32411#issuecomment-832327918


   **[Test build #138156 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138156/testReport)**
 for PR 32411 at commit 
[`1a9a86f`](https://github.com/apache/spark/commit/1a9a86fc84dc8c209f6fd7cc398b2814d94d4dd2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32411: [SPARK-28551][SQL]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-04 Thread GitBox


SparkQA commented on pull request #32411:
URL: https://github.com/apache/spark/pull/32411#issuecomment-832416948


   **[Test build #138156 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138156/testReport)**
 for PR 32411 at commit 
[`1a9a86f`](https://github.com/apache/spark/commit/1a9a86fc84dc8c209f6fd7cc398b2814d94d4dd2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832327845


   **[Test build #138151 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138151/testReport)**
 for PR 32424 at commit 
[`0164e0f`](https://github.com/apache/spark/commit/0164e0f9fccfc1854eb48c940c7e43cc4c1567d2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


SparkQA commented on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832414359


   **[Test build #138151 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138151/testReport)**
 for PR 32424 at commit 
[`0164e0f`](https://github.com/apache/spark/commit/0164e0f9fccfc1854eb48c940c7e43cc4c1567d2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832413283


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138166/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832413283


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138166/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32431: [SPARK-35173][SQL][PYTHON] Add multiple columns adding support

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32431:
URL: https://github.com/apache/spark/pull/32431#issuecomment-832412930


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138147/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832412736


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138164/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32431: [SPARK-35173][SQL][PYTHON] Add multiple columns adding support

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32431:
URL: https://github.com/apache/spark/pull/32431#issuecomment-832412930


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138147/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832412736


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138164/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832378436


   **[Test build #138166 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138166/testReport)**
 for PR 32410 at commit 
[`a8306cb`](https://github.com/apache/spark/commit/a8306cb38b4a1d05dd724a855f53d1861d63bc3d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32430:
URL: https://github.com/apache/spark/pull/32430#issuecomment-832412488


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138148/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32430:
URL: https://github.com/apache/spark/pull/32430#issuecomment-832412488


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138148/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] attilapiros commented on pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI

2021-05-04 Thread GitBox


attilapiros commented on pull request #32436:
URL: https://github.com/apache/spark/pull/32436#issuecomment-832412428


   Can you suggest an event log we can use for checking the UI? If there is 
none checked in already as none is good enough (there is no interesting 
executor losses in the eventlog) then we should consider adding a new one. This 
would be helpful not only for the current reviewers but for future developers 
of this area could use it to check (at least by eye) their new changes: whether 
they have broken this feature or not.
   
   WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


SparkQA commented on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832412421


   **[Test build #138166 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138166/testReport)**
 for PR 32410 at commit 
[`a8306cb`](https://github.com/apache/spark/commit/a8306cb38b4a1d05dd724a855f53d1861d63bc3d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832328455


   **[Test build #138164 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138164/testReport)**
 for PR 29642 at commit 
[`f269f8d`](https://github.com/apache/spark/commit/f269f8d9d883e96182ff363276b589584a109aad).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32431: [SPARK-35173][SQL][PYTHON] Add multiple columns adding support

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32431:
URL: https://github.com/apache/spark/pull/32431#issuecomment-832327840


   **[Test build #138147 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138147/testReport)**
 for PR 32431 at commit 
[`ba7d4e0`](https://github.com/apache/spark/commit/ba7d4e0c1e16af44ee59bab1eeaabf150bcece72).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32420: [SPARK-35293][SQL][TESTS] Use the newer dsdgen for TPCDSQueryTestSuite

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32420:
URL: https://github.com/apache/spark/pull/32420#issuecomment-832412140


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138153/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32420: [SPARK-35293][SQL][TESTS] Use the newer dsdgen for TPCDSQueryTestSuite

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32420:
URL: https://github.com/apache/spark/pull/32420#issuecomment-832412140


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138153/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32431: [SPARK-35173][SQL][PYTHON] Add multiple columns adding support

2021-05-04 Thread GitBox


SparkQA commented on pull request #32431:
URL: https://github.com/apache/spark/pull/32431#issuecomment-832412104


   **[Test build #138147 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138147/testReport)**
 for PR 32431 at commit 
[`ba7d4e0`](https://github.com/apache/spark/commit/ba7d4e0c1e16af44ee59bab1eeaabf150bcece72).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32430:
URL: https://github.com/apache/spark/pull/32430#issuecomment-832327804


   **[Test build #138148 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138148/testReport)**
 for PR 32430 at commit 
[`2b7b6da`](https://github.com/apache/spark/commit/2b7b6daf98dfbebd1cc9236cc28214bed6620656).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


SparkQA commented on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832411899


   **[Test build #138164 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138164/testReport)**
 for PR 29642 at commit 
[`f269f8d`](https://github.com/apache/spark/commit/f269f8d9d883e96182ff363276b589584a109aad).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE

2021-05-04 Thread GitBox


SparkQA commented on pull request #32430:
URL: https://github.com/apache/spark/pull/32430#issuecomment-832411667


   **[Test build #138148 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138148/testReport)**
 for PR 32430 at commit 
[`2b7b6da`](https://github.com/apache/spark/commit/2b7b6daf98dfbebd1cc9236cc28214bed6620656).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32420: [SPARK-35293][SQL][TESTS] Use the newer dsdgen for TPCDSQueryTestSuite

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32420:
URL: https://github.com/apache/spark/pull/32420#issuecomment-832327926


   **[Test build #138153 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138153/testReport)**
 for PR 32420 at commit 
[`c21463f`](https://github.com/apache/spark/commit/c21463f7a41298b65d01fa16d4279f08afa9d879).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32420: [SPARK-35293][SQL][TESTS] Use the newer dsdgen for TPCDSQueryTestSuite

2021-05-04 Thread GitBox


SparkQA commented on pull request #32420:
URL: https://github.com/apache/spark/pull/32420#issuecomment-832411434


   **[Test build #138153 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138153/testReport)**
 for PR 32420 at commit 
[`c21463f`](https://github.com/apache/spark/commit/c21463f7a41298b65d01fa16d4279f08afa9d879).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832409564


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42685/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832409579


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32287:
URL: https://github.com/apache/spark/pull/32287#issuecomment-832409565


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42683/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE

2021-05-04 Thread GitBox


SparkQA commented on pull request #32430:
URL: https://github.com/apache/spark/pull/32430#issuecomment-832409814


   **[Test build #138167 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138167/testReport)**
 for PR 32430 at commit 
[`788e714`](https://github.com/apache/spark/commit/788e7144df35fb040144768dadf644dbefe0e241).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] attilapiros commented on a change in pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI

2021-05-04 Thread GitBox


attilapiros commented on a change in pull request #32436:
URL: https://github.com/apache/spark/pull/32436#discussion_r626243339



##
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
##
@@ -217,14 +217,42 @@ private[spark] class ExecutorPodsLifecycleManager(
 ExecutorExited(exitCode, exitCausedByApp, exitMessage)
   }
 
+  // A utility function to try and help people figure out whats gone wrong 
faster.
+  private def describeExitCode(code: Int): String = {

Review comment:
   What about moving this into `object ExecutorPodsLifecycleManager` and 
making it accessible for the `ExecutorPodsLifecycleManagerSuite` to avoid the 
copy-paste?

##
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
##
@@ -25,6 +25,14 @@ function getThreadDumpEnabled() {
 return threadDumpEnabled;
 }
 
+function formatLossReason(status, type, row) {

Review comment:
   I see how you came up with the function arguments :)
   
   The first argument must be the data which is selected from the whole REST 
response by the `data` field:
   
https://github.com/apache/spark/blob/433ee83861a0a3aa7aea3c05d02fc9e70579ce76/core/src/main/resources/org/apache/spark/ui/static/executorspage.js#L548
   
   So please rename`status` to `removeReason` as we should format remove 
reasons.
   
   And I guess its value was always `null`. This is why you used the `row` to 
access it. The root cause of this problem is the selection itself was wrong. 
   
   So instead of 
   ```
data: 'executorLossReason',  
   ```
   it must be:
   ```
data: 'removeReason', 
```

And after this you can use the `removeReason` argument of this 
`formatLossReason` function to get the value.

##
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
##
@@ -217,14 +217,42 @@ private[spark] class ExecutorPodsLifecycleManager(
 ExecutorExited(exitCode, exitCausedByApp, exitMessage)
   }
 
+  // A utility function to try and help people figure out whats gone wrong 
faster.
+  private def describeExitCode(code: Int): String = {
+val humanStr = code match {
+  case 0 => "(success)"
+  case 1 => "(generic, look at logs to clarify)"
+  case 42 => "(douglas adams)"

Review comment:
    
   Nit: (douglas adams) => (Douglas Adams) especially as Uncaught is 
capitalised in "(Uncaught exception)".
   And the latter is more like villain in our story not a hero :)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832409579


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


SparkQA commented on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832409563


   Kubernetes integration test status failure
   URL: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32287:
URL: https://github.com/apache/spark/pull/32287#issuecomment-832409565


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42683/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832409564


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42685/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #29642: [SPARK-32792][SQL] Improve Parquet In filter pushdown

2021-05-04 Thread GitBox


SparkQA commented on pull request #29642:
URL: https://github.com/apache/spark/pull/29642#issuecomment-832409169






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-04 Thread GitBox


SparkQA commented on pull request #32410:
URL: https://github.com/apache/spark/pull/32410#issuecomment-832408081


   Kubernetes integration test starting
   URL: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sigmod edited a comment on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


sigmod edited a comment on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832403319


   > @sigmod Does this include all the analyzer rules?
   
   It includes most rules in fixed point batches in those places (because rule 
id only helps rules that invoke multiple times, e.g., in a fixed point batch):
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L255-L292
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L239-L243
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L247-L248
   
   Two rules are currently not included:
   - TypeCoercionRule which currently does a hand-written recursion instead of 
calling resolve/transform;
   - CTESubstitution which has a slightly complex logic with multiple transform 
calls.
   
   I plan to address them in subsequent PRs.
   
   Three rules that rely on potentially changing, external states currently are 
not included neither (although they are probably fine for the current use 
cases):
   - ResolveTableValuedFunctions(v1SessionCatalog)
   - ResolveNamespace(catalogManager)
   - ResolveCatalogs(catalogManager)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sigmod edited a comment on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


sigmod edited a comment on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832403319


   > @sigmod Does this include all the analyzer rules?
   
   It includes most rules in fixed point batches in those places (because rule 
id only helps rules that invoke multiple times, e.g., in a fixed point batch):
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L255-L292
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L239-L243
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L247-L248
   
   Two rules are currently not included:
   - TypeCoercionRule which currently does a hand-written recursion;
   - CTESubstitution which has a slightly complex logic with multiple transform 
calls.
   
   I plan to address them in subsequent PRs.
   
   Three rules that rely on potentially changing, external states currently are 
not included neither (although they are probably fine for the current use 
cases):
   - ResolveTableValuedFunctions(v1SessionCatalog)
   - ResolveNamespace(catalogManager)
   - ResolveCatalogs(catalogManager)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sigmod edited a comment on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


sigmod edited a comment on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832403319


   > @sigmod Does this include all the analyzer rules?
   
   It includes most rules in fixed point batches in those places (because rule 
id only helps rules that invoke multiple times, e.g., in a fixed point batch):
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L255-L292
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L239-L243
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L247-L248
   
   Two rules are currently not included:
   - TypeCoercionRule which currently does a hand-written recursion;
   - CTESubstitution which has a slightly complex logic with multiple transform 
calls.
   
   I plan to address them in subsequent PRs.
   
   Three rules that rely on potentially changing, external states currently are 
not included neither:
   - ResolveTableValuedFunctions(v1SessionCatalog)
   - ResolveNamespace(catalogManager)
   - ResolveCatalogs(catalogManager)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] c21 commented on a change in pull request #32430: [SPARK-35133][SQL] Explain codegen works with AQE

2021-05-04 Thread GitBox


c21 commented on a change in pull request #32430:
URL: https://github.com/apache/spark/pull/32430#discussion_r626246014



##
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##
@@ -197,7 +198,14 @@ class QueryExecution(
 queryExecution.toString(maxFields, append)
   case CodegenMode =>
 try {
-  org.apache.spark.sql.execution.debug.writeCodegen(append, 
queryExecution.executedPlan)
+  queryExecution.executedPlan match {

Review comment:
   @maropu - updated, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sigmod edited a comment on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


sigmod edited a comment on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832403319


   > @sigmod Does this include all the analyzer rules?
   
   It includes most rules in fixed point batches in those places (because rule 
id only helps rules that invoke multiple times, e.g., in a fixed point batch):
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L255-L292
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L239-L243
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L247-L248
   
   Two rules are currently not included:
   - TypeCoercionRule which currently does a hand-written recursion;
   - CTESubstitution which has a slightly complex logic with multiple transform 
calls.
   I plan to address them in subsequent PRs.
   
   Three rules that rely on potentially changing, external states currently are 
not included neither:
   - ResolveTableValuedFunctions(v1SessionCatalog)
   - ResolveNamespace(catalogManager)
   - ResolveCatalogs(catalogManager)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] vinodkc commented on pull request #32411: [SPARK-28551][SQL]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-04 Thread GitBox


vinodkc commented on pull request #32411:
URL: https://github.com/apache/spark/pull/32411#issuecomment-832403467


   A gentle ping @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sigmod commented on pull request #32425: [SPARK-35155][SQL] Add rule id pruning to Analyzer rules

2021-05-04 Thread GitBox


sigmod commented on pull request #32425:
URL: https://github.com/apache/spark/pull/32425#issuecomment-832403319


   > @sigmod Does this include all the analyzer rules?
   
   It includes most rules in fixed point batches in those places (because rule 
id only helps rules that invoke multiple times, e.g., in a fixed point batch):
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L255-L292
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L239-L243
   
https://github.com/apache/spark/blob/86d3bb5f7df917f5f62076d4d3fdea15e3ccea71/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L247-L248
   
   Two rules are currently not included:
   - TypeCoercionRule which currently does a hand-written recursion;
   - CTESubstitution which has a slightly complex logic with multiple transform 
calls.
   
   I plan to address them in subsequent PRs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-04 Thread GitBox


SparkQA commented on pull request #32287:
URL: https://github.com/apache/spark/pull/32287#issuecomment-832399832


   Kubernetes integration test status failure
   URL: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42683/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

2021-05-04 Thread GitBox


SparkQA commented on pull request #32287:
URL: https://github.com/apache/spark/pull/32287#issuecomment-832397852


   Kubernetes integration test starting
   URL: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42683/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832394784


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42686/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #31944: [SPARK-34854][SQL][SS] Expose source metrics via progress report and add Kafka use-case to report delay.

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #31944:
URL: https://github.com/apache/spark/pull/31944#issuecomment-832394666


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42684/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832394784


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42686/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #31944: [SPARK-34854][SQL][SS] Expose source metrics via progress report and add Kafka use-case to report delay.

2021-05-04 Thread GitBox


SparkQA commented on pull request #31944:
URL: https://github.com/apache/spark/pull/31944#issuecomment-832394646






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #31944: [SPARK-34854][SQL][SS] Expose source metrics via progress report and add Kafka use-case to report delay.

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #31944:
URL: https://github.com/apache/spark/pull/31944#issuecomment-832394666


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42684/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32388: [SPARK-35258][SHUFFLE][YARN] Add new metrics to ExternalShuffleService for better monitoring

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32388:
URL: https://github.com/apache/spark/pull/32388#issuecomment-832394429






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32420: [SPARK-35293][SQL][TESTS] Use the newer dsdgen for TPCDSQueryTestSuite

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32420:
URL: https://github.com/apache/spark/pull/32420#issuecomment-832394436


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42674/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32407:
URL: https://github.com/apache/spark/pull/32407#issuecomment-832394428


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42678/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832394407


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42682/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32440: [SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32440:
URL: https://github.com/apache/spark/pull/32440#issuecomment-832394433


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138143/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32436:
URL: https://github.com/apache/spark/pull/32436#issuecomment-832394432


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138145/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32413:
URL: https://github.com/apache/spark/pull/32413#issuecomment-832394427


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42676/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32354: [SPARK-35232][SQL] Nested column pruning should retain column metadata

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32354:
URL: https://github.com/apache/spark/pull/32354#issuecomment-832394425


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42681/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-04 Thread GitBox


AmplabJenkins removed a comment on pull request #32415:
URL: https://github.com/apache/spark/pull/32415#issuecomment-832394426


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138154/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32354: [SPARK-35232][SQL] Nested column pruning should retain column metadata

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32354:
URL: https://github.com/apache/spark/pull/32354#issuecomment-832394425


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42681/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32407:
URL: https://github.com/apache/spark/pull/32407#issuecomment-832394428


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42678/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32440: [SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32440:
URL: https://github.com/apache/spark/pull/32440#issuecomment-832394433


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138143/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32420: [SPARK-35293][SQL][TESTS] Use the newer dsdgen for TPCDSQueryTestSuite

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32420:
URL: https://github.com/apache/spark/pull/32420#issuecomment-832394436


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42674/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32436:
URL: https://github.com/apache/spark/pull/32436#issuecomment-832394432


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138145/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832394407


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42682/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32388: [SPARK-35258][SHUFFLE][YARN] Add new metrics to ExternalShuffleService for better monitoring

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32388:
URL: https://github.com/apache/spark/pull/32388#issuecomment-832394429






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32413:
URL: https://github.com/apache/spark/pull/32413#issuecomment-832394427


   
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42676/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-04 Thread GitBox


AmplabJenkins commented on pull request #32415:
URL: https://github.com/apache/spark/pull/32415#issuecomment-832394426


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138154/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32330: [SPARK-35215][SQL] Update custom metric per certain rows and at the end of the task

2021-05-04 Thread GitBox


SparkQA commented on pull request #32330:
URL: https://github.com/apache/spark/pull/32330#issuecomment-832394359






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32415:
URL: https://github.com/apache/spark/pull/32415#issuecomment-832327917


   **[Test build #138154 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138154/testReport)**
 for PR 32415 at commit 
[`48acb9f`](https://github.com/apache/spark/commit/48acb9fa6e24535f16a73ec38d3477ef49acdd99).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-04 Thread GitBox


SparkQA commented on pull request #32415:
URL: https://github.com/apache/spark/pull/32415#issuecomment-832393495


   **[Test build #138154 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138154/testReport)**
 for PR 32415 at commit 
[`48acb9f`](https://github.com/apache/spark/commit/48acb9fa6e24535f16a73ec38d3477ef49acdd99).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32440: [SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32440:
URL: https://github.com/apache/spark/pull/32440#issuecomment-832327761


   **[Test build #138143 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138143/testReport)**
 for PR 32440 at commit 
[`f7680a4`](https://github.com/apache/spark/commit/f7680a460f8058b4d1b3ab39eef61c0134d9abe2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


maropu commented on pull request #32424:
URL: https://github.com/apache/spark/pull/32424#issuecomment-832393349


   GA passed. Merged to master/3.1/3.0. Thank you for the review, @ueshin ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32440: [SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT

2021-05-04 Thread GitBox


SparkQA commented on pull request #32440:
URL: https://github.com/apache/spark/pull/32440#issuecomment-832393290


   **[Test build #138143 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138143/testReport)**
 for PR 32440 at commit 
[`f7680a4`](https://github.com/apache/spark/commit/f7680a460f8058b4d1b3ab39eef61c0134d9abe2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu closed pull request #32424: [SPARK-34794][SQL] Fix lambda variable name issues in nested DataFrame functions

2021-05-04 Thread GitBox


maropu closed pull request #32424:
URL: https://github.com/apache/spark/pull/32424


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu closed pull request #31887: [SPARK-34794][SQL] Fix nested transform issue

2021-05-04 Thread GitBox


maropu closed pull request #31887:
URL: https://github.com/apache/spark/pull/31887


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32354: [SPARK-35232][SQL] Nested column pruning should retain column metadata

2021-05-04 Thread GitBox


SparkQA commented on pull request #32354:
URL: https://github.com/apache/spark/pull/32354#issuecomment-832393163






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32388: [SPARK-35258][SHUFFLE][YARN] Add new metrics to ExternalShuffleService for better monitoring

2021-05-04 Thread GitBox


SparkQA commented on pull request #32388:
URL: https://github.com/apache/spark/pull/32388#issuecomment-832392585






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32388: [SPARK-35258][SHUFFLE][YARN] Add new metrics to ExternalShuffleService for better monitoring

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32388:
URL: https://github.com/apache/spark/pull/32388#issuecomment-832328008


   **[Test build #138159 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138159/testReport)**
 for PR 32388 at commit 
[`d519fb9`](https://github.com/apache/spark/commit/d519fb9e44068e0f26f59fc4cc9e19c43c863f7a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32388: [SPARK-35258][SHUFFLE][YARN] Add new metrics to ExternalShuffleService for better monitoring

2021-05-04 Thread GitBox


SparkQA commented on pull request #32388:
URL: https://github.com/apache/spark/pull/32388#issuecomment-832390992


   **[Test build #138159 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138159/testReport)**
 for PR 32388 at commit 
[`d519fb9`](https://github.com/apache/spark/commit/d519fb9e44068e0f26f59fc4cc9e19c43c863f7a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] viirya commented on pull request #32404: [SPARK-35278][SQL] Invoke should find the method with correct number of parameters

2021-05-04 Thread GitBox


viirya commented on pull request #32404:
URL: https://github.com/apache/spark/pull/32404#issuecomment-832390017


   @cloud-fan Just to confirm. So you mean we only allow `Invoke` to run the 
method with exact parameter type matches, right?
   
   For example, calling a method `func(input: Object)` with argument `Tuple2` 
will be disallowed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI

2021-05-04 Thread GitBox


SparkQA removed a comment on pull request #32436:
URL: https://github.com/apache/spark/pull/32436#issuecomment-832327791


   **[Test build #138145 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138145/testReport)**
 for PR 32436 at commit 
[`433ee83`](https://github.com/apache/spark/commit/433ee83861a0a3aa7aea3c05d02fc9e70579ce76).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32436: [SPARK-34764][CORE][K8S][UI] Propagate reason for exec loss to Web UI

2021-05-04 Thread GitBox


SparkQA commented on pull request #32436:
URL: https://github.com/apache/spark/pull/32436#issuecomment-832389203


   **[Test build #138145 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138145/testReport)**
 for PR 32436 at commit 
[`433ee83`](https://github.com/apache/spark/commit/433ee83861a0a3aa7aea3c05d02fc9e70579ce76).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-04 Thread GitBox


SparkQA commented on pull request #32413:
URL: https://github.com/apache/spark/pull/32413#issuecomment-832388158


   Kubernetes integration test status failure
   URL: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42676/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   >