Re: [PR] [WIP][SPARK-4836][UI] Show all stage attempts on UI's job details page [spark]
github-actions[bot] commented on PR #43640: URL: https://github.com/apache/spark/pull/43640#issuecomment-1937366940 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-46812][SQL][PYTHON] Make mapInPandas / mapInArrow support ResourceProfile [spark]
wbo4958 commented on PR #44852: URL: https://github.com/apache/spark/pull/44852#issuecomment-1937357491 Hi @HyukjinKwon could you help merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44445][BUILD][TESTS] Upgrade to `htmlunit` 3.10.0 and `htmlunit3-driver` 4.17.0 [spark]
dongjoon-hyun commented on PR #45079: URL: https://github.com/apache/spark/pull/45079#issuecomment-1937054690 Thank you, @rbri and @bjornjorgensen . After merging #45080, I'll recheck this PR based on your comments. A CVE on test dependency is only a nice-to-have item. FYI, I'm currently reviewing and checking all reported items in the following GitHub link for Apache Spark 4.0.0. However, I don't think the list is correct absolutely. - https://github.com/apache/spark/security/dependabot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44445][BUILD][TESTS] Upgrade to `htmlunit` 3.10.0 and `htmlunit3-driver` 4.17.0 [spark]
bjornjorgensen commented on PR #45079: URL: https://github.com/apache/spark/pull/45079#issuecomment-1937012553 this is for [CVE-2023-26119](https://nvd.nist.gov/vuln/detail/CVE-2023-26119) [9.8 CRITICAL](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?name=CVE-2023-26119=AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H=3.1=Snyk) Do we report tests dependencies like this one in SBOM? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-44445][BUILD][TESTS] Upgrade to `htmlunit` 3.10.0 and `htmlunit3-driver` 4.17.0 [spark]
rbri commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1485042077
##
pom.xml:
##
@@ -710,19 +710,19 @@
org.seleniumhq.selenium
-htmlunit-driver
-${htmlunit-driver.version}
+htmlunit3-driver
+${htmlunit3-driver.version}
test
-net.sourceforge.htmlunit
+org.htmlunit
htmlunit
${htmlunit.version}
test
-net.sourceforge.htmlunit
+org.htmlunit
htmlunit-core-js
${htmlunit.version}
test
Review Comment:
the xml-apis dependency is no longer required by html unit and can go away -
removing this solves also some CVE warnings
##
pom.xml:
##
@@ -710,19 +710,19 @@
org.seleniumhq.selenium
-htmlunit-driver
-${htmlunit-driver.version}
+htmlunit3-driver
+${htmlunit3-driver.version}
test
Review Comment:
this can be removed as it is a dependency of the htmlunit3-driver
##
pom.xml:
##
@@ -710,19 +710,19 @@
Review Comment:
I think this is the only dependency you need
##
pom.xml:
##
@@ -710,19 +710,19 @@
org.seleniumhq.selenium
-htmlunit-driver
-${htmlunit-driver.version}
+htmlunit3-driver
+${htmlunit3-driver.version}
test
-net.sourceforge.htmlunit
+org.htmlunit
htmlunit
${htmlunit.version}
test
-net.sourceforge.htmlunit
Review Comment:
this can be removed as it is a dependency of the htmlunit3-driver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45762][CORE] Support shuffle managers defined in user jars by changing startup order [spark]
mridulm commented on PR #43627: URL: https://github.com/apache/spark/pull/43627#issuecomment-1936933162 Thanks for understanding @dongjoon-hyun ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
