[GitHub] spark pull request: improved error message for java type inference...

2016-01-21 Thread andygrove
GitHub user andygrove opened a pull request:

https://github.com/apache/spark/pull/10865

improved error message for java type inference failure



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/codefutures/spark SPARK-12932

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10865


commit f11f1c738771339e4031c313f759fa24f3b3
Author: Andy Grove <andygrov...@gmail.com>
Date:   2016-01-21T15:33:22Z

improved error message




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

2016-01-21 Thread andygrove
Github user andygrove commented on a diff in the pull request:

https://github.com/apache/spark/pull/10865#discussion_r50498238
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
 ---
@@ -406,7 +406,7 @@ object JavaTypeInference {
   expressions.Literal(fieldName) :: extractorFor(fieldValue, 
fieldType) :: Nil
 })
   } else {
-throw new UnsupportedOperationException(s"no encoder found for 
${other.getName}")
+throw new UnsupportedOperationException(s"Cannot infer type 
for Java class ${other.getName} because it is not bean-compliant")
--- End diff --

Thanks. I have pushed a fix.

On Thu, Jan 21, 2016 at 8:12 PM, Reynold Xin <notificati...@github.com>
wrote:

> In
> 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
> <https://github.com/apache/spark/pull/10865#discussion_r50498058>:
>
> > @@ -406,7 +406,7 @@ object JavaTypeInference {
> >expressions.Literal(fieldName) :: 
extractorFor(fieldValue, fieldType) :: Nil
> >  })
> >} else {
> > -throw new UnsupportedOperationException(s"no encoder found 
for ${other.getName}")
> > +throw new UnsupportedOperationException(s"Cannot infer 
type for Java class ${other.getName} because it is not bean-compliant")
>
> this needs to be less than 100 chars wide to fit spark's style guide
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/10865/files#r50498058>.
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org