[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread cluo512 
GitHub user cluo512 opened a pull request:

https://github.com/apache/spark/pull/21717

[SPARK-24743] [Examples]Update the JavaDirectKafkaWordCount example to 
support the new API of kafka

## What changes were proposed in this pull request?

Add some required configs for Kafka consumer in JavaDirectKafkaWordCount 
class.

## How was this patch tested?

Manual tests on Local mode.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cluo512/spark 
SPARK-24743-update-JavaDirectKafkaWordCount

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/21717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21717


commit 72ffc9259db3285960898a4f6b8444c1c8dddcf1
Author: cluo <0512lc@...>
Date:   2018-07-05T08:30:31Z

Update the JavaDirectKafkaWordCount example to support the new API of Kafka




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21717: [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCo...

2018-07-05 Thread cluo512 
Github user cluo512 commented on the issue:

https://github.com/apache/spark/pull/21717
  
@srowen 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread cluo512 
Github user cluo512 commented on a diff in the pull request:

https://github.com/apache/spark/pull/21717#discussion_r200306144
  
--- Diff: 
examples/src/main/java/org/apache/spark/examples/streaming/JavaDirectKafkaWordCount.java
 ---
@@ -50,25 +52,30 @@
   private static final Pattern SPACE = Pattern.compile(" ");
 
   public static void main(String[] args) throws Exception {
--- End diff --

viirya, thank you for your nice review. 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org