[GitHub] spark issue #17693: [SPARK-16548][SQL] Inconsistent error handling in JSON p...

2017-04-21 Thread ewasserman
Github user ewasserman commented on the issue:

https://github.com/apache/spark/pull/17693
  
Reverted from use of  toString on the 
org.apache.spark.unsafe.types.UTF8String by running the byte array through a 
java.io.Reader. This still fixes the bug and is also more efficient on the JSON 
parser side so it is a net performance win as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #17693: [SPARK-20314][SQL] Inconsistent error handling in...

2017-04-19 Thread ewasserman
GitHub user ewasserman opened a pull request:

https://github.com/apache/spark/pull/17693

[SPARK-20314][SQL] Inconsistent error handling in JSON parsing SQL functions

## What changes were proposed in this pull request?

change to using Jackson's `com.fasterxml.jackson.core.JsonFactory`

public JsonParser createParser(String content)

## How was this patch tested?

existing unit tests

Please review http://spark.apache.org/contributing.html before opening a 
pull request.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ewasserman/spark SPARK-20314

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/17693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17693


commit 8ef9b6a6718a5c8ee7d215d625a86c370697afd0
Author: Eric Wasserman <er...@sgn.com>
Date:   2017-04-19T23:53:56Z

fix SPARK-20314




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org