GitHub user gvr opened a pull request:
https://github.com/apache/spark/pull/21806
[SPARK-24846][SQL] Made hashCode ExprId independent of jvmId
## What changes were proposed in this pull request?
Made ExprId hashCode independent of jvmId to make canonicalization
independent of JVM
(Please fill in changes proposed in this fix)
Override hashCode (and necessarily also equality) to depend on id only
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Created a unit test ExprIdSuite
Ran all unit tests of sql/catalyst
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gvr/spark spark24846-canonicalization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21806
commit 68d6f19ad9baf78f7ffba803e7709a509063d1ff
Author: Ger van Rossum
Date: 2018-07-18T16:15:42Z
[SPARK-24846][SQL] Made hashCode ExprId independent of jvmId
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org