[GitHub] spark pull request #22420: SPARK-25429

2018-09-14 Thread hellodengfei
GitHub user hellodengfei opened a pull request:

https://github.com/apache/spark/pull/22420

SPARK-25429

Use Set improve SparkListenerBus efficient

## What changes were proposed in this pull request?

Use Set instead of Array to provide lookup performance: Set#contains

## How was this patch tested?

The original test case can guarantee

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hellodengfei/spark branch-2.3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22420


commit e8a5bae5283453b1ee7ff595d140112141dd1016
Author: daniedeng(邓飞) 
Date:   2018-09-14T08:58:52Z

SPARK-25429
Use Set improve SparkListenerBus efficient




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings

2018-02-06 Thread hellodengfei
Github user hellodengfei commented on the issue:

https://github.com/apache/spark/pull/20304
  
Sorry, it's  too late for UT.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #20304: [SPARK-23139]Read eventLog file with mixed encodi...

2018-01-17 Thread hellodengfei
GitHub user hellodengfei opened a pull request:

https://github.com/apache/spark/pull/20304

[SPARK-23139]Read eventLog file with mixed encodings

## What changes were proposed in this pull request?

EventLog may contain mixed encodings such as custom exception message, but 
caused to replay failure 

## How was this patch tested?

manual test


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hellodengfei/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20304


commit 4e67ab96027f5de942c25eb14669d5aedae80204
Author: daniedeng(邓飞) <daniedeng@...>
Date:   2018-01-17T12:32:10Z

Read eventLog file with mixed encodings




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org