[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Github user josiahsams closed the pull request at: https://github.com/apache/spark/pull/8847 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Github user josiahsams commented on the pull request: https://github.com/apache/spark/pull/8847#issuecomment-142240785 JIRA SPARK-9284 has already addressed the issue by including the "classes" directory along with the "test-classes" directory while running tests. So I will be canceling this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
Github user josiahsams commented on the pull request: https://github.com/apache/spark/pull/8847#issuecomment-141949246 We primarily use maven for building Spark. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10725] [TEST] Add dependencies required...
GitHub user josiahsams opened a pull request: https://github.com/apache/spark/pull/8847 [SPARK-10725] [TEST] Add dependencies required by HiveSparkSubmitSuite HiveSparkSubmitSuite under sql/hive project fails with NoClassDefFoundError as follows, Exception in thread "main" java.lang.NoClassDefFoundError: org.apache.spark.sql.hive.test.TestHiveContext TestHiveContext class is part of sql_hive jar. Since this jar is not part of the list of dependencies we encounter this issue. So by adding the respective jar to the dependency list we should be able to successfully run all the tests under HiveSparkSubmitSuite . You can merge this pull request into a Git repository by running: $ git pull https://github.com/ibmsoe/spark SPARK-10725 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8847.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8847 commit e81f4f15b3283a1859acc0f6ce0887ff99b6d4ba Author: Josiah Samuel Date: 2015-09-21T10:43:33Z [SPARK-10725] [TEST] Add dependencies required by HiveSparkSubmitSuite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]disable sort in HistoryServ...
Github user josiahsams commented on the pull request: https://github.com/apache/spark/pull/8506#issuecomment-141035680 Title & Description changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...
Github user josiahsams commented on the pull request: https://github.com/apache/spark/pull/8506#issuecomment-140697439 I pushed a wrong commit and I'm reopening the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...
GitHub user josiahsams reopened a pull request: https://github.com/apache/spark/pull/8506 [SPARK-10172][core]Fix for HistoryServer webUI mess up during sorting This pull request is to address the JIRA SPARK-10172 (History Server web UI gets messed up when sorting on any column). The fix will avoid the use of rowspan during table creation in the web UI, when there are multiple attempts for a job. By avoiding the rowspan, the table won't get messed up during the column sort. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ibmsoe/spark SPARK-10172 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8506.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8506 commit 70eeabd74e211aa11c9188e350e24e6ba21cb66e Author: Josiah Samuel Date: 2015-09-16T10:18:15Z [SPARK-10172] [core]disable sort in HistoryServer webUI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...
Github user josiahsams closed the pull request at: https://github.com/apache/spark/pull/8506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...
Github user josiahsams commented on the pull request: https://github.com/apache/spark/pull/8506#issuecomment-140344311 @vanzin, I tried tablesorter jquery plugin and figured out there are no way to sort the childrows out of the box. Still exploring all the customization. In this approach, I'm suspecting lot of code changes and new scripts and css additions as the table creation in Spark UI is done in a generic way. But we need to take a decision whether its worth putting that much effort for this issue (or) simply make the table non-sortable(only in case of multiple attempts) as suggested by you. Waiting for your reply for this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...
Github user josiahsams commented on the pull request: https://github.com/apache/spark/pull/8506#issuecomment-140018832 @vanzin , As you rightly pointed out, I have removed the row level grouping (rowspan) based on the Attempt ID, as the current javascript library used for sorting table "sorttable.js" messes up the table data during sorting. For that matter, as far as I know, no stable table sort logic out there that can support rowspan. But we can definitely try out workarounds like, creating inner tables inside the cells for each column and make that table data non-sortable. This will call for more code changes but will result in having more non-sortable fields. So in order to keep things simple, I removed "rowspan" from the equation, and made the "App ID" field to show values(links will be different based on the attempt ID) for every attempt made. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10172][core]Fix for HistoryServer webUI...
GitHub user josiahsams opened a pull request: https://github.com/apache/spark/pull/8506 [SPARK-10172][core]Fix for HistoryServer webUI mess up during sorting This pull request is to address the JIRA SPARK-10172 (History Server web UI gets messed up when sorting on any column). The fix will avoid the use of rowspan during table creation in the web UI, when there are multiple attempts for a job. By avoiding the rowspan, the table won't get messed up during the column sort. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ibmsoe/spark SPARK-10172 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8506.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8506 commit 521f1d6130261e84ba37d6c96f459f6219a3973d Author: Josiah Samuel Date: 2015-08-26T11:08:46Z [SPARK-10172][core]Fix for HistoryServer webUI mess up during sorting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
