[GitHub] spark pull request: [SPARK-15197][WIP][Docs] Added Scaladoc for co...
Github user ntietz commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-218897047 @srowen I updated what I am able to. How does it look to you? I haven't addressed the relativeSD explanations, because I don't really understand it well enough to contribute that. I think I hit the other major points. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15197][WIP][Docs] Added Scaladoc for co...
Github user ntietz commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-218129733 @srowen For sure, I'm going to work on it this week --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15197][WIP][Docs] Added Scaladoc for co...
Github user ntietz commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-217598813 I created JIRA SPARK-15197. I think that I covered the expanded scope in there, but if I goofed and missed something feel free to update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Docs] Added Scaladoc for countApprox and coun...
Github user ntietz commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-217547803 I'll dig deeper into the documentation and will update! I've got the bandwidth to work on this. I'll add a JIRA for it tonight and work on it over the course of the week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Docs] Added Scaladoc for countApprox and coun...
Github user ntietz commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-217496563 I've added documentation for the Java version. Anything else that should go in with this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Docs] Added Scaladoc for countApprox and coun...
Github user ntietz commented on the pull request: https://github.com/apache/spark/pull/12955#issuecomment-217467133 Good call, I will add it to the Java version as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Docs] Added Scaladoc for countApprox and coun...
GitHub user ntietz opened a pull request: https://github.com/apache/spark/pull/12955 [Docs] Added Scaladoc for countApprox and countByValueApprox parameters This pull request simply adds Scaladoc documentation of the parameters for countApprox and countByValueApprox. This is an important documentation change, as it clarifies what should be passed in for the timeout. Without units, this was previously unclear. I did not open a JIRA ticket per my understanding of the project contribution guidelines; as they state, the description in the ticket would be essentially just what is in the PR. If I should open one, let me know and I will do so. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ntietz/spark rdd-countapprox-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12955.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12955 commit a28014dc45981b79df6e6c18f473565eb740638c Author: Nicholas Tietz <nicholas.ti...@crosschx.com> Date: 2016-05-06T14:07:21Z Added Scaladoc for countApprox and countByValueApprox --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
