[GitHub] spark issue #14805: [MINOR][DOCS] Fix minor typos in python example code

[silentsokolov]

Github user silentsokolov commented on the issue:

https://github.com/apache/spark/pull/14805
  
I returned the spaces


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14805: [MINOR][DOCS] Fix minor typos in python example c...

[silentsokolov]

Github user silentsokolov commented on a diff in the pull request:

https://github.com/apache/spark/pull/14805#discussion_r76384801
  
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -487,11 +487,11 @@ Dataset[Row] csvDF = spark
 spark = SparkSession. ...
 
 # Read text from socket 
-socketDF = spark \
-.readStream()  \
-.format("socket") \
-.option("host", "localhost") \
-.option("port", ) \
+socketDF = spark\
--- End diff --

@srowen, there is no clear definition of it.


https://docs.python.org/2/reference/lexical_analysis.html#explicit-line-joining
https://www.python.org/dev/peps/pep-0008/#maximum-line-length

I use:
```python
# with space
if 1900 < year < 2100 and 1 <= month <= 12:
return 1

if 1900 < year < 2100 \
and 1 <= month <= 12:
return 1

# without space
s = 'Hello world'.lower().split()

s = 'Hello world'.lower()\
.split()
```

This makes the code more readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #14805: [MINOR][DOCS] Fix minor typos in python example code

[silentsokolov]

Github user silentsokolov commented on the issue:

https://github.com/apache/spark/pull/14805
  
I looked through all the python code examples, fixed typos and formatting


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #14805: [MINOR][DOCS] Fix minor typos in python example c...

[silentsokolov]

GitHub user silentsokolov opened a pull request:

https://github.com/apache/spark/pull/14805

[MINOR][DOCS] Fix minor typos in python example code

## What changes were proposed in this pull request?

Fix minor typos python example code in streaming programming guide 


## How was this patch tested?

N/A




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/silentsokolov/spark fix-typos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/14805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14805


commit 92310d91fa0c981d122a1a684a1dfd430f42db5e
Author: Dmitriy Sokolov <silentsoko...@gmail.com>
Date:   2016-08-25T08:57:03Z

Fix minor typos in python example code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org