[GitHub] spark pull request: [SPARK-5466] Add explicit guava dependencies w...
Github user tsingfu commented on the pull request: https://github.com/apache/spark/pull/4272#issuecomment-92713227 @WangTaoTheTonic Hi, today I got the error when I did a new clean build in updated master branch as follows: ``` cd spark //in master branch, update my local master from remote git pull mvn clean mvn generate-sources mvn package -Dhadoop.version=2.5.0-cdh5.3.1 -DskipTests -Pyarn -Phive-0.13.1 -Phive-thriftserver -Pspark-ganglia-lgpl ``` then the error occured. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5466] Add explicit guava dependencies w...
Github user tsingfu commented on the pull request: https://github.com/apache/spark/pull/4272#issuecomment-92579447 @vanzin , today I found *sql/hive-thriftserver* also needs explicit guava dependencies. But in `sql/hive-thriftserver/pom.xml` the scope of `com.google.guava.guava` is `runtime`, and this causes build error as same as in [SPARK-5466](https://issues.apache.org/jira/browse/SPARK-5466). my test: I try the scope with `compile`, build works fine. vi sql/hive-thriftserver/pom.xml ``` dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId !-- scoperuntime/scope -- /dependency ``` cc @pwendell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6105] enhance spark-ganglia to support ...
GitHub user tsingfu opened a pull request: https://github.com/apache/spark/pull/4849 [SPARK-6105] enhance spark-ganglia to support redundant gmond addresses ... This *PR* is for preventing spark-GangliaSink from single point of failure in unicast mode configuration. For details, please refer relatived JIRA: [enhance spark-ganglia to support redundant gmond addresses setting in ganglia unicast mode](https://issues.apache.org/jira/browse/SPARK-6105) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tsingfu/spark SPARK-6105 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/4849.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4849 commit 48efec93614432c34457d315f5855d200f7d1616 Author: tsingfu yangfuq...@gmail.com Date: 2015-03-02T07:55:59Z [SPARK-6105] enhance spark-ganglia to support redundant gmond addresses setting in ganglia unicast mode; and modify DRIVER_IDENTIFIER in SparkContext.scala according PR #4209 which is closed and not merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX] Rename the identifier of driver from ...
Github user tsingfu commented on the pull request: https://github.com/apache/spark/pull/4245#issuecomment-76655144 @sarutak I found #4209 has not solved the problem invalid metric name with driver which introduced from #3812. and I have a question: Is there difference between setting DRIVER_IDENTIFIER to driver and driver? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4528][SQL] add comment support for Spar...
Github user tsingfu commented on the pull request: https://github.com/apache/spark/pull/3501#issuecomment-65760992 @marmbrus Need we do something more. If this implement is pretty complex, We may consider that reduce the number of comment support styles(only support -- as comment marker) to make code more simple, What do you think about? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4528][SQL] add comment support for Spar...
Github user tsingfu commented on the pull request: https://github.com/apache/spark/pull/3501#issuecomment-65187921 I have correct the code uncompatible with scalastyle and passed the scalastyle check in local. With test, Hive CLI *bin/hive* does not support comment **until now**. Maybe the funciton fiterComment can be also used in in **Hive**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4528][SQL] add comment support for Spar...
GitHub user tsingfu opened a pull request: https://github.com/apache/spark/pull/3501 [SPARK-4528][SQL] add comment support for Spark SQL CLI The relative JIRA: https://issues.apache.org/jira/browse/SPARK-4528?filter=-2 While using *spark-sql*, found it does not support comment while write sqls. **Comment support** is widely using in many projects, it is a necessary to add this feature. Added one function *filterComment()* in the source org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver.scala. # three comment styles supported: 1. From a '#' character to the end of the line. 2. From a '--' sequence to the end of the line 3. From a /* sequence to the following */ sequence, as in the C programming language. This syntax allows a comment to extend over multiple lines because the beginning and closing sequences need not be on the same line. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tsingfu/spark SPARK-4528 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3501.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3501 commit 390aaf2b348bdc70bcfd1fa2a64c8b481deafa6f Author: tsingfu yangfuq...@gmail.com Date: 2014-11-26T10:01:24Z [SparkSQL][SPARK-4528] add comment support for Spark SQL CLI spark-sql commit 7a9681640e6059bc22686cbd01f2f9c7d1199153 Author: tsingfu yangfuq...@gmail.com Date: 2014-11-27T08:51:18Z [SparkSQL][SPARK-4528] modify function filterComment to make code more concise commit 8b8d343d30e6d3c8546622a06e0e05cec4d9e33a Author: tsingfu yangfuq...@gmail.com Date: 2014-11-27T11:51:39Z [SparkSQL][SPARK-4528] add case class CommentMark to make code more concise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SparkSQL][SPARK-4528] add comment support for...
GitHub user tsingfu opened a pull request: https://github.com/apache/spark/pull/3477 [SparkSQL][SPARK-4528] add comment support for Spark SQL CLI spark-sql while using *spark-sql*, found it does not support comment while write sqls. **Comment support** is widely using in many projects, it is a necessary to add this feature. this implitation can be archived in the source org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver.scala. # three comment styles supported: 1. From a '#' character to the end of the line. 2. From a '--' sequence to the end of the line 3. From a /* sequence to the following */ sequence, as in the C programming language. This syntax allows a comment to extend over multiple lines because the beginning and closing sequences need not be on the same line. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tsingfu/spark SPARK-4528 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3477 commit 390aaf2b348bdc70bcfd1fa2a64c8b481deafa6f Author: tsingfu yangfuq...@gmail.com Date: 2014-11-26T10:01:24Z [SparkSQL][SPARK-4528] add comment support for Spark SQL CLI spark-sql --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SparkSQL][SPARK-4528] add comment support for...
Github user tsingfu closed the pull request at: https://github.com/apache/spark/pull/3477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
