[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-09 Thread varadharajan
Github user varadharajan commented on the pull request:

https://github.com/apache/spark/pull/2894#issuecomment-62350096
  
@jkbradley  Thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4001][MLlib] adding apriori algorithm f...

2014-11-08 Thread varadharajan
Github user varadharajan commented on the pull request:

https://github.com/apache/spark/pull/2847#issuecomment-62263230
  
As mentioned in comments of SPARK-2432. I was wondering how the PFP 
versions compared with YAFIM 
(http://pasa-bigdata.nju.edu.cn/people/ronggu/pub/YAFIM_ParLearning.pdf). 
Probably i will do a bit more reading on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread varadharajan
Github user varadharajan commented on the pull request:

https://github.com/apache/spark/pull/2894#issuecomment-62259405
  
Also i think it would help users if we can document in the LR section of 
the MLlib guide, which algorithm should be preferred in which scenarios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread varadharajan
Github user varadharajan commented on the pull request:

https://github.com/apache/spark/pull/2894#issuecomment-62259256
  
@jkbradley Makes sense. I've updated the warnings, please let me know if 
wordings can be improved. Also i just noticed that pyspark classification model 
does not have LR-LBFGS implementation. I'll probably create a new issue and 
work on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-03 Thread varadharajan
Github user varadharajan commented on the pull request:

https://github.com/apache/spark/pull/2894#issuecomment-61589586
  
Thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-10-24 Thread varadharajan
Github user varadharajan commented on the pull request:

https://github.com/apache/spark/pull/2894#issuecomment-60408059
  
Here are list of scala examples that i think is similar / naive 
implementation of algorithms from MLlib or graphx.

1. LocalALS
2. LocalFileLR
3. LocalKMeans
4. LocalLR
5. SparkALS
6. SparkHdfsLR
7. SparkKMeans
8. SparkLR
9. SparkPageRank (*)
10. SparkTachyonHdfsLR (*)


Python examples:

1. ALS
2. kmeans
3. logistic_regression
4. pagerank (*)

Java examples:

1. JavaHdfsLR (*)
2. JavaPageRank (*)

* - Examples with missing warnings. I've updated JIRA with these details 
and also added warning for them

I've also corrected class names of existing LR examples. They were pointing 
to org.apache.spark.mllib.classification.LogisticRegression instead of 
org.apache.spark.mllib.classification.LogisticRegressionModel

I've excluded examples that compute transitive closures on graphs because 
i'm was not able to find corresponding implementations in graphx. Please let me 
know if i'm missing something


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-10-22 Thread varadharajan
GitHub user varadharajan opened a pull request:

https://github.com/apache/spark/pull/2894

[SPARK-4047] - Generate runtime warnings for example implementation of 
PageRank

Based on SPARK-2434, this PR generates runtime warnings for example 
implementations (Python, Scala) of PageRank.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/varadharajan/spark SPARK-4047

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/2894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2894


commit 5c2bf5453834ad406a62d9e95d8ce128a65a2680
Author: Varadharajan Mukundan 
Date:   2014-10-22T16:47:59Z

[SPARK-4047] - Generate runtime warnings for example implementation of 
PageRank




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org