[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31992: [SPARK-34898][CORE] We should send SparkListenerExecutorMetricsUpdateEventLog of `driver` appropriately
AngersZh commented on a change in pull request #31992:
URL: https://github.com/apache/spark/pull/31992#discussion_r652323059
##
File path:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
##
@@ -249,6 +249,9 @@ private[spark] class EventLoggingListener(
}
override def onExecutorMetricsUpdate(event:
SparkListenerExecutorMetricsUpdate): Unit = {
+if (event.execId == SparkContext.DRIVER_IDENTIFIER) {
+ logEvent(event)
+}
Review comment:
> Currently, we have a single event for both driver and executor metrics
update - differentiated by exec id.
> I dont have strong opinions on this, but if we have a flag
(`shouldLogStageExecutorMetrics`) controlling whether metrics are to be
updated, we should consistently apply it IMO.
@mridulm Follow this comment, how about current.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31992: [SPARK-34898][CORE] We should send SparkListenerExecutorMetricsUpdateEventLog of `driver` appropriately
AngersZh commented on a change in pull request #31992:
URL: https://github.com/apache/spark/pull/31992#discussion_r603734003
##
File path:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
##
@@ -249,6 +249,9 @@ private[spark] class EventLoggingListener(
}
override def onExecutorMetricsUpdate(event:
SparkListenerExecutorMetricsUpdate): Unit = {
+if (event.execId == SparkContext.DRIVER_IDENTIFIER) {
+ logEvent(event)
+}
Review comment:
> Do this only when `shouldLogStageExecutorMetrics` is enabled ?
I don't thinks it should be controlled by `shouldLogStageExecutorMetrics `.
since driver's metrics is not related to stage executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31992: [SPARK-34898][CORE] We should send SparkListenerExecutorMetricsUpdateEventLog of `driver` appropriately
AngersZh commented on a change in pull request #31992: URL: https://github.com/apache/spark/pull/31992#discussion_r603734069 ## File path: core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala ## @@ -618,6 +619,10 @@ class EventLoggingListenerSuite extends SparkFunSuite with LocalSparkContext wit assert(expected.stageInfo.stageId === actual.stageInfo.stageId) case (expected: SparkListenerTaskEnd, actual: SparkListenerTaskEnd) => assert(expected.stageId === actual.stageId) + case (expected: SparkListenerExecutorMetricsUpdate, + acture: SparkListenerExecutorMetricsUpdate) => Review comment: > `acture` -> `actual` DOne -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
