[GitHub] [spark] AngersZhuuuu commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AngersZh commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545732686 @gatorsmile Open pr for branch-2.4. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AngersZh commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545807320 > Could you please add some unit test? This pr is to fix problem comment in https://github.com/apache/spark/pull/26187#issue-330237160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AngersZh commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545820563 @gatorsmile @HyukjinKwon @uncleGen First test failed because in `PlanParserSuit`, method `withSQLConf` will change SQLConf of `SQLConf.get()` so it's good for origin way. since in `ParserDriver` it use `SQLConf.get`. Nest commit i change like below to fix this problem. ``` /** For test-only. */ - object CatalystSqlParser extends AbstractSqlParser(new SQLConf()) { - val astBuilder = new AstBuilder(new SQLConf()) - } + object CatalystSqlParser extends AbstractSqlParser(SQLConf.get) { + val astBuilder = new AstBuilder(SQLConf.get) + } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org