[GitHub] [spark] Gschiavon commented on pull request #27578: [SPARK-30828][SQL] Improving insertInto behaviour

2020-05-11 Thread GitBox


Gschiavon commented on pull request #27578:
URL: https://github.com/apache/spark/pull/27578#issuecomment-626654643


   Hi @dilipbiswal !
   
   It seems that for the case you just mention it would be a breaking change. 
   
   TBH I prefer the job failing than the job working but doing unexpected 
castings or different things. WDYT?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Gschiavon commented on pull request #27578: [SPARK-30828][SQL] Improving insertInto behaviour

2020-05-10 Thread GitBox


Gschiavon commented on pull request #27578:
URL: https://github.com/apache/spark/pull/27578#issuecomment-626487699


   @AmplabJenkins 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Gschiavon commented on pull request #27578: [SPARK-30828][SQL] Improving insertInto behaviour

2020-04-29 Thread GitBox


Gschiavon commented on pull request #27578:
URL: https://github.com/apache/spark/pull/27578#issuecomment-621288446


   ping @dongjoon-hyun 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Gschiavon commented on pull request #27578: [SPARK-30828][SQL] Improving insertInto behaviour

2020-04-28 Thread GitBox


Gschiavon commented on pull request #27578:
URL: https://github.com/apache/spark/pull/27578#issuecomment-620425142


   @AmplabJenkins 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org