[GitHub] [spark] HeartSaVioR commented on a diff in pull request #37161: [SPARK-39748][SQL][SS] Include the origin logical plan for LogicalRDD if it comes from DataFrame
HeartSaVioR commented on code in PR #37161: URL: https://github.com/apache/spark/pull/37161#discussion_r919518440 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -705,6 +705,7 @@ class Dataset[T] private[sql]( LogicalRDD( logicalPlan.output, internalRdd, + None, Review Comment: #37167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a diff in pull request #37161: [SPARK-39748][SQL][SS] Include the origin logical plan for LogicalRDD if it comes from DataFrame
HeartSaVioR commented on code in PR #37161: URL: https://github.com/apache/spark/pull/37161#discussion_r919505305 ## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ## @@ -705,6 +705,7 @@ class Dataset[T] private[sql]( LogicalRDD( logicalPlan.output, internalRdd, + None, Review Comment: That is a silly missing point. Thanks for finding this out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org