[GitHub] [spark] HeartSaVioR commented on issue #26981: [SPARK-26389][SS][FOLLOW-UP]Format config name to follow the other boolean conf naming convention
HeartSaVioR commented on issue #26981: [SPARK-26389][SS][FOLLOW-UP]Format config name to follow the other boolean conf naming convention URL: https://github.com/apache/spark/pull/26981#issuecomment-568343316 It would be great if we make clear about "Does this PR introduce any user-facing change?"; which versions are affected by such incompatible change. If official versions are contained we should also link both via AlternateConfig. I know that's only applied to 3.0.0 so I don't expect we want to use AlternateConfig to couple them, but given the description of PR describes "yes" on the statement, so better to be clear. (Given this is FOLLOW-UP of the feature which is not released officially, maybe "No" is OK as well.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #26981: [SPARK-26389][SS][FOLLOW-UP]Format config name to follow the other boolean conf naming convention
HeartSaVioR commented on issue #26981: [SPARK-26389][SS][FOLLOW-UP]Format config name to follow the other boolean conf naming convention URL: https://github.com/apache/spark/pull/26981#issuecomment-568690885 retest this, please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #26981: [SPARK-26389][SS][FOLLOW-UP]Format config name to follow the other boolean conf naming convention
HeartSaVioR commented on issue #26981: [SPARK-26389][SS][FOLLOW-UP]Format config name to follow the other boolean conf naming convention URL: https://github.com/apache/spark/pull/26981#issuecomment-568716109 FYI #27001 (SPARK-30345) is raised to fix the test build 115646 (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115646/testReport) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
