[GitHub] [spark] Hisoka-X commented on a diff in pull request #42737: [SPARK-44987][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1100`

2023-08-30 Thread via GitHub 


Hisoka-X commented on code in PR #42737:
URL: https://github.com/apache/spark/pull/42737#discussion_r1310155968


##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -2210,6 +2210,12 @@
 ],
 "sqlState" : "42607"
   },
+  "NON_FOLDABLE_ARGUMENT" : {
+"message" : [
+  "The function  requires the parameter  to be a 
foldable expression of the type , but the actual argument is a 
non-foldable."

Review Comment:
   After thinking about it, I really didn't find a better way to express it.



##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -2210,6 +2210,12 @@
 ],
 "sqlState" : "42607"
   },
+  "NON_FOLDABLE_ARGUMENT" : {
+"message" : [
+  "The function  requires the parameter  to be a 
foldable expression of the type , but the actual argument is a 
non-foldable."

Review Comment:
   After thinking about it, I really didn't find a better way to express it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] Hisoka-X commented on a diff in pull request #42737: [SPARK-44987][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_1100`

2023-08-30 Thread via GitHub 


Hisoka-X commented on code in PR #42737:
URL: https://github.com/apache/spark/pull/42737#discussion_r1310125178


##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -2210,6 +2210,12 @@
 ],
 "sqlState" : "42607"
   },
+  "NON_FOLDABLE_ARGUMENT" : {
+"message" : [
+  "The function  requires the parameter  to be a 
foldable expression of the type , but the actual argument is a 
non-foldable."

Review Comment:
   I'm a bit concerned, does the user know what is foldable and what is 
non-foldable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org