[GitHub] [spark] Hisoka-X commented on pull request #42783: [SPARK-45059][CONNECT][PYTHON] Add `try_reflect` functions to Scala and Python

2023-09-04 Thread via GitHub 


Hisoka-X commented on PR #42783:
URL: https://github.com/apache/spark/pull/42783#issuecomment-1704947498

   > 
https://github.com/apache/spark/blob/b0b7835bee2837c6e2875547aca259e02d2b0af7/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala#L211-L212
   > 
   > @Hisoka-X Should this `ProblemFilters` be removed after the current pr?
   
   Oh, sorry about that. Let me create a PR to remove it. Thanks @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] Hisoka-X commented on pull request #42783: [SPARK-45059][CONNECT][PYTHON] Add `try_reflect` functions to Scala and Python

2023-09-04 Thread via GitHub 


Hisoka-X commented on PR #42783:
URL: https://github.com/apache/spark/pull/42783#issuecomment-1704851215

   Thanks @zhengruifeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org