[GitHub] [spark] HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github
HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github URL: https://github.com/apache/spark/pull/25898#discussion_r336929022 ## File path: dev/run-tests-jenkins.py ## @@ -183,6 +183,8 @@ def main(): os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7" if "test-hadoop3.2" in ghprb_pull_title: os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop3.2" +if "test-java11" in ghprb_pull_title: Review comment: Oh, I thought we set up roughly necessary things. We currently build against 8 and test against JDK 11 in Jenkins. JDK11 build seems being tested via github workflow (https://github.com/apache/spark/runs/267887669) I think we don't explicitly run JDK 11 build and JDK 11 tests yet if I didn't miss anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github
HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github URL: https://github.com/apache/spark/pull/25898#discussion_r336930425 ## File path: dev/run-tests-jenkins.py ## @@ -232,6 +234,10 @@ def main(): result_message = github_message('has finished') result_message += '\n' + test_result_note + '\n' result_message += '\n'.join(pr_check_results) +result_message += '\n' + ' * This patch tested by `%s` with `%s` and `%s`.' % ( +os.environ.get("AMPLAB_JENKINS_BUILD_TOOL", "sbt"), +os.environ.get("AMPLAB_JENKINS_BUILD_PROFILE", "hadoop2.7"), +os.environ.get("AMPLAB_JENKINS_BUILD_JDK", "java8")) Review comment: ditto for a note. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github
HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github URL: https://github.com/apache/spark/pull/25898#discussion_r336930352 ## File path: dev/run-tests-jenkins.py ## @@ -232,6 +234,10 @@ def main(): result_message = github_message('has finished') result_message += '\n' + test_result_note + '\n' result_message += '\n'.join(pr_check_results) +result_message += '\n' + ' * This patch tested by `%s` with `%s` and `%s`.' % ( +os.environ.get("AMPLAB_JENKINS_BUILD_TOOL", "sbt"), +os.environ.get("AMPLAB_JENKINS_BUILD_PROFILE", "hadoop2.7"), Review comment: one nit is though we should change this when we change default profile. Might better note it at `pom.xml` so that they can be updated together. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github
HyukjinKwon commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github URL: https://github.com/apache/spark/pull/25898#discussion_r339337284 ## File path: dev/run-tests-jenkins.py ## @@ -183,6 +183,8 @@ def main(): os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7" if "test-hadoop3.2" in ghprb_pull_title: os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop3.2" +if "test-java11" in ghprb_pull_title: Review comment: Ah, -release 8 wasn't resolved IIRC This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org