[GitHub] [spark] HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…
HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where… URL: https://github.com/apache/spark/pull/26319#discussion_r392141517 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ## @@ -1901,6 +1909,7 @@ case class NestedStruct(f: ClassData) case class DeepNestedStruct(f: NestedStruct) case class InvalidInJava(`abstract`: Int) +private case class InvalidInJavaForNumber(`1something`: String) Review comment: You can just explain in the PR description. Let's just remove this test case, and describe how you can test in Spark shell in the PR description. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…
HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where… URL: https://github.com/apache/spark/pull/26319#discussion_r392014094 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ## @@ -1901,6 +1909,7 @@ case class NestedStruct(f: ClassData) case class DeepNestedStruct(f: NestedStruct) case class InvalidInJava(`abstract`: Int) +private case class InvalidInJavaForNumber(`1something`: String) Review comment: Ah .. this is being converted into Java class to generate Javadoc. So it causes compilation error when it does. Can you simply remove the test case here and show the reproducer to test under "How was this patch tested?"? Otherwise, seems fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…
HyukjinKwon commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where… URL: https://github.com/apache/spark/pull/26319#discussion_r390726359 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ## @@ -1901,6 +1909,7 @@ case class NestedStruct(f: ClassData) case class DeepNestedStruct(f: NestedStruct) case class InvalidInJava(`abstract`: Int) +private[sql] case class InvalidInJavaForNumber(`1something`: String) Review comment: I think you can just remove `private[sql] ` or use `private` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
