[GitHub] [spark] HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs
HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#discussion_r377394873 ## File path: docs/README.md ## @@ -31,15 +31,41 @@ whichever version of Spark you currently have checked out of revision control. The Spark documentation build uses a number of tools to build HTML docs and API docs in Scala, Java, Python, R and SQL. -You need to have [Ruby](https://www.ruby-lang.org/en/documentation/installation/) and -[Python](https://docs.python.org/2/using/unix.html#getting-and-installing-the-latest-version-of-python) -installed. Also install the following libraries: +You need to have Ruby 2 and Python 3 installed. A handy way to install and manage various versions of Ruby and Python is with [`rbenv`] and [`pyenv`]. Review comment: @nchammas, what about we keep the default way, and simply mention such pyend, virtualenv or conda? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs
HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#discussion_r377394628 ## File path: docs/README.md ## @@ -58,7 +84,7 @@ Note: Other versions of roxygen2 might work in SparkR documentation generation b To generate API docs for any language, you'll need to install these libraries: ```sh -$ sudo pip install sphinx mkdocs numpy +pip install sphinx==2.3.1 mkdocs==1.0.4 numpy==1.18.1 Review comment: @nchammas, btw why should we fix the version? I think it's better to promote the latest versions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs
HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#discussion_r377394406 ## File path: dev/create-release/spark-rm/Dockerfile ## @@ -20,9 +20,9 @@ # Includes: Review comment: @dongjoon-hyun and @wangyum might better to review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs
HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#discussion_r377394288 ## File path: python/docs/Makefile ## @@ -4,7 +4,6 @@ # You can set these variables from the command line. Review comment: +1 for this change too although I didn't check the details. This Makefile was from the old sphinx example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs
HyukjinKwon commented on a change in pull request #27534: [SPARK-30731][DOCS] Refine workflow for building docs URL: https://github.com/apache/spark/pull/27534#discussion_r377394186 ## File path: sql/mkdocs.yml ## @@ -15,5 +15,5 @@ site_name: Spark SQL, Built-in Functions theme: readthedocs -pages: +nav: Review comment: Yeap, I saw the warning. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
