[GitHub] [spark] HyukjinKwon commented on a change in pull request #34688: [SPARK-32079][PYTHON] Remove namedtuple hack by replacing built-in pickle to cloudpickle
HyukjinKwon commented on a change in pull request #34688: URL: https://github.com/apache/spark/pull/34688#discussion_r755712526 ## File path: python/pyspark/serializers.py ## @@ -19,7 +19,7 @@ PySpark supports custom serializers for transferring data; this can improve performance. -By default, PySpark uses :class:`PickleSerializer` to serialize objects using Python's +By default, PySpark uses :class:`CPickleSerializer` to serialize objects using Python's `cPickle` serializer, which can serialize nearly any Python object. Review comment: ```suggestion C-based pickle serializer, which can serialize nearly any Python object. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34688: [SPARK-32079][PYTHON] Remove namedtuple hack by replacing built-in pickle to cloudpickle
HyukjinKwon commented on a change in pull request #34688: URL: https://github.com/apache/spark/pull/34688#discussion_r754955918 ## File path: python/pyspark/serializers.py ## @@ -19,7 +19,7 @@ PySpark supports custom serializers for transferring data; this can improve performance. -By default, PySpark uses :class:`PickleSerializer` to serialize objects using Python's +By default, PySpark uses :class:`CloudPickleSerializer` to serialize objects using Python's Review comment: ```suggestion By default, PySpark uses :class:`CPickleSerializer` to serialize objects using Python's ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34688: [SPARK-32079][PYTHON] Remove namedtuple hack by replacing built-in pickle to cloudpickle
HyukjinKwon commented on a change in pull request #34688: URL: https://github.com/apache/spark/pull/34688#discussion_r754951023 ## File path: python/pyspark/__init__.pyi ## @@ -38,7 +38,7 @@ from pyspark.profiler import ( # noqa: F401 from pyspark.rdd import RDD as RDD, RDDBarrier as RDDBarrier # noqa: F401 from pyspark.serializers import ( # noqa: F401 MarshalSerializer as MarshalSerializer, -PickleSerializer as PickleSerializer, +CPickleSerializer as CPickleSerializer, Review comment: ```suggestion PickleSerializer as PickleSerializer CPickleSerializer as CPickleSerializer,, ``` ## File path: python/pyspark/__init__.pyi ## @@ -38,7 +38,7 @@ from pyspark.profiler import ( # noqa: F401 from pyspark.rdd import RDD as RDD, RDDBarrier as RDDBarrier # noqa: F401 from pyspark.serializers import ( # noqa: F401 MarshalSerializer as MarshalSerializer, -PickleSerializer as PickleSerializer, +CPickleSerializer as CPickleSerializer, Review comment: ```suggestion PickleSerializer as PickleSerializer, CPickleSerializer as CPickleSerializer, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34688: [SPARK-32079][PYTHON] Remove namedtuple hack by replacing built-in pickle to cloudpickle
HyukjinKwon commented on a change in pull request #34688: URL: https://github.com/apache/spark/pull/34688#discussion_r754950755 ## File path: python/pyspark/__init__.py ## @@ -136,7 +136,7 @@ def wrapper(self, *args, **kwargs): "Accumulator", "AccumulatorParam", "MarshalSerializer", -"PickleSerializer", +"CPickleSerializer", Review comment: ```suggestion "PickleSerializer", "CPickleSerializer", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
