HyukjinKwon commented on a change in pull request #35129:
URL: https://github.com/apache/spark/pull/35129#discussion_r780066447
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -44,22 +44,23 @@ import org.apache.spark.util.Utils
*
* To run the entire test suite:
* {{{
- * build/sbt "sql/testOnly *SQLQueryTestSuite"
+ * build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
* }}}
*
* To run a single test file upon change:
* {{{
- * build/sbt "~sql/testOnly *SQLQueryTestSuite -- -z inline-table.sql"
+ * build/sbt "~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z
inline-table.sql"
Review comment:
This one shouldn't be updated because there's
`sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala`
to verify the results. We should be only explicit when we generate golden
files. Can we document this since we're here?
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -44,22 +44,23 @@ import org.apache.spark.util.Utils
*
* To run the entire test suite:
* {{{
- * build/sbt "sql/testOnly *SQLQueryTestSuite"
+ * build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
* }}}
*
* To run a single test file upon change:
* {{{
- * build/sbt "~sql/testOnly *SQLQueryTestSuite -- -z inline-table.sql"
+ * build/sbt "~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z
inline-table.sql"
* }}}
*
* To re-generate golden files for entire suite, run:
* {{{
- * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite"
+ * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly
org.apache.spark.sql.SQLQueryTestSuite"
* }}}
*
* To re-generate golden file for a single test, run:
* {{{
- * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite
-- -z describe.sql"
+ * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt
Review comment:
Can we add line breaks so we can run this via copying and pasting?
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -44,22 +44,23 @@ import org.apache.spark.util.Utils
*
* To run the entire test suite:
* {{{
- * build/sbt "sql/testOnly *SQLQueryTestSuite"
+ * build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
* }}}
*
* To run a single test file upon change:
* {{{
- * build/sbt "~sql/testOnly *SQLQueryTestSuite -- -z inline-table.sql"
+ * build/sbt "~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z
inline-table.sql"
Review comment:
This one shouldn't be updated because there's
`sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala`
to verify the results. We should be only explicit when we generate golden
files. Can we document this since we're here?
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -36,6 +36,7 @@ import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.tags.ExtendedSQLTest
import org.apache.spark.util.Utils
+// scalastyle:off line.size.limit
Review comment:
can you on this style back at the end of this Scaladoc?
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##
@@ -36,6 +36,7 @@ import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.tags.ExtendedSQLTest
import org.apache.spark.util.Utils
+// scalastyle:off line.size.limit
Review comment:
can you turn on this style back at the end of this Scaladoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
